Details
Sub-task
Description
Another thing: I was so lucky because get the daily send of digest mails in action. And this line:
if ($digestposts = get_records('forum_queue')) {
just crash if there are too many records in the table (right now one server has more than 800.000!).
I would propose to:
- Change code to use one recordset.
- Add one more query to delete old records say, one week, at the begining of the forum cron. just to avoid current and future accumulation!
- Add some trace message about the digest process starting (was impossible to detect if before!).
And this is the called DIGEST_CRON_PROBLEM from now.
I continue advancing...
Issue Links
| This issue will help resolve: | ||||
| MDLSITE-254 | forum daily digest from moodle.org (subjects only} not coming since August 29. 2007 |
|
|
|
| This issue will be resolved by: | ||||
| MDL-11658 | Problem in cron with forum memory usage |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
If you aren't working on this, I had planned to start this today (implementing the 3 points above).
Just confirm, plz. Ciao 
if I tried the "if (true)" approach and the disgest part hasn't be executed at all!
The key here is that, if there are a lot of forum->posts, memory grows and grows beyond limit (due to MDL-11658) and the process die in the middle of the "normal" (non-digest) send of mail.
So I'm going to mark this as "fixeable by MDL-11658". Also there are some minor improvements in the "digest" part (some recordsets here and there) but we need the memory problem fixed before anything else.
Until then, I'm going to raise the memory limit a bit - moodle,org only (to be able to finish the forum cron execution often).
Ciao
Hi Paolo,
I've changed some bits here and there in digests generation (after having MDL-11658 also fixed by Petr) and moodle.org digests are being sent right now.
Can you confirm if you've received it and if it's ok? (I forgot to change my preferences to receive digests, grrr). It should contain messages from last 24 hours only.
TIA and ciao
Oki,
I'm going to close this because I've received digests last two days.
Also, I've implemented and tested (today in moodle.org) one small change, moving this line:
set_config('digestmailtimelast', $timenow);
to the end of the loop, allowing digests to continue in next cron execution if something has failed in the previous one. It should be 100% safe because each iteration deletes the records from the queue before processing them, so no duplicates - nor getting stuck forever in one user - are possible at all.
Ciao
Ah! great! I guess it got so big only because of the other issues stopping it getting so far.