Moodle

Missing lang strings in glossary

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.8.4, 1.9, 1.9.6, 2.0
  • Component/s: Glossary, Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

In glossary are some hard coded language elements and some missing english strings on glossary/formats.php (see screenshot)

Attachments

  1. Text File
    glossary_strings.patch
    17/Aug/09 10:58 PM
    5 kB
    Anthony Borrow
  1. glossary_faq.png
    14 kB
    17/Oct/07 1:08 AM
  2. mdl-11790.png
    165 kB
    17/Aug/09 10:57 PM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nicolas Connault added a comment -

Added missing strings

Show
Nicolas Connault added a comment - Added missing strings
Hide
Permalink
Nicolas Martignoni added a comment -

Reopening, as "Include Group Breaks" is hardcoded.

Show
Nicolas Martignoni added a comment - Reopening, as "Include Group Breaks" is hardcoded.
Hide
Permalink
Nicolas Martignoni added a comment -

Strings "letter", "cat", "date" and "author" in menu Defaut mode are hardcoded too.

Show
Nicolas Martignoni added a comment - Strings "letter", "cat", "date" and "author" in menu Defaut mode are hardcoded too.
Hide
Permalink
Nicolas Connault added a comment -

Hard-coded strings no longer hard-coded

Show
Nicolas Connault added a comment - Hard-coded strings no longer hard-coded
Hide
Permalink
Nicolas Martignoni added a comment -

Verified, closing. Thanks Nicolas.

Show
Nicolas Martignoni added a comment - Verified, closing. Thanks Nicolas.
Hide
Permalink
Anthony Borrow added a comment -

Nicolas - I am re-opening this because the missing strings have not been added to 19STABLE but it appears that the changes to /mod/glossary/format.php have been added to 19STABLE so we still have missing language strings there. Let me know if you have any questions. Peace - Anthony

Show
Anthony Borrow added a comment - Nicolas - I am re-opening this because the missing strings have not been added to 19STABLE but it appears that the changes to /mod/glossary/format.php have been added to 19STABLE so we still have missing language strings there. Let me know if you have any questions. Peace - Anthony
Hide
Permalink
Nicolas Connault added a comment -

Fixed, thanks Anthony!

Show
Nicolas Connault added a comment - Fixed, thanks Anthony!
Hide
Permalink
Anthony Borrow added a comment -

here is what I am seeing with 19stable

Show
Anthony Borrow added a comment - here is what I am seeing with 19stable
Hide
Permalink
Anthony Borrow added a comment -

I diffed to HEAD and had a few more strings - not sure if they are all relevant but perhaps worth reviewing. Peace - Anthony

Show
Anthony Borrow added a comment - I diffed to HEAD and had a few more strings - not sure if they are all relevant but perhaps worth reviewing. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

re-opening for next year

Show
Anthony Borrow added a comment - re-opening for next year
Hide
Permalink
Anthony Borrow added a comment -

Nicolas - I went ahead and committed the other missing strings. Here is what I think the CVS logs reveal. It looks like things were moving along with getting this applied in MAIN around the time that 1.9 was ready to be released. When Petr created 19STABLE it looks like he may not have done an update causing the /lang/en_utf8/glossary.php file to be created for 19STABLE from revision 1.8 rather than 1.10 - I am basing this off of the revision numbering for 19STABLE (1.8.2.1). Thus the change for revision 1.9 and 1.10 were not included. Your patch earlier today took care of the diff from 1.9 to 1.10 and the one I just applied took care of the diff between revision 1.8 to 1.9. So I think it is safe to resolve this now but I will let you close it. I was more interested in how this happened than necessarily fixing it but alas I think it is fixed and I am satisfied in understanding what happened - or at least something along the lines of what might have happened. Peace - Anthony

Show
Anthony Borrow added a comment - Nicolas - I went ahead and committed the other missing strings. Here is what I think the CVS logs reveal. It looks like things were moving along with getting this applied in MAIN around the time that 1.9 was ready to be released. When Petr created 19STABLE it looks like he may not have done an update causing the /lang/en_utf8/glossary.php file to be created for 19STABLE from revision 1.8 rather than 1.10 - I am basing this off of the revision numbering for 19STABLE (1.8.2.1). Thus the change for revision 1.9 and 1.10 were not included. Your patch earlier today took care of the diff from 1.9 to 1.10 and the one I just applied took care of the diff between revision 1.8 to 1.9. So I think it is safe to resolve this now but I will let you close it. I was more interested in how this happened than necessarily fixing it but alas I think it is fixed and I am satisfied in understanding what happened - or at least something along the lines of what might have happened. Peace - Anthony
Hide
Permalink
Rossiani Wijaya added a comment -

resolved. closing

Show
Rossiani Wijaya added a comment - resolved. closing

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.