[#MDL-11830] width of login button too small

Issue Details (XML | Word | Printable)

Key:	MDL-11830
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Miroslav Fikar
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

width of login button too small

Created: 19/Oct/07 03:16 AM Updated: 08/Jan/08 04:35 PM

Return to search

Component/s:

Accessibility

Affects Version/s:

1.8.3

Fix Version/s:

1.9, 2.0

File Attachments:

None

Image Attachments:

1. login.jpg
(3 kB)

2. moodleorg.png
(9 kB)

Environment:

any

Participants:	Dan Poltawski, Miroslav Fikar and Petr Skoda
Security Level:	None
Resolved date:	08/Jan/08
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Width of login button in Slovak and Czech languages is too small (see attached figure) . It is currently defined in blocks/login/styles.php by 5em:
.block_login .loginform .c1 input {
width:5em;
}

I propose to change it to 6em. That is satisfactory fro both languages and does not pose problems in other languages.

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/Dec/07 07:54 AM

~~MDL-11830~~ a bit bigger button in login block, removing colons and adding css spacing

MODIFY	blocks/login/block_login.php		Rev. 1.22.2.1		(+3 -3 lines)
MODIFY	blocks/login/styles.php		Rev. 1.5.2.1		(+5 -1 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 31/Dec/07 07:55 AM

~~MDL-11830~~ a bit bigger button in login block, removing colons and adding css spacing; merged from MOODLE_19_STABLE

MODIFY	blocks/login/block_login.php		Rev. 1.23		(+3 -3 lines)
MODIFY	blocks/login/styles.php		Rev. 1.6		(+5 -1 lines)

Petr Skoda made changes - 31/Dec/07 08:00 AM

Field	Original Value	New Value
Assignee	Martin Dougiamas [ dougiamas ]	Petr Skoda [ skodak ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 31/Dec/07 08:01 AM

fixed in cvs, thanks for the report

Petr Skoda made changes - 31/Dec/07 08:01 AM

Fix Version/s		2.0 [ 10122 ]
Fix Version/s		1.9 [ 10190 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Dan Poltawski added a comment - 08/Jan/08 12:51 AM

Reopening, username now above the input box on moodle.org in firefox (with mega-wide screen). Screenshot incoming..

Dan Poltawski made changes - 08/Jan/08 12:52 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

[ Permalink | « Hide ]

Dan Poltawski added a comment - 08/Jan/08 12:52 AM

Screenshot of moodle.org right now

Dan Poltawski made changes - 08/Jan/08 12:52 AM

Attachment

moodleorg.png [ 12757 ]

[ Permalink | « Hide ]

Miroslav Fikar added a comment - 08/Jan/08 01:11 AM

In some languages, username is above, in some languages password as well. Is there any possibility to enlarge the button only?

[ Permalink | « Hide ]

Petr Skoda added a comment - 08/Jan/08 01:43 AM

yep, that should be possible

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/Jan/08 04:32 PM

~~MDL-11830~~ width applied to input fields only, that should solve the incorrect size of button

MODIFY	blocks/login/block_login.php		Rev. 1.22.2.2		(+3 -3 lines)
MODIFY	blocks/login/styles.php		Rev. 1.5.2.2		(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 08/Jan/08 04:33 PM

~~MDL-11830~~ width applied to input fields only, that should solve the incorrect size of button; merged from MOODLE_19_STABLE

MODIFY	blocks/login/styles.php		Rev. 1.7		(+2 -2 lines)
MODIFY	blocks/login/block_login.php		Rev. 1.24		(+3 -3 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 08/Jan/08 04:35 PM

reverting back to 5em width and removing css width from the button, that should finally solve it for majority of langs.
thanks!

Petr Skoda made changes - 08/Jan/08 04:35 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.