Issue Details (XML | Word | Printable)

Key: MDL-11831
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Yu Zhang
Reporter: Ann Adamcik
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Gradebook will not show all participants when groups are defined, and course group mode is set to no

Created: 19/Oct/07 04:37 AM   Updated: 19/Oct/07 02:54 PM
Return to search
Component/s: Gradebook
Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3
Fix Version/s: 1.8.4

File Attachments: 1. File grade_lib_group.diff (1 kB)


Participants: Ann Adamcik, Anthony Borrow and Yu Zhang
Security Level: None
Resolved date: 19/Oct/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
If there are groups defined in a course, and the course-level groups mode is set to 'no', the gradebook will not always display all participants.

To reproduce (tested on demo.moodle.org):

Set up a course with Group Mode = Visible or Separate. Add at least one group to the course. Go to Participants or Gradebook and choose one of the groups to view. Now edit the course settings and change Group Mode to No. When you view the gradebook, only the group you previously selected will show.

If the course group mode is no, the gradebook should default to showing all participants.

This has been fixed in gradebook_plusV2 - see http://tracker.moodle.org/browse/CONTRIB-105.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Anthony Borrow added a comment - 19/Oct/07 05:50 AM
Yu - Here is a patch for Moodle core (18STABLE) based off of the patch that was used for GBPv2 (CONTRIB-105). I'm trying to encourage that any fixes found and made to GBPv2 also get applied to Moodle core. Let me know if you have any questions. I would check these in myself; however, I do not have the time to adequately test them so I have been hesitant to change things in Moodle core. Thanks for your continued work with Moodle. Peace - Anthony

Anthony Borrow made changes - 19/Oct/07 05:50 AM
Field Original Value New Value
Attachment grade_lib_group.diff [ 12113 ]
toyomoyo committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 19/Oct/07 02:50 PM
MDL-11831, gradebook will not show all participants when groups are defined but groupmode not set
MODIFY grade/lib.php   Rev. 1.65.2.10    (+3 -3 lines)
Yu Zhang added a comment - 19/Oct/07 02:54 PM
Hi, thanks for the report and patch. I noticed that the patches use

if ($currentgroup = get_current_group($course->id) && groupmode($course) != 0) {

I think this is not correct because && has higher precedence than = (assignment) so I put parenthesis around the assignment.

if (($currentgroup = get_current_group($course->id)) && groupmode($course) != 0) {

Please let me know if this is not correct.

Cheer,

Yu


Yu Zhang made changes - 19/Oct/07 02:54 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.8.4 [ 10242 ]