SELECT * FROM mdl_grade_grades WHERE itemid = '191' AND userid = '3751' ORDER BY id
Found more than one record in fetch() !

When I pull up mdl_grade_grades, I find two entries that meet this criteria.

I deleted the entry with the higher id and started again, got the error again - same itemid, different userid. Went into database and found several duplicates for itemid = 191, deleted the second entry on each duplicate.

Ran again, same error this time, but itemid = 190.

Continuing process - I'll comment back how it goes.

The only extra factor I can think of in this is that we ARE using GBPV2.

Are you able to provide a copy of your db before the upgrade to 1.9? That would help us to locate the problem... Also, are all the affected grade items assignments?

Cheers,

Yu

I've sent you an email for the copy of the database - please confirm that you have gotten the file.

Thanks,
Matt

Petr, can you look into the upgrade process and make it deal better with duplicates?

Note: I used a global variable to store the $sql, but I'm sure there's a better way. This was just a quick fix, but you get the idea.

These are the two functions that were changed:

/**

• Factory method - uses the parameters to retrieve matching instance from the DB.
• @static final protected
• @return mixed object insatnce or false if not found
  */
  function fetch_helper($table, $classname, $params) {
  // we have to do use this hack because of the incomplete OOP implementation in PHP4
  // in PHP5 we could do it much better
  if ($instances = grade_object::fetch_all_helper($table, $classname, $params)) {

if (count($instances) > 1) { // we should not tolerate any errors here - problems might appear later global $sql_delete; //KC added echo $sql_delete; //KC added $result_delete = mysql_query($sql_delete) or die(mysql_error()); //KC instead of saying there's an error, it deletes the duplicate and continues //error('Found more than one record in fetch() !'); }
return reset($instances);
} else { return false; }
}

/**
* Factory method - uses the parameters to retrieve all matching instances from the DB.
* @static final protected
* @return mixed array of object instances or false if not found
*/
function fetch_all_helper($table, $classname, $params) {
// we have to do use this hack because of the incomplete OOP implementation in PHP4
// in PHP5 we could do it much better
$instance = new $classname();

$classvars = (array)$instance;
$params = (array)$params;

$wheresql = array();

// remove incorrect params
foreach ($params as $var=>$value) {
if (!in_array($var, $instance->required_fields) and !array_key_exists($var, $instance->optional_fields)) { continue; }
if (is_null($value)) { $wheresql[] = " $var IS NULL "; } else { $value = addslashes($value); $wheresql[] = " $var = '$value' "; }
}

if (empty($wheresql)) { $wheresql = ''; } else { $wheresql = implode("AND", $wheresql); }

if ($datas = get_records_select($table, $wheresql, 'id')) {

$result = array();
foreach($datas as $data) { $instance = new $classname(); grade_object::set_properties($instance, $data); $result[$instance->id] = $instance; }

global $sql_delete; //KC added
//Added by KC 10/11/07 to fix upgrade duplication issue
$sql_delete = "Delete from mdl_" . $table . " where $wheresql LIMIT 1";

return $result;

} else { return false; } }
}

I have tried to artificially add duplicate assignment_submission in 1.8, and tried an upgrade. Upgrade was fine, so I agree with Petr that this bit is not broken. To help us reproduce this problem we would really appreciate a copy of 1.8 dump with broken upgrades, so we can see what is going on. Please feel free to email me yu@moodle.com

Thanks,

Yu

Thanks,
Matt