|
[
Permalink
| « Hide
]
Nicolas Connault added a comment - 27/Oct/07 02:19 PM
So far I haven't been able to reproduce this error.
Nicolas, thank you for checking.
On your email you'll find a Moodle site URL and credentials to check one of the several site where the problem is happening. Uhm.... knowing a bit more about Andrea's server configuration... could this be related to this change performed between 1.8.2 and 1.8.3 ?
http://moodle.cvs.sourceforge.net/moodle/moodle/backup/backuplib.php?r1=1.135.2.3&r2=1.135.2.4 (note the "recursive flag" added there) I guess it isn't necessary and, in fact, if breaking sites with some constraints enabled (open_basedir and friends). It seems that the same problem is happening in other places too: http://moodle.org/mod/forum/discuss.php?d=82708 So perhaps that new parameter shouldn't be used? 18_STABLE, 19_STABLE and HEAD. Ciao Also, it seems to be a good idea to implement
Basically it prevents to start the "recursive" task from "/" and, instead, it's starts from "moodledata", that uses to be a correct directory to perform file operations without problems if running under open_basedir and others. Ciao According to the extensive tests done thanks to Eloy, changing the "recursive" to false or undefined allow backups to complete successfully, even with open_basedir setting starting on moodledata.
What about reverting it to it's original state ? Adding some more hints to reproduce the bug: Removed the recursive param. Not entirely sure if it should be removed from other places in the backuplib.php code, where it is currently used.
Based on the test done with Eloy, the parameter should be removed also from other places.
I have the same problem as described. It started with revision 1.93 of backup/lib.php. I have located the problem in the following line (308):
from: $status = check_dir_exists($to_file, true, true); to: $status = mkdir($to_file,$CFG->directorypermissions); It seems to me, that function backup_copy_dir tries mkdir with an argument that has several new directories in it - and it cannot do it. Looks like its working on my end.
As far as I know the issue is resolved. On all our production systems the patches committed by Eloy and Nicolas works.
Try with the latest CVS version, if not already installed, then try to understand where the automated backups fails from the logs. Closing this. Thanks for your help!
Ciao |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Critical
Course Backups fails when including user files
 |
|
