Moodle

cannot configure rss block on tag page

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9
  • Fix Version/s: STABLE backlog
  • Component/s: Blocks, Tags
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

When I try to add an RSS block, it appears fine, but when I try to click 'configure this block to display RSS feeds'. it takes me to another tag page instead (the first tag in my list of interests). I can configure an RSS block on that page, but not on the original one, which is fourth in my list of interests. I always just end up on the tag page for my first interest.

Deleting the block and adding it again makes no difference. This happens for every tag except my first one.

Issue Links

This issue has a non-specific relationship to:
MDL-13631 lib/phpxml/xml.php causes notice about pass by reference Trivial Closed
This issue has been marked as being related by:
MDL-12008 RSS feeds for tags Minor Open
MDL-11948 validate feed button is broken on rss block configured from tags page Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Gibson added a comment -

With developer debugging on:

Notice: Only variable references should be returned by reference in E:\Moodle_webserver\moodle\lib\phpxml\xml.php on line 73

Show
Matt Gibson added a comment - With developer debugging on: Notice: Only variable references should be returned by reference in E:\Moodle_webserver\moodle\lib\phpxml\xml.php on line 73
Hide
Permalink
Mathieu Petit-Clair added a comment -

I think this notice was fixed yesterday by Martin. Which version are you using?

Show
Mathieu Petit-Clair added a comment - I think this notice was fixed yesterday by Martin. Which version are you using?
Hide
Permalink
Matt Gibson added a comment -

Just updated and its still there. Version is Moodle 1.9 Beta 4 (2007101508.05)

Show
Matt Gibson added a comment - Just updated and its still there. Version is Moodle 1.9 Beta 4 (2007101508.05)
Hide
Permalink
Mathieu Petit-Clair added a comment -

Hmm.. it looks like the fix was only commited in HEAD. I'll see if we can backport it.

Show
Mathieu Petit-Clair added a comment - Hmm.. it looks like the fix was only commited in HEAD. I'll see if we can backport it.
Hide
Permalink
Mathieu Petit-Clair added a comment -

Matt Gibson : it will have to stay like this for 1.9, see MDL-13631 for details.

Show
Mathieu Petit-Clair added a comment - Matt Gibson : it will have to stay like this for 1.9, see MDL-13631 for details.
Hide
Permalink
Matt Gibson added a comment -

Were you able to reproduce the problem -Is it definitely this error thats causing it? I ask because I get that error on the tag page with or without the editing on and even without trying to alter the rss block.

Does this mean that RSS is effectively useless for 1.9? I notice that moodle.org has working RSS feeds in some tag pages - what am I doing differently?

Show
Matt Gibson added a comment - Were you able to reproduce the problem -Is it definitely this error thats causing it? I ask because I get that error on the tag page with or without the editing on and even without trying to alter the rss block. Does this mean that RSS is effectively useless for 1.9? I notice that moodle.org has working RSS feeds in some tag pages - what am I doing differently?
Hide
Permalink
Mathieu Petit-Clair added a comment -

Sorry, I was obviously replying too fast...

The notice isn't the cause of this bug. I can reproduce this bug and will try to fix it (but only have 20 more minutes today), if it's not in 1.9, it should be in 1.9.1.

Show
Mathieu Petit-Clair added a comment - Sorry, I was obviously replying too fast... The notice isn't the cause of this bug. I can reproduce this bug and will try to fix it (but only have 20 more minutes today), if it's not in 1.9, it should be in 1.9.1.
Hide
Permalink
Mathieu Petit-Clair added a comment -

I had a look at the code and it appears the rss block code is really course-specific. It's going to need a bit of work to make it possible to use it on tags. The fact that it works on tag id #1 is just luck : the system thinks that is "course id" #1, not tag id #1.

Show
Mathieu Petit-Clair added a comment - I had a look at the code and it appears the rss block code is really course-specific. It's going to need a bit of work to make it possible to use it on tags. The fact that it works on tag id #1 is just luck : the system thinks that is "course id" #1, not tag id #1.
Hide
Permalink
Martin Dougiamas added a comment -

GIven the short time-frame, I'm pushing this to 1.9.1 and in the meantime we'll take the rss_client block off the tags page.

Show
Martin Dougiamas added a comment - GIven the short time-frame, I'm pushing this to 1.9.1 and in the meantime we'll take the rss_client block off the tags page.
Hide
Permalink
Jon Bolton added a comment -

I needed this, so I altered the code to allow the rss_client block on the tags page again - and it works really well if you manage it properly - see http://socialwork.fife.gov.uk/tag/search.php

The way that I circumvent the problem described in earlier comments is to NOT use the 'Add/Edit feeds link' but rather use the 'configuration' icon in the header of the rss_client block. As you can see, it does work. I have not altered any code other than the line that allowed the rss_client block to appear on the tags page.

It's important for me to use RSS feeds in tag pages, so I'm going to vote for it to be fixed... I'd do it myself and contribute it back if I knew how

Show
Jon Bolton added a comment - I needed this, so I altered the code to allow the rss_client block on the tags page again - and it works really well if you manage it properly - see http://socialwork.fife.gov.uk/tag/search.php The way that I circumvent the problem described in earlier comments is to NOT use the 'Add/Edit feeds link' but rather use the 'configuration' icon in the header of the rss_client block. As you can see, it does work. I have not altered any code other than the line that allowed the rss_client block to appear on the tags page. It's important for me to use RSS feeds in tag pages, so I'm going to vote for it to be fixed... I'd do it myself and contribute it back if I knew how
Hide
Permalink
Nadav Kavalerchik added a comment -

i can confirm Jon Bolton's post

indeed, clicking the add new rss feed does not work
BUT clicking the block's configure icon works fine.

Show
Nadav Kavalerchik added a comment - i can confirm Jon Bolton's post indeed, clicking the add new rss feed does not work BUT clicking the block's configure icon works fine.

People

Vote (4)
Watch (5)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.