Issue Details (XML | Word | Printable)

Key: MDL-11994
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Nick Freear
Reporter: Nick Freear
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-12298

"Users tagged with ..." should be marked up as a list

Created: 01/Nov/07 08:26 PM   Updated: 16/Jan/08 05:43 PM
Return to search
Component/s: Accessibility, Tags
Affects Version/s: 1.9
Fix Version/s: 1.9, 2.0

File Attachments: 1. File patch-MDL-access-tag-lib-lists.diff (2 kB)

Issue Links:
Relates
 

URL: http://moodle.org/tag/?id=1
Participants: Martin Dougiamas, Nick Freear and Nicolas Martignoni
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 16/Jan/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Several accessibility issues:
 - The list of users with images, eg 'Users tagged with "Moodle": 42' should be marked up as an unordered list <ul> - use "inline-list" class,
      http://docs.moodle.org/en/Accessibility_notes#Pattern_1:_unlist.2C_inline-list
 - As the user images are the only contents of a link they should NOT have empty ALT text - basic stuff!

I have a patch, tested on Win/Firefox 2.0.0.8 and IE 6, affecting 2 files:
 - tag/lib.php, print_user_list (clue in the name) and print_user_box functions.
 - theme/standard/styles_layout.css - a long overdue fix for "inline-list" class!

(Also see bug MDL-11430)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear added a comment - 01/Nov/07 08:40 PM
Committed fixes to HEAD, and 1.9 branch tagged _MERGED.

(Luiz Cruz and Petr did a lot of work on tag/lib, see MDL-11048)


Nicolas Martignoni added a comment - 15/Nov/07 03:24 AM
Verified on 1.9beta2, closing.

Martin Dougiamas added a comment - 11/Jan/08 12:21 PM
On moodle.org these are now all being displayed in one column down the page which looks crappy ...

Martin Dougiamas added a comment - 11/Jan/08 12:29 PM
Hmmm been playing with this and

.inline-list li {
display: inline;
}

doesn't appear to even work ...


Martin Dougiamas added a comment - 14/Jan/08 09:57 AM
Nick, can you look into this today? The fix appears to be non-trivial.

Martin Dougiamas added a comment - 16/Jan/08 10:22 AM
Nick, can you at least confirm if you are able to work on this?

http://moodle.org/tag/index.php?id=6


Martin Dougiamas added a comment - 16/Jan/08 10:24 AM
Nick C, can you please look into this ASAP?

Martin Dougiamas added a comment - 16/Jan/08 10:27 AM
Sorry for the noise. I'll leave this closed and let Nick C work on it over at MDL-12941 instead.

Nicolas Martignoni added a comment - 16/Jan/08 05:43 PM
More noise: closing again :-D