|
Hi Francois,
are you going to perform this... or should I do it ? (no problem with any alternative) TIA and ciao After discussing this with MattC and Eloy, there is another problem that we need to watch out for:
So the simplest solution would be to rename the file to "timezone2.txt" and to keep the old file around for backwards compatibility. A better solution would be to use mod_rewrite to generate timezone.txt dynamically. With this solution, a version number could optionally be passed and a 6-character timezone file would be returned for the new Moodle versions. We could keep truncating the olson data to 5 characters to provide some kind of support for older Moodle installs. And as Matt was saying: "if the timezone file on moodle.org was to be re-generated automatically from the latest olson DB file too it would save someone having to remember to updated it (or deal with bugs about it being out of date)" From Skype discussion, Eloy lists the next steps:
1) Move HEAD timezones.txt back to 17_STABLE timezones.txt (if are different right now). 2) Keep < 1.8 working against that file in download.moodle.org/timezones 3) Apply the patch to 18. 19 and HEAD, pointing to new URL 4) Make new URL to server HEAD timezones. 5) update HEAD timezones to new records (having 6cc entries) I'll try to implement this tomorrow if nobody has anything against it. Ciao
 First part done:
Now 18_STABLE, 19_STABLE and HEAD have varchar(6) in those timezone fields. Now the second part. What I've planned is: 1) Backport current HEAD timezones.txt to 16_STABLE and 17_STABLE (with these 2 points it's guaranteed that moodle versions < 1.8 will always use old varchar(5) olson files) 3) Create one new URL: http://download.moodle.org/timezones_info (with these 2 points, all moodle versions >= 1.8 will use the new varchar(6) olson files, so we'll be able to update them). An alternative to this separated URLs is to use a common one, but using some parameter. But I think it's clear to keep them separated. Any comment / idea... ? I'll wait a few days until receiving some feedback from MD. After all, those URLs are pointing to his servers, hehe. Ciao Yes, better to make a new location I think.
I would just suggest calling it /lib/timezone.txt and http://download.moodle.org/timezone/ binary downloads working again in 19dev...
Done. Now:
Moodle <= 17_STABLE is using the old "timezones" locations. Timezones information updated from ftp://elsie.nci.nih.gov/pub/ Closing...ciao |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Minor
New Olson timezone files require dst_time and std_time fields of size 6 instead of 5
 |
|
sorry by the delay!
Just looked patches and...err... uhm... the upgrade.php scripts aren't correct. They are using the old (deprecated) table_column() that isn't cross-db at all. Should use new ddl stuff exclusively, like the proposed by the XMLDB editor.
Ciao