[#MDL-12029] Glossary view needs heading markup + other accessibility fixes

Issue Details (XML | Word | Printable)

Key:	MDL-12029
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Nick Freear
Reporter:	Nick Freear
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-12298

Glossary view needs heading markup + other accessibility fixes

Created: 05/Nov/07 11:16 PM Updated: 16/Sep/08 11:49 AM

Return to search

Component/s:

Accessibility, Glossary

Affects Version/s:

1.8, 1.8.3, 1.9, 2.0

Fix Version/s:

1.9, 2.0

File Attachments:

patch-MDL-access-glossary-2.diff (9 kB)

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-16372~~ Glossary "Entry List" shows no entries

URL:	http://moodle.org/mod/glossary/view.php?id=851
Participants:	Martin Dougiamas, Nick Freear and Tim Hunt
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	20/Feb/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Accessibility/semantic problems include:
1. No heading markup for letter headings, A, B, C... or entry headings/terms ("activities", AFAIK, Ajax...) - easy to fix glossary_print_entry_concept function - doesn't affect glossary formats - continuous, encyclopedia, etc.
2. Individual tables for layout for each entry - tricky, affects glossary formats, leave for 1.9. Interim hack: replace some <td> with <th>.
3. Entries should be marked up as list items - relates to, layout tables.
4. Search form back to front - button on left, is inconsistent with other (search) forms in Moodle, and wider.
5. Comment and other 'commands' links same for each entry - need differentiation.
6. Alphabet and paging links should use list markup.
7. Skip alphabet and paging links.
8. Form <label> markup.
...

The attachment fixes 1, (2 hack) 5, 8 - it affects 4 mod/glossary files, plus theme/standard/styles_fonts.css

All

Comments

Change History

Version Control

Sort Order:

Nick Freear committed 5 files to 'Moodle CVS' - 06/Nov/07 12:22 AM

Fixes ~~MDL-12029~~ "Glossary view needs heading markup + other accessibility fixes".

MODIFY	mod/glossary/formats/encyclopedia/encyclopedia_format.php	Rev. 1.18	(+4 -4 lines)
MODIFY	mod/glossary/view.php	Rev. 1.130	(+6 -6 lines)
MODIFY	theme/standard/styles_fonts.css	Rev. 1.145	(+9 -2 lines)
MODIFY	mod/glossary/formats/faq/faq_format.php	Rev. 1.13	(+4 -4 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.194	(+9 -7 lines)

Nick Freear committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 06/Nov/07 12:24 AM

Fixes ~~MDL-12029~~ "Glossary view needs heading markup + other accessibility fixes". Merged.

MODIFY	mod/glossary/formats/faq/faq_format.php	Rev. 1.12.4.1	(+4 -4 lines)
MODIFY	mod/glossary/formats/encyclopedia/encyclopedia_format.php	Rev. 1.17.4.1	(+4 -4 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.193.2.1	(+9 -7 lines)
MODIFY	theme/standard/styles_fonts.css	Rev. 1.140.2.5	(+9 -2 lines)
MODIFY	mod/glossary/view.php	Rev. 1.128.2.2	(+6 -6 lines)

Nick Freear committed 11 files to 'Moodle CVS' - 08/Nov/07 02:45 AM

Follow up fixes ~~MDL-12029~~ "Glossary view needs heading markup..."

MODIFY	mod/glossary/formats/continuous/continuous_format.php	Rev. 1.11	(+3 -3 lines)
MODIFY	theme/standard/styles_fonts.css	Rev. 1.146	(+6 -3 lines)
MODIFY	mod/glossary/formats/fullwithauthor/fullwithauthor_format.php	Rev. 1.18	(+6 -5 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.195	(+5 -2 lines)
MODIFY	mod/glossary/formats/TEMPLATE/TEMPLATE_format.php	Rev. 1.10	(+5 -4 lines)
MODIFY	mod/glossary/formats/encyclopedia/encyclopedia_format.php	Rev. 1.19	(+3 -3 lines)
MODIFY	mod/glossary/formats/dictionary/dictionary_format.php	Rev. 1.10	(+3 -3 lines)
MODIFY	mod/glossary/formats/entrylist/entrylist_format.php	Rev. 1.17	(+3 -3 lines)
MODIFY	mod/glossary/view.php	Rev. 1.131	(+3 -3 lines)
MODIFY	mod/glossary/formats/faq/faq_format.php	Rev. 1.14	(+3 -3 lines)
MODIFY	mod/glossary/formats/fullwithoutauthor/fullwithoutauthor_format.php	Rev. 1.15	(+5 -5 lines)

Nick Freear committed 11 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/Nov/07 11:35 PM

Follow up fixes ~~MDL-12029~~ "Glossary view needs heading markup..." Merged, 2 days late :(.

MODIFY	mod/glossary/formats/TEMPLATE/TEMPLATE_format.php	Rev. 1.9.4.1	(+5 -4 lines)
MODIFY	mod/glossary/formats/fullwithauthor/fullwithauthor_format.php	Rev. 1.17.4.1	(+6 -5 lines)
MODIFY	mod/glossary/formats/fullwithoutauthor/fullwithoutauthor_format.php	Rev. 1.14.20.1	(+5 -5 lines)
MODIFY	mod/glossary/formats/faq/faq_format.php	Rev. 1.12.4.2	(+3 -3 lines)
MODIFY	mod/glossary/formats/encyclopedia/encyclopedia_format.php	Rev. 1.17.4.2	(+3 -3 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.193.2.2	(+5 -2 lines)
MODIFY	theme/standard/styles_fonts.css	Rev. 1.140.2.6	(+6 -3 lines)
MODIFY	mod/glossary/formats/continuous/continuous_format.php	Rev. 1.10.22.1	(+3 -3 lines)
MODIFY	mod/glossary/formats/dictionary/dictionary_format.php	Rev. 1.9.22.1	(+3 -3 lines)
MODIFY	mod/glossary/view.php	Rev. 1.128.2.3	(+3 -3 lines)
MODIFY	mod/glossary/formats/entrylist/entrylist_format.php	Rev. 1.16.4.1	(+3 -3 lines)

Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/Sep/08 07:04 AM

Fix regression introduced by ~~MDL-12029~~. Concepts must not be linked by filters. ~~MDL-16372~~

MODIFY

mod/glossary/lib.php

Rev. 1.193.2.17

(+1 -1 lines)

Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 09/Sep/08 07:06 AM

Fix regression introduced by ~~MDL-12029~~. Concepts must not be linked by filters. ~~MDL-16372~~ ; merged from 19_STABLE

MODIFY

mod/glossary/lib.php

Rev. 1.232

(+2 -2 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.