Issue Details (XML | Word | Printable)

Key: MDL-12031
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Martin Dougiamas
Reporter: Michael Spall
Votes: 2
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

After switch from daylight savings to standard time, course>partcipants>activity reports>all logs: graph of hits on course by user shows two Sundays and log entries are shown under wrong day.

Created: 06/Nov/07 02:49 AM   Updated: 16/Feb/08 02:10 PM
Return to search
Component/s: Administration, Other
Affects Version/s: 1.6.5, 1.8.3, 1.9
Fix Version/s: None

Issue Links:
Relates
 

Participants: Joseph Rézeau, Martin Dougiamas, Michael Spall and Petr Skoda
Security Level: None
Affected Branches: MOODLE_16_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
After switch from daylight savings to standard time (in US, Sunday, 2007-11-04), course>partcipants>activity reports>all logs: graph of hits on course by user shows two Sundays and log entries are shown under wrong day.
See discussion here for images: http://moodle.org/mod/forum/discuss.php?d=83392
Note, to reproduce make sure the course start date in which you test is close to the current date to make sure you can see individual days but before the time change so you can see the double days.

This has effected Moodle sites:
  Moodle versions 1.6.5,1.8.3+(2007-11-01),1.9+(2007-11-01),
  OS Solaris 10 and Linux.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Michael Spall added a comment - 10/Nov/07 01:59 PM
If you switch the setting Administration>Location>Location settings>Default timezone(timezone) from "Server's local time" to any other setting the graph appears correctly.

Michael Spall added a comment - 10/Nov/07 03:42 PM
Correction:
If you switch the setting Administration>Location>Location settings>Default timezone(timezone) from "Server's local time" or a setting that uses daylight savings time to a setting that doesn't use daylight savings time, e.g, MST or -7 the graph appears correctly.

Joseph Rézeau added a comment - 11/Nov/07 09:15 PM
Michael,

Your suggested workaroung may indeed solve the current problem, but then it means that the "country timezones" time system is no longer available on the moodle site.

I think another, long-term solution should be found, which would allow the use of a country timezone which has a daylight savings time system (such as most European countries) AND does not mess up dates in the logs graph...
Joseph


Michael Spall added a comment - 12/Nov/07 11:06 PM
It also has the problem of showing incorrect times for historical data during the daylight savings periods.

Martin Dougiamas added a comment - 13/Nov/07 02:00 PM
Is this a regression? I'm almost certain this used to work correctly ...

Petr Skoda made changes - 04/Jan/08 12:50 AM
Field Original Value New Value
Affects Version/s 1.9.2 [ 10241 ]
Affects Version/s 1.9 [ 10190 ]
Affects Version/s 1.9.1 [ 10240 ]
Michael Spall made changes - 16/Feb/08 08:06 AM
Link This issue has been marked as being related by MDL-13457 [ MDL-13457 ]
Petr Skoda added a comment - 16/Feb/08 08:53 AM
I doubt it is a regression, I think it depends on version of PHP and combination of timezone/DST.

Michael Spall added a comment - 16/Feb/08 02:10 PM
The PHP versions for our Moodle sites were 5.2.0 and 5.2.4 at the time the issue was filed. The sites with PHP 5.2.4 were updated to PHP 5.2.5 and the issue was still present.

I have wondered whether the issue is incorrect values in mdl_timezone, specifically in the dst_time and std_time fields.