Issue Details (XML | Word | Printable)

Key: MDL-12037
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Marsden
Reporter: Sam Marshall
Votes: 4
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Backup system ignores errors - we'd like it to report them

Created: 06/Nov/07 08:04 PM   Updated: 04/Mar/09 11:41 AM
Return to search
Component/s: Backup
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File backup_log_patch.txt (23 kB)
2. Text File backup_log_table.patch (7 kB)
3. Text File backup_log_table.patch (7 kB)
4. Text File error.patch (24 kB)

Issue Links:
Dependency
 
Duplicate
 

Participants: Colin Chambers, Dan Marsden, Eloy Lafuente (stronk7) and Sam Marshall
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 03/Mar/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Currently the backup system tends to ignore errors return values. It calls lots of functions, which may return false, but does not always take action as a result of the return value.

For 2.0 HEAD, we would like to change it as follows:

1) When any function called during backup returns false, an error should be printed at that point. The error should make clear which activity or part of the data caused the error, so that [for example] the user could retry the backup without that activity.

2) The system should continue with the backup as at present, but track whether an error occurred. At the end of a backup a clear message should display ('Backup completed succesfully' or 'Backup completed with errors').

3) Depending on a config option, admins can set up the system so that when a backup has errors, it is aborted. (The abort would happen either at the point where the error occurs, or at the final stage, to be determined. But either way it wouldn't make the zip file.) This would be an option because sometimes there are backup problems that are not fatal and, for sites that don't have a development team, a partial backup is better than none.

4) This config option should be configurable in the admin pages in the same place as any existing backup-related options.

5) Moodle has a system for running scheduled backups. When a scheduled backup is running, this should always be continued (not aborted) even if errors occur, regardless of the config option.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Marsden made changes - 13/May/08 07:34 AM
Field Original Value New Value
Link This issue is duplicated by MDL-14809 [ MDL-14809 ]
Dan Marsden made changes - 13/May/08 08:40 AM
Assignee Sam Marshall [ quen ] Dan Marsden [ danmarsden ]
Dan Marsden made changes - 14/May/08 09:23 AM
Attachment backup_log_patch.txt [ 13977 ]
Dan Marsden made changes - 10/Jun/08 10:49 AM
Attachment error.patch [ 14188 ]
Dan Marsden made changes - 03/Mar/09 07:33 AM
Attachment backup_log_table.patch [ 16434 ]
Dan Marsden made changes - 03/Mar/09 07:45 AM
Attachment backup_log_table.patch [ 16435 ]
Dan Marsden made changes - 03/Mar/09 09:57 AM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.0 [ 10122 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) made changes - 04/Mar/09 08:43 AM
QA Assignee stronk7
Status Resolved [ 5 ] Closed [ 6 ]
Dan Marsden made changes - 04/Mar/09 11:41 AM
Link This issue will help resolve MDL-9344 [ MDL-9344 ]