Moodle

Tidy up/consistency for Events Key block

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9, 2.0
  • Component/s: Calendar
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Remove the word events from the course, group and user events keys so they match the global event key. The word events is not necessary for each event as they are all in the events key block. Add titles to images in events key block as for displayed event type so a more useful and consistent tip is displayed for both hide/show images and their associated event types. (Ideally the images and event types displayed should be a single entity in the future)

Attachments

  1. Text File
    mdl-12069patch.txt
    08/Nov/07 10:04 PM
    8 kB
    Derek Woolhead
  2. Text File
    mdl-12072.patch
    08/Nov/07 11:26 PM
    2 kB
    Derek Woolhead
  1. after.png
    11 kB
    08/Nov/07 9:52 PM
  2. before.png
    11 kB
    08/Nov/07 9:52 PM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Derek Woolhead added a comment -

patch file

Show
Derek Woolhead added a comment - patch file
Hide
Permalink
Sam Marshall added a comment -

To clarify:

1) The 4 buttons used to vary i.e. some had 'Events' and some didn't. This one removes the word 'Events' from all of them, reducing visual clutter. Since the text above says 'Events Key' it should be entirely clear.

2) The title popup on the 'eye' icon ('Hide') was different from the one on the link next to it ('Hide course events'), even though they do the same thing. This makes them both do the same ('Hide course events').

Show
Sam Marshall added a comment - To clarify: 1) The 4 buttons used to vary i.e. some had 'Events' and some didn't. This one removes the word 'Events' from all of them, reducing visual clutter. Since the text above says 'Events Key' it should be entirely clear. 2) The title popup on the 'eye' icon ('Hide') was different from the one on the link next to it ('Hide course events'), even though they do the same thing. This makes them both do the same ('Hide course events').
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

+1

Show
Eloy Lafuente (stronk7) added a comment - +1
Hide
Permalink
Sam Marshall added a comment -

Thanks Eloy. I have committed this change to 1.9 and HEAD, and marked merged.

Show
Sam Marshall added a comment - Thanks Eloy. I have committed this change to 1.9 and HEAD, and marked merged.
Hide
Permalink
Nicolas Martignoni added a comment -

Verified, closing

Show
Nicolas Martignoni added a comment - Verified, closing

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.