Moodle

Inconsistencies between blocks on calendar page compared to other pages such as the main course page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9, 2.0
  • Component/s: Calendar
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The formatting of the 'Events Key' and 'Monthly View' block headings is inconsistent with other pages, such as the course main page for example. This causes issues when changing themes. Change is to include <h2> tag for block headers as for other pages (and modify styles layout to ensure heading is left justified for the side blocks)

  1. mdl-12072.patch
    08/Nov/07 11:27 PM
    2 kB
    Derek Woolhead
  1. after.png
    11 kB
    08/Nov/07 11:24 PM
  2. before.png
    11 kB
    08/Nov/07 11:24 PM

Activity

Hide
Sam Marshall added a comment -

To clarify:

1) The point is to make them more consistent with course page blocks. We have not attempted to make them identical, just added the missing heading tag.

2) There is no change in appearance [standard theme] except for a very slight alteration in font size as a consequence of the change. This makes the headings the same size as on front page.

3) Marking up headings properly is good for accessibility.

Show
Sam Marshall added a comment - To clarify: 1) The point is to make them more consistent with course page blocks. We have not attempted to make them identical, just added the missing heading tag. 2) There is no change in appearance [standard theme] except for a very slight alteration in font size as a consequence of the change. This makes the headings the same size as on front page. 3) Marking up headings properly is good for accessibility.
Hide
Petr Škoda (skodak) added a comment -

+1

Show
Petr Škoda (skodak) added a comment - +1
Hide
Sam Marshall added a comment -

Thanks. Committed to 1.9 and HEAD and marked merged.

Show
Sam Marshall added a comment - Thanks. Committed to 1.9 and HEAD and marked merged.
Hide
Nicolas Martignoni added a comment -

Verified, closing.

Show
Nicolas Martignoni added a comment - Verified, closing.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: