Moodle

glossary module support for myMoodle print_overview function

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.8.3
  • Fix Version/s: STABLE backlog
  • Component/s: Glossary
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

I'd like to see user contributed glossary entries appear on myMoodle. Attached is a patch which I think works, but I'd love some-one to look it over.

It needs 2 lang strings as well for "entry since last login" and "entries since last login".

Attachments

  1. File
    function.php
    14/Apr/08 10:01 PM
    4 kB
    Jenny Gray
  2. Text File
    glossary_lib_patch.txt
    01/Feb/08 7:41 PM
    4 kB
    Gareth Morgan
  3. Text File
    lang_glossary_patch.txt
    01/Feb/08 7:41 PM
    0.8 kB
    Gareth Morgan

Issue Links

This issue has been marked as being related by:
MDL-13583 Improvements to the MyMoodle page Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gareth Morgan added a comment -

I've attached the patches for the mod/glossary/lib.php file and the language pack (I put the language strings in lang/en_utf8/glossary.php). Hope that this helps.

Show
Gareth Morgan added a comment - I've attached the patches for the mod/glossary/lib.php file and the language pack (I put the language strings in lang/en_utf8/glossary.php). Hope that this helps.
Hide
Permalink
Ray Lawrence added a comment -

Jenny, what's the behaviour with new entries in a "Main" glossary that have been exported from a secondary glossary and imported entries? Do they show up as new entries too?

Show
Ray Lawrence added a comment - Jenny, what's the behaviour with new entries in a "Main" glossary that have been exported from a secondary glossary and imported entries? Do they show up as new entries too?
Hide
Permalink
Jenny Gray added a comment -

It works in the same way as the hook into the recent_activity block. Basically it scans the mdl_log table for 'add entry' and 'update entry' rows for the glossary module.

So i guess it depends on how import/export entries are logged - I'm not familiar with that bit of code.

Show
Jenny Gray added a comment - It works in the same way as the hook into the recent_activity block. Basically it scans the mdl_log table for 'add entry' and 'update entry' rows for the glossary module. So i guess it depends on how import/export entries are logged - I'm not familiar with that bit of code.
Hide
Permalink
Petr Škoda (skodak) added a comment -

the recent activity handling on course page was rewritten recently, this will have to be done on mymoodle page too - expect better performance and bugfixes

Show
Petr Škoda (skodak) added a comment - the recent activity handling on course page was rewritten recently, this will have to be done on mymoodle page too - expect better performance and bugfixes
Hide
Permalink
Ray Lawrence added a comment -

Thanks. Nor me I'll keep watching this....

Show
Ray Lawrence added a comment - Thanks. Nor me I'll keep watching this....
Hide
Permalink
Jenny Gray added a comment -

I've updated the glossary_print_overview function to pick up the newer way from glossary_print_recent_activity of identifying updates (basically anything in glossary_entries with a timemodified more recent than the user's last course access).

I'd be grateful if some-one could review the attachment and let me know if its ready to commit now?

Show
Jenny Gray added a comment - I've updated the glossary_print_overview function to pick up the newer way from glossary_print_recent_activity of identifying updates (basically anything in glossary_entries with a timemodified more recent than the user's last course access). I'd be grateful if some-one could review the attachment and let me know if its ready to commit now?

People

Vote (1)
Watch (4)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.