To clarify: look at the 'Before' screenshot to see what was wrong. It was OK when there was only a single event in a day but works really badly when there are two different types in one day. One type (at random or maybe the highest level) gets chosen for the colour for the day, and some of the other events are coloured on top of that in 'their' colour while others aren't... it's a mess.
This patch makes colouring apply to the events within a day only and not to the day as a whole. Now colouring within the main monthly view is 100% consistent in all cases, making it clearer (for example) what will be shown/hidden when the user clicks those options.
The patch does not address the related issue in the mini-calendar where obviously we cannot take the same approach as using the current technique it is only possible to use one colour for each day. I suppose ideally you'd have some kind of striped bitmap in the background there, but perhaps that can be left for improvement at a later date.
Bug
Closed
Trivial
To clarify: look at the 'Before' screenshot to see what was wrong. It was OK when there was only a single event in a day but works really badly when there are two different types in one day. One type (at random or maybe the highest level) gets chosen for the colour for the day, and some of the other events are coloured on top of that in 'their' colour while others aren't... it's a mess.
This patch makes colouring apply to the events within a day only and not to the day as a whole. Now colouring within the main monthly view is 100% consistent in all cases, making it clearer (for example) what will be shown/hidden when the user clicks those options.
The patch does not address the related issue in the mini-calendar where obviously we cannot take the same approach as using the current technique it is only possible to use one colour for each day. I suppose ideally you'd have some kind of striped bitmap in the background there, but perhaps that can be left for improvement at a later date.