[#MDL-12101] bulk user operations cleanup/fixes

Moodle

bulk user operations cleanup/fixes

Created: 12/Nov/07 04:56 AM Updated: 27/Dec/07 06:48 PM

Component/s:

Administration

Affects Version/s:

1.9

Fix Version/s:

1.9

File Attachments:

big_bulk1.patch (136 kb)

Issue Links:

Dependency

This issue will help resolve:

MDL-11424 mform1 form has no properties in moodle19/admin/user/user_bulk.php

~~MDL-11755~~ hard coded lang strings in user_bulk.php

Relates

This issue has been marked as being related by:

~~MDL-10464~~ Allow administrators dowloading all users to a file

~~MDL-3982~~ Searching by username

Participants:	Petr Škoda
Security Level:	None

Description

« Hide

There are several problems:
1/ unitialized arrays - XSS
2/ bad sql syntax - wrong quotes used in filters
3/ incorrect use of formslib - not nice at all, very fragile and hackish
4/ user filters ORed, should be ANDed - we can simulate OR by select all + clearing the filters, we can not do AND filters now
5/ localization unfinished and problematic
6/ hardcoded guest user id
7/ some more...

Solution:
* split the forms
* move the data processing logic from forms
* general cleanup

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Petr Škoda - 13/Nov/07 05:45 AM

sending fresh patch - should be ready for commit :-)

[ Permlink | « Hide ]

Petr Škoda - 13/Nov/07 05:09 PM

fixed in cvs