Issue Details (XML | Word | Printable)

Key: MDL-12101
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

bulk user operations cleanup/fixes

Created: 12/Nov/07 04:56 AM   Updated: 27/Dec/07 06:48 PM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 1.9

File Attachments: 1. Text File big_bulk1.patch (136 kB)
Issue Links:
Dependency
 
Relates
 

Participants: Petr Skoda
Security Level: None
Resolved date: 13/Nov/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
There are several problems:
1/ unitialized arrays - XSS
2/ bad sql syntax - wrong quotes used in filters
3/ incorrect use of formslib - not nice at all, very fragile and hackish
4/ user filters ORed, should be ANDed - we can simulate OR by select all + clearing the filters, we can not do AND filters now
5/ localization unfinished and problematic
6/ hardcoded guest user id
7/ some more...

Solution:
* split the forms
* move the data processing logic from forms
* general cleanup

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 12/Nov/07 04:58 AM
Field Original Value New Value
Link This issue will help resolve MDL-11755 [ MDL-11755 ]
Petr Skoda made changes - 12/Nov/07 04:59 AM
Link This issue will help resolve MDL-11424 [ MDL-11424 ]
Petr Skoda made changes - 12/Nov/07 05:00 AM
Summary bulk user operation cleanup/fixes bulk user operations cleanup/fixes
[ Permalink | « Hide ]
Petr Skoda added a comment - 13/Nov/07 05:45 AM
sending fresh patch - should be ready for commit

Petr Skoda made changes - 13/Nov/07 05:45 AM
Attachment big_bulk1.patch [ 12350 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 13/Nov/07 05:09 PM
fixed in cvs

Petr Skoda made changes - 13/Nov/07 05:09 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 32 files to 'Moodle CVS' - 13/Nov/07 05:43 PM
MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
MODIFY lang/en_utf8/filters.php   Rev. 1.4    (+30 -21 lines)
MODIFY user/filters/select.php   Rev. 1.3    (+76 -54 lines)
ADD user/filters/user_filter_forms.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/filters/lib.php   Rev. 1.2    (+210 -31 lines)
MODIFY admin/user.php   Rev. 1.110    (+18 -134 lines)
MODIFY admin/user/user_message_form.php   Rev. 1.3    (+6 -19 lines)
MODIFY user/filters/yesno.php   Rev. 1.2    (+7 -8 lines)
DEL lang/en_utf8/help/filters/Attic/radios.html   Rev. 1.2    (+0 -0 lines)
ADD admin/user/lib.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/filters/courserole.php   Rev. 1.2    (+93 -76 lines)
ADD lang/en_utf8/help/filters/simpleselect.html   Rev. 1.1    (+0 -0 lines)
MODIFY lib/datalib.php   Rev. 1.442    (+10 -4 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.149    (+2 -1 lines)
MODIFY lang/en_utf8/bulkusers.php   Rev. 1.7    (+13 -7 lines)
ADD admin/user/user_bulk_forms.php   Rev. 1.1    (+0 -0 lines)
MODIFY user/filters/globalrole.php   Rev. 1.2    (+49 -34 lines)
DEL user/filters/Attic/user_filter_form.php   Rev. 1.2    (+0 -0 lines)
MODIFY user/filters/profilefield.php   Rev. 1.3    (+116 -124 lines)
MODIFY admin/user/user_bulk_delete.php   Rev. 1.4    (+31 -30 lines)
MODIFY admin/user/user_bulk_display.php   Rev. 1.2    (+73 -68 lines)
MODIFY admin/user/user_bulk_confirm.php   Rev. 1.4    (+33 -31 lines)
DEL user/filters/Attic/radios.php   Rev. 1.3    (+0 -0 lines)
MODIFY lang/en_utf8/help/bulkusers/selectedlist.html   Rev. 1.4    (+5 -4 lines)
MODIFY lang/en_utf8/help/filters/date.html   Rev. 1.3    (+1 -1 lines)
MODIFY user/filters/text.php   Rev. 1.2    (+92 -90 lines)
MODIFY lang/en_utf8/help/filters/courserole.html   Rev. 1.2    (+3 -2 lines)
ADD user/filters/simpleselect.php   Rev. 1.1    (+0 -0 lines)
DEL admin/user/Attic/user_bulk_form.php   Rev. 1.8    (+0 -0 lines)
MODIFY user/filters/date.php   Rev. 1.2    (+90 -69 lines)
MODIFY admin/user/user_bulk.php   Rev. 1.6    (+79 -77 lines)
MODIFY admin/user/user_bulk_message.php   Rev. 1.3    (+56 -33 lines)
MODIFY admin/uploaduser.php   Rev. 1.74    (+6 -6 lines)
Petr Skoda committed 32 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 13/Nov/07 06:02 PM
MFC: MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
MODIFY admin/user/user_bulk.php   Rev. 1.4.2.2    (+79 -77 lines)
MODIFY user/filters/profilefield.php   Rev. 1.2.2.1    (+116 -124 lines)
MODIFY user/filters/user_filter_forms.php   Rev. 1.1.2.2    (+69 -0 lines)
MODIFY admin/uploaduser.php   Rev. 1.68.2.6    (+6 -6 lines)
MODIFY lang/en_utf8/help/filters/date.html   Rev. 1.2.2.1    (+1 -1 lines)
MODIFY admin/user/user_bulk_message.php   Rev. 1.2.2.1    (+56 -33 lines)
MODIFY admin/user.php   Rev. 1.109.2.1    (+18 -134 lines)
MODIFY lang/en_utf8/help/bulkusers/selectedlist.html   Rev. 1.2.2.2    (+5 -4 lines)
MODIFY user/filters/text.php   Rev. 1.1.2.1    (+92 -90 lines)
MODIFY lib/datalib.php   Rev. 1.439.2.3    (+10 -4 lines)
MODIFY lang/en_utf8/help/filters/courserole.html   Rev. 1.1.2.1    (+3 -2 lines)
DEL user/filters/Attic/radios.php   Rev. 1.2.2.1    (+0 -0 lines)
DEL lang/en_utf8/help/filters/Attic/radios.html   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY user/filters/yesno.php   Rev. 1.1.2.1    (+7 -8 lines)
MODIFY admin/user/lib.php   Rev. 1.1.2.2    (+53 -0 lines)
DEL admin/user/Attic/user_bulk_form.php   Rev. 1.6.2.2    (+0 -0 lines)
MODIFY user/filters/courserole.php   Rev. 1.1.2.1    (+93 -76 lines)
MODIFY admin/user/user_message_form.php   Rev. 1.2.2.1    (+6 -19 lines)
MODIFY admin/user/user_bulk_delete.php   Rev. 1.3.2.1    (+31 -30 lines)
MODIFY admin/user/user_bulk_forms.php   Rev. 1.1.2.2    (+106 -0 lines)
MODIFY lang/en_utf8/bulkusers.php   Rev. 1.5.2.2    (+13 -7 lines)
MODIFY user/filters/globalrole.php   Rev. 1.1.2.1    (+49 -34 lines)
MODIFY lang/en_utf8/help/filters/simpleselect.html   Rev. 1.1.2.2    (+2 -0 lines)
MODIFY user/filters/date.php   Rev. 1.1.2.1    (+90 -69 lines)
MODIFY user/filters/lib.php   Rev. 1.1.2.1    (+210 -31 lines)
DEL user/filters/Attic/user_filter_form.php   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY admin/user/user_bulk_confirm.php   Rev. 1.3.2.1    (+33 -31 lines)
MODIFY user/filters/select.php   Rev. 1.2.2.1    (+76 -54 lines)
MODIFY user/filters/simpleselect.php   Rev. 1.1.2.2    (+88 -0 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.141.2.7    (+2 -1 lines)
MODIFY lang/en_utf8/filters.php   Rev. 1.3.2.1    (+30 -21 lines)
MODIFY admin/user/user_bulk_display.php   Rev. 1.1.2.1    (+73 -68 lines)
martignoni committed 4 files to 'Lang CVS' - 13/Nov/07 11:13 PM
MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
MODIFY fr_utf8/help/filters/courserole.html   Rev. 1.3    (+2 -2 lines)
ADD fr_utf8/help/filters/simpleselect.html   Rev. 1.1    (+0 -0 lines)
DEL fr_utf8/help/filters/Attic/radios.html   Rev. 1.3    (+0 -0 lines)
MODIFY fr_utf8/help/filters/date.html   Rev. 1.2    (+2 -2 lines)
martignoni committed 3 files to 'Lang CVS' - 14/Nov/07 12:39 AM
MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
MODIFY fr_utf8/filters.php   Rev. 1.8    (+16 -6 lines)
MODIFY fr_utf8/bulkusers.php   Rev. 1.8    (+11 -3 lines)
MODIFY fr_utf8/moodle.php   Rev. 1.180    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 14/Nov/07 02:42 AM
MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
MODIFY fr_utf8/help/bulkusers/selectedlist.html   Rev. 1.4    (+4 -4 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 14/Nov/07 09:58 AM
Translated a new string for user bulk operation and admin user browsing MDL-12101.
Translated a new string for grade MDL-10901 MDL-12154.
Updated translated strings for grade MDL-12145 based on lang/en_utf8 fix.
MODIFY ja_utf8/grades.php   Rev. 1.103    (+3 -2 lines)
MODIFY ja_utf8/README   Rev. 1.567    (+1 -1 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.253    (+2 -1 lines)
MODIFY ja_utf8/bulkusers.php   Rev. 1.7    (+13 -7 lines)
MODIFY ja_utf8/filters.php   Rev. 1.3    (+15 -4 lines)
Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 14/Nov/07 10:13 AM
Updated a translated help file for user bulk operation based on lang/en_utf8 fix MDL-12101.
MODIFY ja_utf8/help/bulkusers/selectedlist.html   Rev. 1.4    (+4 -4 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 14/Nov/07 11:11 AM
Updated translated help files for bulk user operation based on lang/en_utf8 cleanup/fixing/refactoring MDL-12101.
Removed a translated hlep file for bulk user operation based on lang/en_utf8 removal.
DEL ja_utf8/help/filters/Attic/radios.html   Rev. 1.4    (+0 -0 lines)
MODIFY ja_utf8/help/filters/date.html   Rev. 1.2    (+1 -1 lines)
ADD ja_utf8/help/filters/simpleselect.html   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/help/filters/courserole.html   Rev. 1.4    (+1 -1 lines)
Petr Skoda made changes - 20/Dec/07 07:55 PM
Link This issue has been marked as being related by MDL-10464 [ MDL-10464 ]
Petr Skoda made changes - 27/Dec/07 06:48 PM
Link This issue has been marked as being related by MDL-3982 [ MDL-3982 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators