Moodle

Print students name on right side of grader report

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9
  • Fix Version/s: None
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

It is very difficult to visually track activities for students in the grader report in Moodle 1.9 Beta 2 once more than a few activities are completed. Restoring the printing of the student's name on the right hand side helps here, especially since it is next to the Course total.

To patch in /grade/report/grader/lib.php, right above $headerhtml .= '</tr>'; add

if ($key == $numrows - 1) { $headerhtml .= '<th class="header c'.$columncount++.' user" scope="col"><a href="'.$this->baseurl.'&sortitemid=firstname">' . $strfirstname . '</a> ' //TODO: localize . $firstarrow. '/ <a href="'.$this->baseurl.'&sortitemid=lastname">' . $strlastname . '</a>'. $lastarrow .'</th>'; }

in /grade/report/grader/lib.php, right above $studentshtml .= '</tr>'; add

$studentshtml .= '<th class="header c'.$columncount++.' user" scope="row">' . $user_pic
. '<a href="' . $CFG->wwwroot . '/user/view.php?id='
. $user->id . '">' . fullname($user) . '</a></th>';

The above lines are courtesy of our school, Seattle Academy and were written by Karlene Clapp, our administrator of our servers.

Issue Links

This issue has a non-specific relationship to:
MDL-13950 Floating Names and Assignment Headers Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gary Anderson added a comment -

After the patch with student names printed on right hand side. Note that another patch that resizes picures and preserves word wrap has been applied.

Show
Gary Anderson added a comment - After the patch with student names printed on right hand side. Note that another patch that resizes picures and preserves word wrap has been applied.
Hide
Permalink
Martin Dougiamas added a comment -

There's two things that might make this patch unnecessary ...

1) The course totals can be on the left if you want
2) Yu has implemented row highlighting (click on a student name and the row gets highlighted) and column highlighting is coming very shortly ... this should help people keep track of their location.

Show
Martin Dougiamas added a comment - There's two things that might make this patch unnecessary ... 1) The course totals can be on the left if you want 2) Yu has implemented row highlighting (click on a student name and the row gets highlighted) and column highlighting is coming very shortly ... this should help people keep track of their location.
Hide
Permalink
Martin Dougiamas added a comment -

The highlighing is in CVS if you want to try it .... you click on the headers to the left and the top

Show
Martin Dougiamas added a comment - The highlighing is in CVS if you want to try it .... you click on the headers to the left and the top
Hide
Permalink
Gary Anderson added a comment -

I would consider this optional, but we still offer it to core since we have made the decision to keep it in our school's code even after the click hilighting was added because we find it outweighs the cost. Closeable tabs also help. As does our patch on not using wrap that was added to styles.php

We have also added even/odd row styles that we alternate from gray white to our code, but have not added it to the tracker since the click hilight helps. We still think that at least the style class should be added to alternate rows and will post it if requested.

High schools like ours can give an interesting perspective as we often break up class activities into smaller pieces that are each graded. So we can have 50 to 100 activities per student each term in a class. Hence the readability of these reports is quite important. It is also why fast and intuitive grading is so vital.

Still, feel free to close this. I would put some of my other gradebook items far higher in order of importance.

Show
Gary Anderson added a comment - I would consider this optional, but we still offer it to core since we have made the decision to keep it in our school's code even after the click hilighting was added because we find it outweighs the cost. Closeable tabs also help. As does our patch on not using wrap that was added to styles.php We have also added even/odd row styles that we alternate from gray white to our code, but have not added it to the tracker since the click hilight helps. We still think that at least the style class should be added to alternate rows and will post it if requested. High schools like ours can give an interesting perspective as we often break up class activities into smaller pieces that are each graded. So we can have 50 to 100 activities per student each term in a class. Hence the readability of these reports is quite important. It is also why fast and intuitive grading is so vital. Still, feel free to close this. I would put some of my other gradebook items far higher in order of importance.
Hide
Permalink
Gary Anderson added a comment -

One more thought: a possible idea would be to put in the right hand names, but to put style information in each the right and left hand name columns. Then these can be hidden by the style sheet or even the code and adjusted to meet the needs of the environment.

But, again, there are more important usability issues that should should probably given attention first.

Show
Gary Anderson added a comment - One more thought: a possible idea would be to put in the right hand names, but to put style information in each the right and left hand name columns. Then these can be hidden by the style sheet or even the code and adjusted to meet the needs of the environment. But, again, there are more important usability issues that should should probably given attention first.
Hide
Permalink
Gary Anderson added a comment -

Here is a modified patch that has class information to control visibility of the right hand column of student names.

styles.php can have the line if displaying the right hand column is not desired:

.rightcol {
display:none;
}

The first insertion above would now be:

if ($key == $numrows - 1) { $headerhtml .= '<th class="header c'.$columncount++.' user rightcol" scope="col"><a href="'.$this->baseurl.'&sortitemid=firstname">' . $strfirstname . '</a> ' . $firstarrow. '/ <a href="'.$this->baseurl.'&sortitemid=lastname">' . $strlastname . '</a>'. $lastarrow .'</th>'; }

The second insertion

$studentshtml .= '<th class="header c'.$columncount++.' user rightcol" scope="row">' . $user_pic
. '<a href="' . $CFG->wwwroot . '/user/view.php?id='
. $user->id . '">' . fullname($user) . '</a></th>';

Show
Gary Anderson added a comment - Here is a modified patch that has class information to control visibility of the right hand column of student names. styles.php can have the line if displaying the right hand column is not desired: .rightcol { display:none; } The first insertion above would now be: if ($key == $numrows - 1) { $headerhtml .= '<th class="header c'.$columncount++.' user rightcol" scope="col"><a href="'.$this->baseurl.'&sortitemid=firstname">' . $strfirstname . '</a> ' . $firstarrow. '/ <a href="'.$this->baseurl.'&sortitemid=lastname">' . $strlastname . '</a>'. $lastarrow .'</th>'; } The second insertion $studentshtml .= '<th class="header c'.$columncount++.' user rightcol" scope="row">' . $user_pic . '<a href="' . $CFG->wwwroot . '/user/view.php?id=' . $user->id . '">' . fullname($user) . '</a></th>';
Hide
Permalink
Matt Gibson added a comment -

That highlighting is exactly what I had in mind. With the CSS changes too, its a dream to use. Nice work!

+1 for getting the names on both sides. It doubles the visible area of the gradebook where I don't need to scroll to see names.

Show
Matt Gibson added a comment - That highlighting is exactly what I had in mind. With the CSS changes too, its a dream to use. Nice work! +1 for getting the names on both sides. It doubles the visible area of the gradebook where I don't need to scroll to see names.
Hide
Permalink
Martin Dougiamas added a comment -

I wonder if making the student names floatable using YUI isn't a better solution. Deferring...

Show
Martin Dougiamas added a comment - I wonder if making the student names floatable using YUI isn't a better solution. Deferring...
Hide
Permalink
David Fountain added a comment -

I have courses with many grade points and students who can ask me to mark any of them at any time often with 30 students getting through 3 or 4 points in a 40 minute session. Bouncing around the gradebook is timeconsuming and though the highlighting is a brilliant addition the idea of floating names 'and' column headings similar to the frozen panes as in spreadsheets would be a fantastic addition! Failing this the ability to have a setting that allowed to specify a repeated name column every x columns etc and rows the same would be good.

Show
David Fountain added a comment - I have courses with many grade points and students who can ask me to mark any of them at any time often with 30 students getting through 3 or 4 points in a 40 minute session. Bouncing around the gradebook is timeconsuming and though the highlighting is a brilliant addition the idea of floating names 'and' column headings similar to the frozen panes as in spreadsheets would be a fantastic addition! Failing this the ability to have a setting that allowed to specify a repeated name column every x columns etc and rows the same would be good.
Hide
Permalink
Helen Foster added a comment -

Would the scroll grades while students stay fixed feature in LSU's simple grader report MDL-17807 solve this issue?

Show
Helen Foster added a comment - Would the scroll grades while students stay fixed feature in LSU's simple grader report MDL-17807 solve this issue?
Hide
Permalink
Helen Foster added a comment -

Attached screenshot of simple grader report from LSU. Gary and watchers, your comments would be appreciated.

Show
Helen Foster added a comment - Attached screenshot of simple grader report from LSU. Gary and watchers, your comments would be appreciated.
Hide
Permalink
Gina Russell Stevens added a comment -

Yes. The scrollable LSU grader report is a superior resolution. Let's do it.

Show
Gina Russell Stevens added a comment - Yes. The scrollable LSU grader report is a superior resolution. Let's do it.
Hide
Permalink
Gary Anderson added a comment -

I just tried the LSU implementation of this and I agree. Locking the names having the grades scroll is a very good solution.

Show
Gary Anderson added a comment - I just tried the LSU implementation of this and I agree. Locking the names having the grades scroll is a very good solution.
Hide
Permalink
Helen Foster added a comment -

Gina and Gary, thanks for your feedback

Resolving this issue as "Won't fix" since we'll go for the scroll grades while students stay fixed feature in LSU's simple grader report instead. It's listed as a stage 1 gradebook improvement: http://docs.moodle.org/en/Development:Gradebook_improvements

Show
Helen Foster added a comment - Gina and Gary, thanks for your feedback Resolving this issue as "Won't fix" since we'll go for the scroll grades while students stay fixed feature in LSU's simple grader report instead. It's listed as a stage 1 gradebook improvement: http://docs.moodle.org/en/Development:Gradebook_improvements

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.