[#MDL-12161] Slashes not stripped on SCORM tree list - Moodle Tracker

Issue Details (XML | Word | Printable)

Key:	MDL-12161
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Dan Marsden
Reporter:	Marco Loche
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Slashes not stripped on SCORM tree list

Created: 14/Nov/07 05:48 PM Updated: 11/Nov/08 10:36 AM

Component/s:

SCORM

Affects Version/s:

1.8.3

Fix Version/s:

1.9.3

File Attachments:

1.

lo.zip (12 kB)

Image Attachments:

1. SCORM-TREE.jpg
(33 kB)

Environment:

ALL

Database:	MySQL
Participants:	Dan Marsden, Marco Loche and Roberto Pinna
Security Level:	None
Resolved date:	15/Aug/08
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

If SCO title contains special characters (', ", ...) slashes are not stripped.
see SCORM-TREE.jpg

I popose a solution adding the following line

$sco->title = stripslashes($sco->title);

on

mod/scorm/datamodels/scorm_13lib.php line 66

and

mod/scorm/datamodels/scorm_12lib.php line 216

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permalink | « Hide ]

Roberto Pinna added a comment - 14/Nov/07 06:26 PM

Hi Marco,
can you attach a test package.

Grazie,
Roberto

[ Permalink | « Hide ]

Marco Loche added a comment - 15/Nov/07 01:24 AM - edited

Hi Roberto

The lo.zip file attached over is a SCORM 1.2 package with some special characters on title.

<title>SCO - Test special char - ' "</title>

Without the patch proposed the title on TOC looks like :

SCO - Test special char - \' \"

with the patch slashes are stripped

Prego

Marco

[ Permalink | « Hide ]

Dan Marsden added a comment - 15/Aug/08 07:12 AM

this was fixed as part of ~~MDL-8193~~

thanks,

Dan

All content on this web site is made available under the GNU General Public License, unless otherwise stated.