Moodle

Slashes not stripped on SCORM tree list

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.3
  • Fix Version/s: 1.9.3
  • Component/s: SCORM
  • Labels:
    None
  • Environment:
    ALL
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

If SCO title contains special characters (', ", ...) slashes are not stripped.
see SCORM-TREE.jpg

I popose a solution adding the following line

$sco->title = stripslashes($sco->title);

on

mod/scorm/datamodels/scorm_13lib.php line 66

and

mod/scorm/datamodels/scorm_12lib.php line 216

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roberto Pinna added a comment -

Hi Marco,
can you attach a test package.

Grazie,
Roberto

Show
Roberto Pinna added a comment - Hi Marco, can you attach a test package. Grazie, Roberto
Hide
Permalink
Marco Loche added a comment - - edited

Hi Roberto

The lo.zip file attached over is a SCORM 1.2 package with some special characters on title.

<title>SCO - Test special char - ' "</title>

Without the patch proposed the title on TOC looks like :

SCO - Test special char - \' \"

with the patch slashes are stripped

Prego

Marco

Show
Marco Loche added a comment - - edited Hi Roberto The lo.zip file attached over is a SCORM 1.2 package with some special characters on title. <title>SCO - Test special char - ' "</title> Without the patch proposed the title on TOC looks like : SCO - Test special char - \' \" with the patch slashes are stripped Prego Marco
Hide
Permalink
Dan Marsden added a comment -

this was fixed as part of MDL-8193

thanks,

Dan

Show
Dan Marsden added a comment - this was fixed as part of MDL-8193 thanks, Dan

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.