|
[
Permalink
| « Hide
]
Petr Kalis added a comment - 21/Nov/07 07:45 PM
See patch against 1.9 attached
Thanks for doing this.
I see a problem with this patch. In each of the if statements, you get a new $postsarr value. For example, If the value of $postsarr is set in the first if statment and you are calling it again in another if statment, the first values get removed. You need to be merging them so that you have all the values from all the if statements. The way it is now, only the values from the last if statement is retained. The rest gets lost. Hope l am making sense to you. Hi
You are making perfectly sense, still you are wrong, imho  .I am sending already selected posts with attachments to function forum_get_posts_with_attachments and in this function i am doing your mentioned merging return array_merge((array)$postsarr,$records); I think this way it is deleting all posts with attachments (only first post of single simple discussion stays, but this was earlier too, so i thought its feature ) from different forums. But i welcome any betatesters I see what you are doing.
You are doing the merge in the forum_get_posts_with_attachments function. I did not see that at first. That should work just fine. Thanks again. Thanks Yu for checking this in.
But i found another problem in resetting forums. It lefts discussions in the database (posts are deleted ok, discussions not, they are orphaned and left in the DB). I will check if there is a issue for this and try to solve it. I fixed that too in my patch, it should be ready for wider testing tomorrow (1.9/head only).
I just downloaded the 1.7.3 built of today (Wed Jan 9 2008). I did not see this fix in the tar file.
Which it be in? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Critical
Reset: Forum reset in the Course reset page
 |
|
