[#MDL-12212] Reimplement $PAGE for Navigation 2.0

Issue Details (XML | Word | Printable)

Key:	MDL-12212
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Tim Hunt
Reporter:	Martin Dougiamas
Votes:	2
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Reimplement $PAGE for Navigation 2.0

Created: 16/Nov/07 10:53 AM Updated: 31/Oct/09 07:56 AM

Return to search

Component/s:

Blocks, Lib

Affects Version/s:

1.9

Fix Version/s:

2.0

File Attachments:

patchseries.txt (459 kB)

Issue Links:

Dependency

This issue will help resolve:

~~MDL-4138~~ A Main Menu type block for courses

Participants:	Dan Poltawski, Martin Dougiamas and Tim Hunt
Security Level:	None
Resolved date:	06/May/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

Sub-Tasks:

All

Open

Sub-Task Progress:

No sub-tasks match this view.

Description

« Hide

The implementation of blocks is completely rotten, rife with inconsistencies and gaps.

This meta bug is to track the complete review and overhaul of blocks to make them something we can be proud of.

One objective is to not break compatibility for the blocks themselves - this is just about pagelib, really and making it work consistently and simply across all the pages in Moodle.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 04/Mar/08 01:10 PM

Just 2.0

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 29/Apr/08 02:21 PM

Most important thing on the new implementation is to base it around contexts instead of pageids

[ Permalink | « Hide ]

Dan Poltawski added a comment - 12/Jan/09 07:08 PM

Just so I remember to document this:

I was playing around trying to make a fancy block this weekend with YUI popups (much like the the repository picker). (I haven't researched very far, so could be wrong). But I don't think its currently possible to generate the necessarily html snippets in with the block to do this. (And I think to include the js we would need to d it on anything which includes the block - I don't think there is a way to include stuff in the head of html)

[ Permalink | « Hide ]

Tim Hunt added a comment - 15/Apr/09 11:23 AM

I seem to be using http://docs.moodle.org/en/Development:Navigation_2.0_implementation_plan instead of meta-bugs, so poaching this bug to use for $PAGE implementation.

$PAGE seems to be referred to in 190 places in 31 files. Lets see how much of that I can keep backwards-compatible.

[ Permalink | « Hide ]

Tim Hunt added a comment - 17/Apr/09 06:44 PM

Work in progress - I just wanted an off-site backup. However, if anyone wants to review it and comment on the direction I am taking, please be my guest.

[ Permalink | « Hide ]

Tim Hunt added a comment - 22/Apr/09 07:56 PM

Updated patch series, should anyone care.

[ Permalink | « Hide ]

Tim Hunt added a comment - 24/Apr/09 03:50 PM

Updated patch series for Nico.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 24/Apr/09 04:06 PM

I care, Tim.

Thanks for pushing on with this so well.

[ Permalink | « Hide ]

Tim Hunt added a comment - 24/Apr/09 04:08 PM

I should add, the current version prints a lot of developer debug warnings, becuase I have not finished updating legacy code.

[ Permalink | « Hide ]

Tim Hunt added a comment - 30/Apr/09 06:53 PM

Update work in progress.

[ Permalink | « Hide ]

Tim Hunt added a comment - 06/May/09 05:31 PM

This is now in CVS. There are a few odds and ends that need to be cleaned finished, but that will be done as parts of other issues. I am closing this bug now for the pleasing sense of closure it gives me

All content on this web site is made available under the GNU General Public License, unless otherwise stated.