Issue Details (XML | Word | Printable)

Key: MDL-12212
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Tim Hunt
Reporter: Martin Dougiamas
Votes: 2
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Reimplement $PAGE for Navigation 2.0

Created: 16/Nov/07 10:53 AM   Updated: 31/Oct/09 07:56 AM
Return to search
Component/s: Blocks, Lib
Affects Version/s: 1.9
Fix Version/s: 2.0

File Attachments: 1. Text File patchseries.txt (459 kB)
Issue Links:
Dependency
 

Participants: Dan Poltawski, Martin Dougiamas and Tim Hunt
Security Level: None
Resolved date: 06/May/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE

Sub-Tasks:   All   Open   
 Sub-Task Progress: 
No sub-tasks match this view.

 Description  « Hide
The implementation of blocks is completely rotten, rife with inconsistencies and gaps.

This meta bug is to track the complete review and overhaul of blocks to make them something we can be proud of.

One objective is to not break compatibility for the blocks themselves - this is just about pagelib, really and making it work consistently and simply across all the pages in Moodle.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 04/Mar/08 01:10 PM
Just 2.0

Martin Dougiamas made changes - 04/Mar/08 01:10 PM
Field Original Value New Value
Fix Version/s 1.9.1 [ 10240 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 29/Apr/08 02:21 PM
Most important thing on the new implementation is to base it around contexts instead of pageids

Martin Dougiamas made changes - 29/Apr/08 02:25 PM
Summary META: Complete review and consolidation of pagelib and the implementation of blocks throughout Moodle META: Complete review and rewrite of Pagelib (and blocks)
[ Permalink | « Hide ]
Dan Poltawski added a comment - 12/Jan/09 07:08 PM
Just so I remember to document this:

I was playing around trying to make a fancy block this weekend with YUI popups (much like the the repository picker). (I haven't researched very far, so could be wrong). But I don't think its currently possible to generate the necessarily html snippets in with the block to do this. (And I think to include the js we would need to d it on anything which includes the block - I don't think there is a way to include stuff in the head of html)


[ Permalink | « Hide ]
Tim Hunt added a comment - 15/Apr/09 11:23 AM
I seem to be using http://docs.moodle.org/en/Development:Navigation_2.0_implementation_plan instead of meta-bugs, so poaching this bug to use for $PAGE implementation.

$PAGE seems to be referred to in 190 places in 31 files. Lets see how much of that I can keep backwards-compatible.


Tim Hunt made changes - 15/Apr/09 11:23 AM
Summary META: Complete review and rewrite of Pagelib (and blocks) Reimplement $PAGE for Navigation 2.0
Assignee Martin Dougiamas [ dougiamas ] Tim Hunt [ timhunt ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 17/Apr/09 06:44 PM
Work in progress - I just wanted an off-site backup. However, if anyone wants to review it and comment on the direction I am taking, please be my guest.

Tim Hunt made changes - 17/Apr/09 06:44 PM
Attachment patchseries.txt [ 16933 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 22/Apr/09 07:56 PM
Updated patch series, should anyone care.

Tim Hunt made changes - 22/Apr/09 07:56 PM
Attachment patchseries.txt [ 17005 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 24/Apr/09 03:50 PM
Updated patch series for Nico.

Tim Hunt made changes - 24/Apr/09 03:50 PM
Attachment patchseries.txt [ 17029 ]
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 24/Apr/09 04:06 PM
I care, Tim. Thanks for pushing on with this so well.

[ Permalink | « Hide ]
Tim Hunt added a comment - 24/Apr/09 04:08 PM
I should add, the current version prints a lot of developer debug warnings, becuase I have not finished updating legacy code.

[ Permalink | « Hide ]
Tim Hunt added a comment - 30/Apr/09 06:53 PM
Update work in progress.

Tim Hunt made changes - 30/Apr/09 06:53 PM
Attachment patchseries.txt [ 17089 ]
Tim Hunt made changes - 01/May/09 06:56 PM
Attachment patchseries.txt [ 17102 ]
Tim Hunt made changes - 01/May/09 06:57 PM
Attachment patchseries.txt [ 17089 ]
Tim Hunt made changes - 01/May/09 06:57 PM
Attachment patchseries.txt [ 17029 ]
Tim Hunt made changes - 01/May/09 06:57 PM
Attachment patchseries.txt [ 17005 ]
Tim Hunt made changes - 01/May/09 06:58 PM
Attachment patchseries.txt [ 16933 ]
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 04:26 PM
moodle_page: MDL-12212 remove useless code as a preparitory step
MODIFY blocks/tag_flickr/block_tag_flickr.php   Rev. 1.21    (+1 -1 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.28    (+1 -6 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 04:27 PM
moodle_page: MDL-12212 deprecate page_import_types and clean up file
MODIFY lib/pagelib.php   Rev. 1.77    (+22 -46 lines)
tjhunt committed 16 files to 'Moodle CVS' - 06/May/09 04:29 PM
moodle_page: MDL-12212 start of new moodle_page class
* has course and status fields
* $PAGE->status updated by print_header and footer
* $PAGE->set_course now replace course_setup function
* global $PAGE created in setup.php
* unit tests for functionality so far
* Moodle still seems to work after this commit!
MODIFY lib/pagelib.php   Rev. 1.78    (+116 -3 lines)
MODIFY theme/chameleon/ui/css.php   Rev. 1.12    (+1 -1 lines)
MODIFY course/user.php   Rev. 1.93    (+2 -2 lines)
MODIFY lib/setup.php   Rev. 1.267    (+17 -3 lines)
MODIFY mod/forum/post.php   Rev. 1.188    (+4 -7 lines)
MODIFY mod/chat/gui_sockets/chatinput.php   Rev. 1.19    (+2 -2 lines)
MODIFY lib/upgradelib.php   Rev. 1.7    (+3 -3 lines)
MODIFY lib/sessionlib.php   Rev. 1.39    (+4 -4 lines)
MODIFY mod/chat/gui_header_js/users.php   Rev. 1.22    (+3 -3 lines)
MODIFY lib/moodlelib.php   Rev. 1.1196    (+15 -34 lines)
MODIFY mod/chat/gui_header_js/jsupdated.php   Rev. 1.16    (+3 -3 lines)
MODIFY lib/weblib.php   Rev. 1.1237    (+30 -33 lines)
MODIFY lib/adminlib.php   Rev. 1.346    (+4 -4 lines)
MODIFY mod/chat/chatd.php   Rev. 1.39    (+6 -5 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.31    (+2 -2 lines)
MODIFY mod/chat/gui_header_js/jsupdate.php   Rev. 1.43    (+3 -3 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 04:30 PM
moodle_page: MDL-12212 implement ->context
MODIFY lib/pagelib.php   Rev. 1.79    (+27 -1 lines)
ADD lib/simpletest/testpagelib_moodlepage.php   Rev. 1.1    (+0 -0 lines)
tjhunt committed 13 files to 'Moodle CVS' - 06/May/09 04:34 PM
moodle_page: MDL-12212 implement ->pagetype
MODIFY mod/chat/Attic/pagelib.php   Rev. 1.13    (+1 -5 lines)
MODIFY mod/quiz/Attic/pagelib.php   Rev. 1.19    (+1 -5 lines)
MODIFY admin/settings.php   Rev. 1.50    (+2 -1 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.29    (+1 -5 lines)
MODIFY lib/blocklib.php   Rev. 1.160    (+9 -9 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.15    (+1 -5 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.2    (+15 -1 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.6    (+0 -4 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.18    (+3 -10 lines)
MODIFY mod/lesson/Attic/pagelib.php   Rev. 1.10    (+2 -6 lines)
MODIFY lib/adminlib.php   Rev. 1.347    (+9 -8 lines)
MODIFY mod/data/Attic/pagelib.php   Rev. 1.13    (+1 -5 lines)
MODIFY lib/pagelib.php   Rev. 1.80    (+36 -22 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 04:35 PM
moodle_page: MDL-12212 remove code in legacy page types that stores a course record
MODIFY lib/pagelib.php   Rev. 1.81    (+19 -30 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.19    (+3 -10 lines)
MODIFY mod/lesson/Attic/pagelib.php   Rev. 1.11    (+6 -6 lines)
MODIFY blog/Attic/header.php   Rev. 1.54    (+2 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 04:36 PM
moodle_page: MDL-12212 eliminate two old methods that were never used
MODIFY lib/pagelib.php   Rev. 1.82    (+1 -11 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 04:36 PM
moodle_page: MDL-12212 rewrite blocks_name_allowed_in_format to improve readability
MODIFY lib/blocklib.php   Rev. 1.161    (+14 -14 lines)
tjhunt committed 19 files to 'Moodle CVS' - 06/May/09 04:38 PM
moodle_page: MDL-12212 kill $CFG->pagepath (use $PAGE->set_pagetype)
deprecate $PAGE->get_format_name (use $PAGE->pagetype)
deprecate page_id_and_class (use $PAGE->pagetype)
MODIFY login/index.php   Rev. 1.149    (+5 -2 lines)
MODIFY mod/data/field.php   Rev. 1.31    (+5 -10 lines)
MODIFY mod/lesson/action/addpage.php   Rev. 1.23    (+2 -4 lines)
MODIFY admin/mnet/enr_hosts.php   Rev. 1.10    (+2 -3 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.16    (+3 -9 lines)
MODIFY admin/auth_config.php   Rev. 1.26    (+1 -1 lines)
MODIFY question/question.php   Rev. 1.60    (+2 -2 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.21    (+2 -2 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.7    (+1 -5 lines)
MODIFY mod/lesson/action/addbranchtable.php   Rev. 1.20    (+2 -4 lines)
MODIFY lib/pagelib.php   Rev. 1.83    (+77 -54 lines)
MODIFY mod/hotpot/view.php   Rev. 1.48    (+3 -6 lines)
MODIFY admin/mnet/enr_course_enrol.php   Rev. 1.14    (+2 -2 lines)
MODIFY admin/mnet/enr_courses.php   Rev. 1.13    (+2 -2 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.20    (+1 -10 lines)
MODIFY course/mod.php   Rev. 1.139    (+2 -2 lines)
MODIFY lib/blocklib.php   Rev. 1.162    (+5 -5 lines)
MODIFY lib/weblib.php   Rev. 1.1239    (+13 -35 lines)
MODIFY course/modedit.php   Rev. 1.66    (+5 -4 lines)
tjhunt committed 9 files to 'Moodle CVS' - 06/May/09 04:41 PM
moodle_page: MDL-12212 eliminate the two different interpretations of
pagetype
MODIFY lib/blocklib.php   Rev. 1.163    (+2 -2 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.3    (+25 -7 lines)
MODIFY lib/db/upgrade.php   Rev. 1.290    (+9 -1 lines)
MODIFY admin/mnet/enr_courses.php   Rev. 1.14    (+1 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.84    (+2 -2 lines)
MODIFY admin/mnet/enr_course_enrol.php   Rev. 1.15    (+1 -2 lines)
MODIFY admin/index.php   Rev. 1.383    (+2 -1 lines)
MODIFY lib/moodlelib.php   Rev. 1.1197    (+5 -1 lines)
MODIFY admin/mnet/enr_hosts.php   Rev. 1.11    (+1 -2 lines)
tjhunt committed 3 files to 'Moodle CVS' - 06/May/09 04:42 PM
moodle_page: MDL-12212 ->bodyclasses and initialise_standard_body_classes
MODIFY lib/weblib.php   Rev. 1.1240    (+3 -25 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.4    (+21 -1 lines)
MODIFY lib/pagelib.php   Rev. 1.85    (+69 -13 lines)
tjhunt committed 12 files to 'Moodle CVS' - 06/May/09 04:43 PM
moodle_page: MDL-12212 more ->pagepaths to kill
MODIFY admin/repository.php   Rev. 1.25    (+2 -4 lines)
MODIFY admin/auth_config.php   Rev. 1.27    (+1 -2 lines)
MODIFY admin/settings.php   Rev. 1.51    (+2 -2 lines)
MODIFY admin/portfolio.php   Rev. 1.6    (+3 -4 lines)
MODIFY admin/enrol_config.php   Rev. 1.21    (+2 -3 lines)
MODIFY admin/Attic/wsprotocols.php   Rev. 1.3    (+1 -3 lines)
MODIFY admin/enrol.php   Rev. 1.34    (+1 -3 lines)
MODIFY admin/report/security/index.php   Rev. 1.7    (+3 -2 lines)
MODIFY lib/weblib.php   Rev. 1.1241    (+3 -3 lines)
MODIFY lib/blocklib.php   Rev. 1.164    (+2 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.86    (+3 -3 lines)
MODIFY course/modedit.php   Rev. 1.67    (+5 -4 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 04:44 PM
moodle_page: MDL-14305 (and MDL-12212) class on body based on ->wwwroot
MODIFY lib/simpletest/testmoodlelib.php   Rev. 1.21    (+7 -7 lines)
MODIFY lib/moodlelib.php   Rev. 1.1198    (+12 -11 lines)
MODIFY lib/pagelib.php   Rev. 1.87    (+37 -9 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.5    (+13 -4 lines)
tjhunt committed 5 files to 'Moodle CVS' - 06/May/09 04:46 PM
moodle_page: MDL-12212 ->category and ->categories
MODIFY course/category.php   Rev. 1.142    (+4 -7 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.6    (+111 -3 lines)
MODIFY lib/moodlelib.php   Rev. 1.1199    (+2 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.88    (+102 -2 lines)
MODIFY admin/roles/assign.php   Rev. 1.97    (+2 -1 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 04:46 PM
moodle_page: MDL-14306 (part of MDL-12212) class name on body with ->category

If ->allowcategorythemes is set, includes all parent categories too
MODIFY lib/pagelib.php   Rev. 1.89    (+40 -6 lines)
MODIFY admin/settings.php   Rev. 1.52    (+2 -2 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.7    (+11 -1 lines)
MODIFY lib/adminlib.php   Rev. 1.348    (+3 -3 lines)
tjhunt committed 6 files to 'Moodle CVS' - 06/May/09 04:48 PM
moodle_page: MDL-12212 ->docspath
MODIFY admin/report/security/lib.php   Rev. 1.15    (+3 -7 lines)
MODIFY lib/weblib.php   Rev. 1.1242    (+13 -27 lines)
MODIFY admin/report/security/index.php   Rev. 1.8    (+2 -3 lines)
MODIFY lib/pagelib.php   Rev. 1.90    (+25 -1 lines)
MODIFY index.php   Rev. 1.228    (+3 -2 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.8    (+15 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 04:49 PM
moodle_url: MDL-12212 clean up moodle_url coding style
MODIFY lib/weblib.php   Rev. 1.1243    (+48 -41 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 04:50 PM
moodle_page: MDL-12212 ->url and cleanup init of $FULLME, etc.
MODIFY lib/weblib.php   Rev. 1.1244    (+43 -22 lines)
MODIFY lib/pagelib.php   Rev. 1.91    (+33 -1 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.9    (+41 -1 lines)
MODIFY lib/setuplib.php   Rev. 1.51    (+87 -61 lines)
tjhunt committed 6 files to 'Moodle CVS' - 06/May/09 04:53 PM
moodle_page: MDL-12212 Eliminate legacy blocks_ methods

moving blocks will now be broken until the new bockslib is done
MODIFY my/Attic/pagelib.php   Rev. 1.17    (+1 -18 lines)
MODIFY mod/lesson/Attic/pagelib.php   Rev. 1.12    (+2 -19 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.30    (+1 -18 lines)
MODIFY lib/pagelib.php   Rev. 1.92    (+34 -60 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.8    (+0 -17 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.21    (+1 -43 lines)
tjhunt committed 28 files to 'Moodle CVS' - 06/May/09 04:55 PM
moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page
MODIFY admin/settings.php   Rev. 1.53    (+3 -2 lines)
MODIFY mod/quiz/view.php   Rev. 1.161    (+3 -2 lines)
MODIFY mod/lesson/view.php   Rev. 1.148    (+3 -2 lines)
MODIFY blocks/rss_client/Attic/config_instance.html   Rev. 1.37    (+3 -3 lines)
MODIFY mod/lesson/action/continue.php   Rev. 1.53    (+3 -2 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.18    (+1 -19 lines)
MODIFY lib/weblib.php   Rev. 1.1246    (+3 -3 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.31    (+14 -70 lines)
MODIFY admin/search.php   Rev. 1.21    (+3 -2 lines)
MODIFY mod/resource/lib.php   Rev. 1.113    (+2 -1 lines)
MODIFY lib/blocklib.php   Rev. 1.165    (+10 -10 lines)
MODIFY blocks/rss_client/Attic/config_instance_tabs.php   Rev. 1.13    (+3 -3 lines)
MODIFY lib/adminlib.php   Rev. 1.349    (+11 -6 lines)
MODIFY index.php   Rev. 1.229    (+4 -2 lines)
MODIFY mod/lesson/Attic/pagelib.php   Rev. 1.13    (+2 -12 lines)
MODIFY tag/index.php   Rev. 1.32    (+2 -1 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.10    (+2 -2 lines)
MODIFY mod/survey/view.php   Rev. 1.62    (+1 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.93    (+69 -101 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.22    (+3 -33 lines)
MODIFY mod/data/view.php   Rev. 1.107    (+3 -2 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.9    (+0 -13 lines)
MODIFY mod/chat/view.php   Rev. 1.80    (+3 -2 lines)
MODIFY blocks/rss_client/block_rss_client.php   Rev. 1.88    (+4 -4 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.109    (+3 -3 lines)
MODIFY course/view.php   Rev. 1.121    (+2 -3 lines)
MODIFY my/index.php   Rev. 1.24    (+3 -2 lines)
MODIFY blog/Attic/header.php   Rev. 1.55    (+15 -2 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 04:56 PM
moodle_page: MDL-12212 eliminate page::edit_always
MODIFY lib/pagelib.php   Rev. 1.94    (+1 -8 lines)
MODIFY lib/blocklib.php   Rev. 1.166    (+2 -9 lines)
tjhunt committed 23 files to 'Moodle CVS' - 06/May/09 04:59 PM
moodle_page: MDL-12212 reimplement user_is_editing, deprecate isediting
MODIFY blocks/social_activities/block_social_activities.php   Rev. 1.26    (+3 -3 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.19    (+1 -9 lines)
MODIFY course/search.php   Rev. 1.67    (+3 -3 lines)
MODIFY mod/scorm/locallib.php   Rev. 1.91    (+3 -3 lines)
MODIFY course/lib.php   Rev. 1.653    (+5 -5 lines)
MODIFY lib/adminlib.php   Rev. 1.350    (+4 -13 lines)
MODIFY lib/pagelib.php   Rev. 1.95    (+20 -29 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.23    (+4 -16 lines)
MODIFY course/format/topics/format.php   Rev. 1.97    (+7 -7 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.32    (+1 -7 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.11    (+36 -1 lines)
MODIFY blog/lib.php   Rev. 1.105    (+1 -12 lines)
MODIFY blog/index.php   Rev. 1.45    (+2 -3 lines)
MODIFY course/category.php   Rev. 1.143    (+3 -3 lines)
MODIFY admin/settings.php   Rev. 1.54    (+3 -11 lines)
MODIFY lib/moodlelib.php   Rev. 1.1200    (+5 -9 lines)
MODIFY blocks/admin/block_admin.php   Rev. 1.123    (+3 -3 lines)
MODIFY blocks/course_summary/block_course_summary.php   Rev. 1.29    (+3 -3 lines)
MODIFY lib/weblib.php   Rev. 1.1247    (+4 -4 lines)
MODIFY course/format/weeks/format.php   Rev. 1.90    (+7 -7 lines)
MODIFY blocks/site_main_menu/block_site_main_menu.php   Rev. 1.34    (+4 -4 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.10    (+0 -6 lines)
MODIFY course/index.php   Rev. 1.113    (+3 -3 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 05:00 PM
moodle_page: MDL-12212 remove get_extra_header_string method from blog page
MODIFY blog/Attic/blogpage.php   Rev. 1.24    (+5 -17 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 05:00 PM
moodle_page: MDL-12212 Unbreak home page when editing is on
MODIFY lib/pagelib.php   Rev. 1.96    (+3 -2 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 05:01 PM
moodle_page: MDL-12212 new implementation of user_allowed_editing
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.12    (+39 -1 lines)
MODIFY lib/pagelib.php   Rev. 1.97    (+36 -2 lines)
tjhunt committed 11 files to 'Moodle CVS' - 06/May/09 05:02 PM
moodle_page: MDL-12212 kill legacy page_allows_editing implementations
MODIFY lib/pagelib.php   Rev. 1.98    (+9 -60 lines)
MODIFY blog/Attic/header.php   Rev. 1.56    (+2 -1 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.110    (+4 -3 lines)
MODIFY tag/Attic/pagelib.php   Rev. 1.11    (+0 -5 lines)
MODIFY index.php   Rev. 1.230    (+2 -1 lines)
MODIFY admin/Attic/pagelib.php   Rev. 1.33    (+1 -11 lines)
MODIFY tag/index.php   Rev. 1.33    (+2 -1 lines)
MODIFY my/Attic/pagelib.php   Rev. 1.20    (+1 -10 lines)
MODIFY course/view.php   Rev. 1.122    (+2 -1 lines)
MODIFY my/index.php   Rev. 1.25    (+2 -1 lines)
MODIFY blog/Attic/blogpage.php   Rev. 1.25    (+1 -9 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 05:03 PM
moodle_page: MDL-12212 deprecate more of the legacy page machinery, and avoid overwriting $PAGE ever
MODIFY lib/pagelib.php   Rev. 1.99    (+68 -24 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 05:03 PM
moodle_page: MDL-12212 eliminate page_tag::print_footer
MODIFY tag/Attic/pagelib.php   Rev. 1.12    (+0 -4 lines)
MODIFY tag/index.php   Rev. 1.34    (+2 -3 lines)
tjhunt committed 3 files to 'Moodle CVS' - 06/May/09 05:03 PM
moodle_page: MDL-12212 ->cm and ->activityrecord fields
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.13    (+202 -1 lines)
MODIFY lib/adminlib.php   Rev. 1.351    (+4 -3 lines)
MODIFY lib/pagelib.php   Rev. 1.100    (+122 -81 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 05:03 PM
moodle_page: MDL-12212 ->subpage field
MODIFY lib/pagelib.php   Rev. 1.101    (+20 -1 lines)
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.14    (+8 -1 lines)
tjhunt committed 8 files to 'Moodle CVS' - 06/May/09 05:11 PM
moodle_page: MDL-12212 completely remove the old tag and admin page classes
MODIFY tag/index.php   Rev. 1.35    (+15 -7 lines)
MODIFY lib/upgradelib.php   Rev. 1.8    (+3 -4 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.111    (+5 -3 lines)
MODIFY lib/pagelib.php   Rev. 1.102    (+19 -4 lines)
MODIFY admin/settings.php   Rev. 1.55    (+39 -28 lines)
DEL admin/Attic/pagelib.php   Rev. 1.34    (+0 -0 lines)
DEL tag/Attic/pagelib.php   Rev. 1.13    (+0 -0 lines)
MODIFY lib/adminlib.php   Rev. 1.352    (+37 -22 lines)
tjhunt committed 1 file to 'Moodle CVS' - 06/May/09 05:13 PM
moodle_page: MDL-12212 clarify some comments
MODIFY lib/simpletest/testpagelib_moodlepage.php   Rev. 1.16    (+4 -2 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 05:19 PM
moodle_page: MDL-12212 remove deprecated calls from course/view.php and page_course::print_header
MODIFY course/view.php   Rev. 1.125    (+12 -3 lines)
MODIFY lib/pagelib.php   Rev. 1.106    (+1 -41 lines)
MODIFY lib/weblib.php   Rev. 1.1250    (+3 -3 lines)
MODIFY mod/forum/index.php   Rev. 1.123    (+5 -4 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 05:23 PM
moodle_page: MDL-12212 eliminate page_my_moodle
MODIFY my/index.php   Rev. 1.27    (+25 -12 lines)
MODIFY admin/Attic/stickyblocks.php   Rev. 1.23    (+3 -4 lines)
MODIFY lib/blocklib.php   Rev. 1.172    (+3 -21 lines)
DEL my/Attic/pagelib.php   Rev. 1.21    (+0 -0 lines)
tjhunt committed 5 files to 'Moodle CVS' - 06/May/09 05:24 PM
pagelib: MDL-12212 eliminate quiz_page
DEL mod/quiz/Attic/pagelib.php   Rev. 1.20    (+0 -0 lines)
MODIFY lib/accesslib.php   Rev. 1.587    (+2 -1 lines)
MODIFY mod/quiz/lib.php   Rev. 1.337    (+1 -7 lines)
MODIFY lib/blocklib.php   Rev. 1.173    (+12 -1 lines)
MODIFY mod/quiz/view.php   Rev. 1.163    (+15 -4 lines)
tjhunt committed 4 files to 'Moodle CVS' - 06/May/09 05:25 PM
pagelib: MDL-12212 eliminate chat_page
DEL mod/chat/Attic/pagelib.php   Rev. 1.14    (+0 -0 lines)
MODIFY mod/chat/lib.php   Rev. 1.140    (+1 -9 lines)
MODIFY mod/chat/view.php   Rev. 1.82    (+16 -8 lines)
MODIFY lib/pagelib.php   Rev. 1.107    (+2 -1 lines)
tjhunt committed 3 files to 'Moodle CVS' - 06/May/09 05:26 PM
pagelib: MDL-12212 eliminate data_page
DEL mod/data/Attic/pagelib.php   Rev. 1.14    (+0 -0 lines)
MODIFY lib/pagelib.php   Rev. 1.108    (+4 -1 lines)
MODIFY mod/data/view.php   Rev. 1.109    (+16 -9 lines)
tjhunt committed 2 files to 'Moodle CVS' - 06/May/09 05:27 PM
moodle_page: MDL-12212 add a couple more useful classes to body
MODIFY lib/pagelib.php   Rev. 1.110    (+7 -1 lines)
MODIFY lib/pagelib.php   Rev. 1.109    (+7 -1 lines)
tjhunt committed 8 files to 'Moodle CVS' - 06/May/09 05:29 PM
moodle_page: MDL-12212 improve comments and add some work-in-progress warnings
MODIFY lib/adminlib.php   Rev. 1.354    (+4 -3 lines)
MODIFY mod/chat/view.php   Rev. 1.83    (+4 -1 lines)
MODIFY mod/quiz/view.php   Rev. 1.164    (+3 -1 lines)
MODIFY course/view.php   Rev. 1.126    (+4 -1 lines)
MODIFY admin/settings.php   Rev. 1.58    (+3 -2 lines)
MODIFY my/index.php   Rev. 1.28    (+3 -1 lines)
MODIFY mod/data/view.php   Rev. 1.110    (+3 -1 lines)
MODIFY lib/pagelib.php   Rev. 1.111    (+27 -15 lines)
tjhunt committed 5 files to 'Moodle CVS' - 06/May/09 05:31 PM
pagelib: MDL-12212 eliminate data_lesson
MODIFY mod/lesson/view.php   Rev. 1.150    (+5 -7 lines)
MODIFY mod/lesson/lib.php   Rev. 1.64    (+2 -8 lines)
MODIFY mod/lesson/action/continue.php   Rev. 1.55    (+4 -7 lines)
MODIFY mod/lesson/locallib.php   Rev. 1.81    (+63 -29 lines)
DEL mod/lesson/Attic/pagelib.php   Rev. 1.14    (+0 -0 lines)
[ Permalink | « Hide ]
Tim Hunt added a comment - 06/May/09 05:31 PM
This is now in CVS. There are a few odds and ends that need to be cleaned finished, but that will be done as parts of other issues. I am closing this bug now for the pleasing sense of closure it gives me

Tim Hunt made changes - 06/May/09 05:31 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 18/May/09 01:07 AM
MDL-12212 fixed missing globals
MODIFY lib/setuplib.php   Rev. 1.57    (+3 -1 lines)
Petr Skoda committed 4 files to 'Moodle CVS' - 18/May/09 01:10 AM
MDL-12212 implemented better merging of our string changes with tinymce upstream
MODIFY lib/editor/tinymce/extra/tools/download_langs.sh   Rev. 1.1    (+0 -0 lines)
MODIFY lang/en_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY lib/editor/tinymce/extra/tools/update_lang_files.php   Rev. 1.3    (+61 -42 lines)
DEL lib/editor/tinymce/extra/tools/Attic/get_langs.sh   Rev. 1.3    (+0 -0 lines)
Petr Skoda committed 47 files to 'Lang CVS' - 18/May/09 01:16 AM
MDL-12212 implemented better merging of our string changes with tinymce upstream
MODIFY fa_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY da_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY bs_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY vi_utf8/editor_tinymce.php   Rev. 1.4    (+4 -6 lines)
MODIFY de_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY el_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY ja_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY lt_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY pt_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY sl_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY mn_utf8/editor_tinymce.php   Rev. 1.3    (+2 -4 lines)
MODIFY no_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY be_utf8/editor_tinymce.php   Rev. 1.3    (+2 -4 lines)
MODIFY it_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY ar_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY et_utf8/editor_tinymce.php   Rev. 1.4    (+4 -6 lines)
MODIFY he_utf8/editor_tinymce.php   Rev. 1.4    (+10 -10 lines)
MODIFY mk_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY es_utf8/editor_tinymce.php   Rev. 1.4    (+7 -9 lines)
MODIFY si_utf8/editor_tinymce.php   Rev. 1.4    (+14 -16 lines)
MODIFY sk_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY nl_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY lv_utf8/editor_tinymce.php   Rev. 1.4    (+6 -8 lines)
MODIFY ro_utf8/editor_tinymce.php   Rev. 1.4    (+6 -8 lines)
MODIFY cy_utf8/editor_tinymce.php   Rev. 1.3    (+3 -5 lines)
MODIFY ms_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY hu_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY ca_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY fi_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY bg_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY th_utf8/editor_tinymce.php   Rev. 1.3    (+3 -5 lines)
MODIFY hr_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY pl_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY sq_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY ru_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY is_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY gl_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY sv_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY bn_utf8/editor_tinymce.php   Rev. 1.3    (+4 -6 lines)
MODIFY id_utf8/editor_tinymce.php   Rev. 1.3    (+3 -5 lines)
MODIFY nn_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY fr_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY tr_utf8/editor_tinymce.php   Rev. 1.4    (+3 -5 lines)
MODIFY cs_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY uk_utf8/editor_tinymce.php   Rev. 1.4    (+4 -6 lines)
MODIFY zh_tw_utf8/editor_tinymce.php   Rev. 1.4    (+2 -4 lines)
MODIFY gu_utf8/editor_tinymce.php   Rev. 1.3    (+3 -5 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/May/09 01:29 AM
MDL-12212 readme improvements
MODIFY lib/editor/tinymce/readme_moodle.txt   Rev. 1.5    (+23 -23 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 26/May/09 05:45 AM
MDL-12212 fixed missing course setup + tags incorrect $id parameter
MODIFY user/edit.php   Rev. 1.186    (+4 -2 lines)
Jerome Mouneyrac committed 1 file to 'Moodle CVS' - 15/Jul/09 02:11 PM
moodle_page: MDL-12212 misspelling
MODIFY lib/pagelib.php   Rev. 1.140    (+1 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' - 21/Jul/09 03:02 PM
pagelib: MDL-12212 require_login should set $PAGE->cm, if appicable.
MODIFY lib/moodlelib.php   Rev. 1.1229    (+5 -1 lines)
Dan Poltawski made changes - 31/Oct/09 07:56 AM
Link This issue will help resolve MDL-4138 [ MDL-4138 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators