[#MDL-12249] Groups UI cleanup and improvements

Issue Details (XML | Word | Printable)

Key:	MDL-12249
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Groups UI cleanup and improvements

Created: 19/Nov/07 03:34 PM Updated: 20/Nov/07 04:40 AM

Return to search

Component/s:

Groups

Affects Version/s:

1.9

Fix Version/s:

1.9

Participants:	Petr Skoda
Security Level:	None
Resolved date:	20/Nov/07
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

problems:
* autogroup does not check for duplicate names
* autogroup does not create groupings
* 2 XSS autogroup and groupings
* improve autogroup form
* use table for autogroup preview
* trim names of groups and groupings
* other small issues

oh - and trailing whitespace!

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 19/Nov/07 03:36 PM

Field	Original Value	New Value
Description	problems: * autogroup does not check for duplicate names * autogroup does not create groupings * 2 XSS autogroup and groupings * improve autogroup form * use table for autogroup preview * trim names of groups and groupings * other small issues	problems: * autogroup does not check for duplicate names * autogroup does not create groupings * 2 XSS autogroup and groupings * improve autogroup form * use table for autogroup preview * trim names of groups and groupings * other small issues oh - and trailing whitespace!

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Nov/07 04:13 AM - edited

fix tabs
table in overview
descriptions in overview
trim group and grouping names
language pack cleanup

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Nov/07 04:40 AM

done and committed into cvs - ccing Matt
please reopen in case of any problems or regressions

Petr Skoda made changes - 20/Nov/07 04:40 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Petr Skoda committed 16 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 20/Nov/07 05:27 AM

~~MDL-12249~~ groups UI cleanup and improvements - see tracker for details

MODIFY	group/assign.php	Rev. 1.18.2.1	(+3 -29 lines)
MODIFY	group/group_form.php	Rev. 1.3.2.1	(+2 -2 lines)
MODIFY	group/overview.php	Rev. 1.1.2.1	(+136 -158 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.516.2.17	(+0 -36 lines)
MODIFY	lang/en_utf8/group.php	Rev. 1.22.2.2	(+22 -21 lines)
MODIFY	group/autogroup.php	Rev. 1.1.2.2	(+170 -95 lines)
MODIFY	group/group.php	Rev. 1.15.2.1	(+1 -1 lines)
MODIFY	group/grouping_form.php	Rev. 1.1.2.1	(+2 -2 lines)
MODIFY	group/autogroup_form.php	Rev. 1.1.2.1	(+89 -50 lines)
MODIFY	group/grouping.php	Rev. 1.14.2.1	(+4 -7 lines)
MODIFY	group/lib.php	Rev. 1.8.2.1	(+102 -43 lines)
MODIFY	lib/grouplib.php	Rev. 1.22.2.1	(+29 -20 lines)
MODIFY	group/tabs.php	Rev. 1.2.2.1	(+7 -4 lines)
MODIFY	group/groupings.php	Rev. 1.2.2.1	(+2 -1 lines)
MODIFY	group/index.php	Rev. 1.37.2.1	(+6 -9 lines)
MODIFY	group/members.php	Rev. 1.3.2.1	(+6 -6 lines)

Petr Skoda committed 16 files to 'Moodle CVS' - 20/Nov/07 05:31 AM

~~MDL-12249~~ groups UI cleanup and improvements - see tracker for details; merged from MOODLE_19_STABLE

MODIFY	lang/en_utf8/group.php	Rev. 1.24	(+22 -21 lines)
MODIFY	group/assign.php	Rev. 1.19	(+3 -29 lines)
MODIFY	group/grouping_form.php	Rev. 1.2	(+2 -2 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.535	(+0 -36 lines)
MODIFY	group/members.php	Rev. 1.4	(+6 -6 lines)
MODIFY	group/group.php	Rev. 1.16	(+1 -1 lines)
MODIFY	group/group_form.php	Rev. 1.4	(+2 -2 lines)
MODIFY	lib/grouplib.php	Rev. 1.23	(+29 -20 lines)
MODIFY	group/groupings.php	Rev. 1.3	(+2 -1 lines)
MODIFY	group/autogroup_form.php	Rev. 1.2	(+89 -50 lines)
MODIFY	group/index.php	Rev. 1.38	(+6 -9 lines)
MODIFY	group/overview.php	Rev. 1.2	(+136 -158 lines)
MODIFY	group/grouping.php	Rev. 1.15	(+4 -7 lines)
MODIFY	group/tabs.php	Rev. 1.3	(+7 -4 lines)
MODIFY	group/autogroup.php	Rev. 1.3	(+170 -95 lines)
MODIFY	group/lib.php	Rev. 1.9	(+102 -43 lines)