Details
-
Type:
Sub-task
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8, 1.9, 2.0
-
Component/s: Accessibility, AJAX, Course
-
Labels:None
-
Affected Branches:MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
-
Fixed Branches:MOODLE_19_STABLE, MOODLE_20_STABLE
Description
A lot of very basic accessibility and usability errors - developers may assume that users of assistive technology would have the "AJAX and Javascript" user profile setting set to "no", but users may not know about this "advanced" setting, and in any case their seems to have been lazy development.
Was this a Google Summer of Code project? - these ad hoc developers need to gain basic accessibility awareness, and their work needs serious code review (http://docs.moodle.org/en/Student_projects/AJAX_course_format).
Problems include ('buttons' here means an image and container with a Javascript event):
1. A bug in lib/ajax/ajaxcourse.js main_class.prototype.mk_button function - the second FOR loop should test "c<imgAttributes.length" NOT "c<attributes.length" (nothing to do with accessibility),
2. None of the buttons created in section_classes.js or block_classes.js have ALT text. Some have a TITLE, but this is inconsistent.
3. Where possible the ALT text needs to be specific - for example "Move section N". (the container TITLE can be just "Move" - awkward for IE).
4. The ALT text for the show/hide buttons should toggle between "Show ..." and "Hide ..."
5. I think the Javascript is removing the images from the non-AJAX course format buttons, but keeping the links - BAD - the whole link needs removing.
6. For the buttons, the container is sometimes an 'a' anchor, sometimes a DIV - need consistency - should it be an <input type="image" .../> ?
The attached patch address items 1-4 (do 5 separately). A new parameter 'text' is added to the main_class.prototype.mk_button method. Tested in Firefox and IE 6.
I'd like to get quick feedback, then commit to HEAD and 1.9 branches.
The patch affects 5 files:
-lang/en_utf8/moodle.php - 2 new strings, 'hidesection', 'movesection'.
-lib/ajax/ajaxcourse.js - modifies mk_button method (minor edit to main_class.prototype.getString).
-lib/ajax/ajaxlib.js - use more language strings.
-lib/ajax/block_classes.js
-lib/ajax/section_classes.js