[#MDL-12268] Ajax Not working in Catalan. Javascript Problem

Issue Details (XML | Word | Printable)

Key:	MDL-12268
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Andrew Davis
Reporter:	Sergi Tur Badenas
Votes:	4
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Ajax Not working in Catalan. Javascript Problem

Created: 20/Nov/07 06:08 PM Updated: Monday 04:49 PM

Return to search

Component/s:

AJAX

Affects Version/s:

1.8.1

Fix Version/s:

1.9.7

Environment:

« Hide

Moodle 1.8.2 on a Ubuntu Server 7.10 Gutsy.

The same problem with Firefox and IExplorer

Participants:	Andrew Davis, Carles Bellver, guy thomas and Sergi Tur Badenas
Security Level:	None
Resolved date:	23/Nov/09
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

I Enabled Ajax in site and User Profile but Ajax is not working in catalan. I realized it was a problem with the language because i change to Spanish or English and Ajax starts working.

I enabled Javascript Error Console in Firefox and no errors in Spanish or English. But in catalan javascript throws the following error:

missing ; before staement
http://www.iescopernic.com/moodle................
main.portal.strings['moveleft']='Mou a l'esquerra';

It was a problem because no ' scaping character.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Carles Bellver added a comment - 20/Nov/07 09:33 PM - edited

I think this javascript code is added by function print_javascript in lib/ajax/ajaxlib.php, which calls get_string to obtain messages in the custom language:

$output .= " main.portal.strings['moveleft']='".get_string('moveleft')."';\n";

Maybe addslashes () should be applied here to get_string, in order to escape any quotes?

[ Permalink | « Hide ]

guy thomas added a comment - 13/Jan/09 08:56 PM

All get_string functions that need to be single quote safe should call a single quote safe get_string function.

I've modified lib/ajax/ajaxlib.php as follows:

/**

GT Mod 2009/01/13
Return langauge string that is single quote safe
Used to fix bug ~~MDL-12268~~
*/
function get_string_js($strname){ $str=get_string($strname); $str=str_replace('\'', "\'", $strname); return ($str); }

/**

Prints the JavaScript code needed to set up AJAX for the course.
*/
function print_javascript($courseid, $return=false) {
global $CFG, $USER;

$blocksoutput = $output = '';
for ($i=0; $i<count($this->blocks); $i++) {
$blocksoutput .= "['".$this->blocks[$i][0]."',
'".$this->blocks[$i][1]."',
'".$this->blocks[$i][2]."']";

$blocksoutput .= ','; }
}
$output $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output .= " $output if ($return) { return $output; } else { echo $output; }
} if ($i != (count($this->blocks) - 1)) { .= "<script type=\"text/javascript\">\n";
main.portal.id = ".$courseid.";\n";
main.portal.blocks = new Array(".$blocksoutput.");\n";
main.portal.strings['wwwroot']='".$CFG->wwwroot."';\n";
main.portal.strings['pixpath']='".$CFG->pixpath."';\n";
main.portal.strings['marker']='".$this->get_string_js('markthistopic', '', 'var')."';\n";
main.portal.strings['marked']='".$this->get_string_js('markedthistopic', '', 'var')."';\n";
main.portal.strings['hide']='".$this->get_string_js('hide')."';\n";
main.portal.strings['hidesection']='".$this->get_string_js('hidesection', '', 'var')."';\n";
main.portal.strings['show']='".$this->get_string_js('show')."';\n";
main.portal.strings['delete']='".$this->get_string_js('delete')."';\n";
main.portal.strings['move']='".$this->get_string_js('move')."';\n";
main.portal.strings['movesection']='".$this->get_string_js('movesection', '', 'var')."';\n";
main.portal.strings['moveleft']='".$this->get_string_js('moveleft')."';\n";
main.portal.strings['moveright']='".$this->get_string_js('moveright')."';\n";
main.portal.strings['update']='".$this->get_string_js('update')."';\n";
main.portal.strings['groupsnone']='".$this->get_string_js('groupsnone')."';\n";
main.portal.strings['groupsseparate']='".$this->get_string_js('groupsseparate')."';\n";
main.portal.strings['groupsvisible']='".$this->get_string_js('groupsvisible')."';\n";
main.portal.strings['clicktochange']='".$this->get_string_js('clicktochange')."';\n";
main.portal.strings['deletecheck']='".$this->get_string_js('deletecheck','','var')."';\n";
main.portal.strings['resource']='".$this->get_string_js('resource')."';\n";
main.portal.strings['activity']='".$this->get_string_js('activity')."';\n";
main.portal.strings['sesskey']='".$USER->sesskey."';\n";
onloadobj.load();\n";
main.process_blocks();\n";
.= "</script>";

[ Show » ]

guy thomas added a comment - 13/Jan/09 08:56 PM All get_string functions that need to be single quote safe should call a single quote safe get_string function. I've modified lib/ajax/ajaxlib.php as follows: /**

GT Mod 2009/01/13
Return langauge string that is single quote safe
Used to fix bug ~~MDL-12268~~ */ function get_string_js($strname){ $str=get_string($strname); $str=str_replace('\'', "\'", $strname); return ($str); }

/**

Prints the JavaScript code needed to set up AJAX for the course. */ function print_javascript($courseid, $return=false) { global $CFG, $USER;

$blocksoutput = $output = ''; for ($i=0; $i<count($this->blocks); $i++) { $blocksoutput .= "['".$this->blocks[$i][0]."', '".$this->blocks[$i][1]."', '".$this->blocks[$i][2]."']"; if ($i != (count($this->blocks) - 1)) { $blocksoutput .= ','; } } $output .= "<script type=\"text/javascript\">\n"; $output .= " main.portal.id = ".$courseid.";\n"; $output .= " main.portal.blocks = new Array(".$blocksoutput.");\n"; $output .= " main.portal.strings['wwwroot']='".$CFG->wwwroot."';\n"; $output .= " main.portal.strings['pixpath']='".$CFG->pixpath."';\n"; $output .= " main.portal.strings['marker']='".$this->get_string_js('markthistopic', '', 'var')."';\n"; $output .= " main.portal.strings['marked']='".$this->get_string_js('markedthistopic', '', 'var')."';\n"; $output .= " main.portal.strings['hide']='".$this->get_string_js('hide')."';\n"; $output .= " main.portal.strings['hidesection']='".$this->get_string_js('hidesection', '', 'var')."';\n"; $output .= " main.portal.strings['show']='".$this->get_string_js('show')."';\n"; $output .= " main.portal.strings['delete']='".$this->get_string_js('delete')."';\n"; $output .= " main.portal.strings['move']='".$this->get_string_js('move')."';\n"; $output .= " main.portal.strings['movesection']='".$this->get_string_js('movesection', '', 'var')."';\n"; $output .= " main.portal.strings['moveleft']='".$this->get_string_js('moveleft')."';\n"; $output .= " main.portal.strings['moveright']='".$this->get_string_js('moveright')."';\n"; $output .= " main.portal.strings['update']='".$this->get_string_js('update')."';\n"; $output .= " main.portal.strings['groupsnone']='".$this->get_string_js('groupsnone')."';\n"; $output .= " main.portal.strings['groupsseparate']='".$this->get_string_js('groupsseparate')."';\n"; $output .= " main.portal.strings['groupsvisible']='".$this->get_string_js('groupsvisible')."';\n"; $output .= " main.portal.strings['clicktochange']='".$this->get_string_js('clicktochange')."';\n"; $output .= " main.portal.strings['deletecheck']='".$this->get_string_js('deletecheck','','var')."';\n"; $output .= " main.portal.strings['resource']='".$this->get_string_js('resource')."';\n"; $output .= " main.portal.strings['activity']='".$this->get_string_js('activity')."';\n"; $output .= " main.portal.strings['sesskey']='".$USER->sesskey."';\n"; $output .= " onloadobj.load();\n"; $output .= " main.process_blocks();\n"; $output .= "</script>"; if ($return) { return $output; } else { echo $output; } }

[ Permalink | « Hide ]

Andrew Davis added a comment - 23/Nov/09 11:37 AM

That section of ajaxlib.php appears to have already been modified in 1.9 and 2. You can now use Ajax while in Catalan in both branches.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.