Issue Details (XML | Word | Printable)

Key: MDL-12304
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Daniel Pouliot
Votes: 1
Watchers: 5
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14610

Chat show text in double

Created: 22/Nov/07 12:45 AM   Updated: 14/Oct/08 04:00 PM
Return to search
Component/s: Chat
Affects Version/s: 1.6.5, 1.8.3
Fix Version/s: 1.9.3

File Attachments: 1. Text File rev-278.patch (0.9 kB)

Image Attachments:

1. chatDoubleTextScreenshot.png
(266 kB)
Issue Links:
Relates
 

Participants: Daniel Pouliot, Debora Weber-Wulff, Dongsheng Cai, Petr Skoda, Ryan Smith and Teresa Gibbison
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 08/Oct/08
Affected Branches: MOODLE_16_STABLE, MOODLE_18_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
In Chat module, the text appear in double as soon as a first message appears. In the facts, script 'jsupdate' is called twice which causes double text. The problem is in the choice of the anchors when script refreshed the list of the users. Patch in attachment. May be we should select the Anchors by its name rather then its appearance order in the script.


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Debora Weber-Wulff added a comment - 12/Dec/07 04:21 AM
We have this issue in 1.8.3 using Julian Ridden's Imagine Theme with some color changes. Only the first message (and occasionally inbetween) are shown singly, other than that, the messages are doubled, and if people type fast we have them interleaved. We switched to another theme (a custom one made on the basis of standardgreen, and the doubling went away.

In addition, the list of attendees went away, there was a "Refresh link" link that didn't work. Changing the theme made the list of attendees reappear. Now if I only knew what to change in Julian's Theme, I kind of like it.....


Dongsheng Cai added a comment - 30/Apr/08 02:47 PM
In standard theme, this bug cannot be reproduced, it seems we should give anchors names.

Teresa Gibbison added a comment - 03/Jun/08 12:01 PM
I have found this happens when I use Firefox but not IE (only tested a couple of times today). Attached is the screenshot of this with the list of participants in the chat not showing in Firefox, the double text and a 'Refresh link' link??? Notice the URL at the bottom - I have hovered over the 'Refresh link' link.

I hope this helps you reproduce this.
Teresa


Teresa Gibbison added a comment - 03/Jun/08 12:02 PM
As per my comment added today (3 June 2008)

Dongsheng Cai added a comment - 10/Jun/08 01:21 PM
Apply daniel's patch to 1.8 and head, it seems OK now, please review, feel free to reopen

Petr Skoda added a comment - 10/Jun/08 11:34 PM
reopening, I can see the patch in MOODLE_18_STABLE and HEAD, but not in MOODLE_19_STABLE - but the Fix Version says 1.9.2, hmm

Dongsheng Cai added a comment - 11/Jun/08 02:06 PM
Fixed in MOODLE_19_STABLE

Ryan Smith added a comment - 12/Jun/08 03:18 AM
I just updated my Moodle 1.9.x from moodle_19_stable and this is causing problems in the chat. The chat participants pane is not updating, the right pane does not update when a new person comes into the chat. I had to revert back to the previous jsupdate.php file.

Petr Skoda added a comment - 12/Jun/08 03:48 AM
reopening

Dongsheng Cai added a comment - 13/Jun/08 11:41 AM
To completely solve this problem, we really need a new chat GUI, please see this issue: MDL-14651

Dongsheng Cai added a comment - 17/Jun/08 02:22 PM - edited
I add an ID attribute for the link in user.php, some javascript errors are fixed, see attachment.

Please have a look at this issue: MDL-14651, and give me some feedback.


Dongsheng Cai added a comment - 18/Jun/08 11:20 AM
Committed, a ID attribute added, please review.

Petr Skoda added a comment - 25/Jun/08 05:10 AM
there is still one js error immediately after joining the chat with IE6(in jsupdate.php script, it disappears after the first refresh

Petr Skoda added a comment - 25/Jun/08 05:12 AM
the messages are not appearing at all in Safari for windows

Ryan Smith added a comment - 25/Jun/08 05:32 AM
We've seen the same bug with Safari. It just happened again today when we had a large group chat. The Safari user did not see any messages. I quickly tested it on the latest Safari on Windows and I was able to reproduce it.

Of course, we just recommended that the user switched to Firefox...the HTML editor doesn't work in Safari anyways...which means they lose most functionality in Moodle.


Dongsheng Cai added a comment - 25/Jun/08 09:52 AM
HI, Petr and Ryan, the js error is caused by MDL-8642.
Sorry for the bugs in Safari, I don't have environment to test it, I am installing VirtualBox...

Dongsheng Cai added a comment - 08/Oct/08 03:35 PM
Double text should be fixed.
There are some problems of using chat in Safari, I will create another issue to fix it.

Petr Skoda added a comment - 14/Oct/08 04:00 PM
verified, closing, thanks