Moodle

Chat show text in double

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6.5, 1.8.3
  • Fix Version/s: 1.9.3
  • Component/s: Chat
  • Labels:
    None
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

In Chat module, the text appear in double as soon as a first message appears. In the facts, script 'jsupdate' is called twice which causes double text. The problem is in the choice of the anchors when script refreshed the list of the users. Patch in attachment. May be we should select the Anchors by its name rather then its appearance order in the script.

Issue Links

This issue has a non-specific relationship to:
MDL-16878 Chat does not refresh when using safari Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Debora Weber-Wulff added a comment -

We have this issue in 1.8.3 using Julian Ridden's Imagine Theme with some color changes. Only the first message (and occasionally inbetween) are shown singly, other than that, the messages are doubled, and if people type fast we have them interleaved. We switched to another theme (a custom one made on the basis of standardgreen, and the doubling went away.

In addition, the list of attendees went away, there was a "Refresh link" link that didn't work. Changing the theme made the list of attendees reappear. Now if I only knew what to change in Julian's Theme, I kind of like it.....

Show
Debora Weber-Wulff added a comment - We have this issue in 1.8.3 using Julian Ridden's Imagine Theme with some color changes. Only the first message (and occasionally inbetween) are shown singly, other than that, the messages are doubled, and if people type fast we have them interleaved. We switched to another theme (a custom one made on the basis of standardgreen, and the doubling went away. In addition, the list of attendees went away, there was a "Refresh link" link that didn't work. Changing the theme made the list of attendees reappear. Now if I only knew what to change in Julian's Theme, I kind of like it.....
Hide
Permalink
Dongsheng Cai added a comment -

In standard theme, this bug cannot be reproduced, it seems we should give anchors names.

Show
Dongsheng Cai added a comment - In standard theme, this bug cannot be reproduced, it seems we should give anchors names.
Hide
Permalink
Teresa Gibbison added a comment -

I have found this happens when I use Firefox but not IE (only tested a couple of times today). Attached is the screenshot of this with the list of participants in the chat not showing in Firefox, the double text and a 'Refresh link' link??? Notice the URL at the bottom - I have hovered over the 'Refresh link' link.

I hope this helps you reproduce this.
Teresa

Show
Teresa Gibbison added a comment - I have found this happens when I use Firefox but not IE (only tested a couple of times today). Attached is the screenshot of this with the list of participants in the chat not showing in Firefox, the double text and a 'Refresh link' link??? Notice the URL at the bottom - I have hovered over the 'Refresh link' link. I hope this helps you reproduce this. Teresa
Hide
Permalink
Teresa Gibbison added a comment -

As per my comment added today (3 June 2008)

Show
Teresa Gibbison added a comment - As per my comment added today (3 June 2008)
Hide
Permalink
Dongsheng Cai added a comment -

Apply daniel's patch to 1.8 and head, it seems OK now, please review, feel free to reopen

Show
Dongsheng Cai added a comment - Apply daniel's patch to 1.8 and head, it seems OK now, please review, feel free to reopen
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening, I can see the patch in MOODLE_18_STABLE and HEAD, but not in MOODLE_19_STABLE - but the Fix Version says 1.9.2, hmm

Show
Petr Škoda (skodak) added a comment - reopening, I can see the patch in MOODLE_18_STABLE and HEAD, but not in MOODLE_19_STABLE - but the Fix Version says 1.9.2, hmm
Hide
Permalink
Dongsheng Cai added a comment -

Fixed in MOODLE_19_STABLE

Show
Dongsheng Cai added a comment - Fixed in MOODLE_19_STABLE
Hide
Permalink
Ryan Smith added a comment -

I just updated my Moodle 1.9.x from moodle_19_stable and this is causing problems in the chat. The chat participants pane is not updating, the right pane does not update when a new person comes into the chat. I had to revert back to the previous jsupdate.php file.

Show
Ryan Smith added a comment - I just updated my Moodle 1.9.x from moodle_19_stable and this is causing problems in the chat. The chat participants pane is not updating, the right pane does not update when a new person comes into the chat. I had to revert back to the previous jsupdate.php file.
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening

Show
Petr Škoda (skodak) added a comment - reopening
Hide
Permalink
Dongsheng Cai added a comment -

To completely solve this problem, we really need a new chat GUI, please see this issue: MDL-14651

Show
Dongsheng Cai added a comment - To completely solve this problem, we really need a new chat GUI, please see this issue: MDL-14651
Hide
Permalink
Dongsheng Cai added a comment - - edited

I add an ID attribute for the link in user.php, some javascript errors are fixed, see attachment.

Please have a look at this issue: MDL-14651, and give me some feedback.

Show
Dongsheng Cai added a comment - - edited I add an ID attribute for the link in user.php, some javascript errors are fixed, see attachment. Please have a look at this issue: MDL-14651, and give me some feedback.
Hide
Permalink
Dongsheng Cai added a comment -

Committed, a ID attribute added, please review.

Show
Dongsheng Cai added a comment - Committed, a ID attribute added, please review.
Hide
Permalink
Petr Škoda (skodak) added a comment -

there is still one js error immediately after joining the chat with IE6(in jsupdate.php script, it disappears after the first refresh

Show
Petr Škoda (skodak) added a comment - there is still one js error immediately after joining the chat with IE6(in jsupdate.php script, it disappears after the first refresh
Hide
Permalink
Petr Škoda (skodak) added a comment -

the messages are not appearing at all in Safari for windows

Show
Petr Škoda (skodak) added a comment - the messages are not appearing at all in Safari for windows
Hide
Permalink
Ryan Smith added a comment -

We've seen the same bug with Safari. It just happened again today when we had a large group chat. The Safari user did not see any messages. I quickly tested it on the latest Safari on Windows and I was able to reproduce it.

Of course, we just recommended that the user switched to Firefox...the HTML editor doesn't work in Safari anyways...which means they lose most functionality in Moodle.

Show
Ryan Smith added a comment - We've seen the same bug with Safari. It just happened again today when we had a large group chat. The Safari user did not see any messages. I quickly tested it on the latest Safari on Windows and I was able to reproduce it. Of course, we just recommended that the user switched to Firefox...the HTML editor doesn't work in Safari anyways...which means they lose most functionality in Moodle.
Hide
Permalink
Dongsheng Cai added a comment -

HI, Petr and Ryan, the js error is caused by MDL-8642.
Sorry for the bugs in Safari, I don't have environment to test it, I am installing VirtualBox...

Show
Dongsheng Cai added a comment - HI, Petr and Ryan, the js error is caused by MDL-8642. Sorry for the bugs in Safari, I don't have environment to test it, I am installing VirtualBox...
Hide
Permalink
Dongsheng Cai added a comment -

Double text should be fixed.
There are some problems of using chat in Safari, I will create another issue to fix it.

Show
Dongsheng Cai added a comment - Double text should be fixed. There are some problems of using chat in Safari, I will create another issue to fix it.
Hide
Permalink
Petr Škoda (skodak) added a comment -

verified, closing, thanks

Show
Petr Škoda (skodak) added a comment - verified, closing, thanks

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.