Issue Details (XML | Word | Printable)

Key: MDL-12389
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nicolas Connault
Reporter: Tim Hunt
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Select/deselect all items links on grade_export_form.php

Created: 29/Nov/07 10:51 PM   Updated: 04/Dec/07 06:38 PM
Return to search
Component/s: Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9, 2.0

Participants: Nicolas Connault and Tim Hunt
Security Level: None
Resolved date: 04/Dec/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Doing this probably involves enhancements to formslib. From skype:

[14:43:15] Tim Hunt says: Petr/Nic, on the grade export form, should we have Select all/Deselect all links in the Grade items to be included section?
[14:44:02] Petr Skoda (skodak) says: the select all/none is not yet part of formslib I think
[14:44:20] Petr Skoda (skodak) says: changes in cvs, please update
[14:44:55] Nicolas Connault says: Mhh I could imagine an extra param to the advcheckbox element constructor: $select_group
[14:45:02] Tim Hunt says: Yes, but there is a very generic JS function for doing it in the Moodle libraries, outside formslib, so it would not be hard to add. Maybe I should just stick the idea in the tracker for now.
[14:45:51] Petr Skoda (skodak) says: I implemented something similar in the new coruse reset - it resets the form completely and fills it with some defaults based on clicked button
[14:46:26] Nicolas Connault says: Then a "select all/ select none" links combo element, named after the $select_group
[14:46:40] Nicolas Connault says: this way you could have several multi-selection groups of checkboxes on one page
[14:46:44] Petr Skoda (skodak) says: yes Nicolas - that sounds good
[14:46:54] Tim Hunt says: Yep, that sounds like a good design.
[14:47:18] Tim Hunt says: Alternatively, a single form control that implements a list of checkbox items.
[14:47:27] Nicolas Connault says: I'll take care of it if you want to write and assign the issue
[14:47:35] Petr Skoda (skodak) says: I want more time for all these nice ideas! :@
[14:47:47] Tim Hunt says: OK, I'll file an issue and assign it to Nic.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Dec/07 12:42 AM
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
MODIFY lib/formslib.php   Rev. 1.129.2.7    (+3 -2 lines)
MODIFY lib/Attic/javascript.php   Rev. 1.36.2.1    (+30 -1 lines)
MODIFY grade/export/grade_export_form.php   Rev. 1.27.2.3    (+18 -4 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 04/Dec/07 12:42 AM
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
MODIFY lang/en_utf8/form.php   Rev. 1.18    (+3 -1 lines)
Nicolas Connault committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Dec/07 12:42 AM
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
MODIFY lib/form/Attic/selectallornone.php   Rev. 1.1.2.1    (+126 -0 lines)
MODIFY lib/form/advcheckbox.php   Rev. 1.9.2.1    (+36 -1 lines)
MODIFY lib/grade/grade_category.php   Rev. 1.96.2.10    (+2 -2 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 04/Dec/07 03:48 AM
Translated new string for form MDL-12389.
Brushed up translated strings for forum.
Brushed up translated strings for lesson.
MODIFY ja_utf8/form.php   Rev. 1.19    (+2 -1 lines)
MODIFY ja_utf8/lesson.php   Rev. 1.64    (+4 -4 lines)
MODIFY ja_utf8/block_search_forums.php   Rev. 1.3    (+2 -2 lines)
MODIFY ja_utf8/forum.php   Rev. 1.50    (+1 -1 lines)
MODIFY ja_utf8/README   Rev. 1.584    (+1 -1 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Dec/07 05:07 AM
MDL-12389 Removed testing code
MODIFY grade/export/grade_export_form.php   Rev. 1.27.2.4    (+1 -10 lines)
Nicolas Connault committed 6 files to 'Moodle CVS' - 04/Dec/07 05:13 AM
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
MODIFY grade/export/grade_export_form.php   Rev. 1.30    (+8 -4 lines)
MODIFY lib/Attic/javascript.php   Rev. 1.37    (+30 -1 lines)
MODIFY lib/form/advcheckbox.php   Rev. 1.10    (+35 -0 lines)
MODIFY lib/formslib.php   Rev. 1.137    (+3 -2 lines)
MODIFY Attic/tags   Rev. 1.50    (+61609 -13330 lines)
MODIFY lib/form/Attic/selectallornone.php   Rev. 1.2    (+126 -0 lines)
Nicolas Connault committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Dec/07 07:27 PM
MDL-12389 Removed the selectallornone element in favour of a more generic submitlink element. The checkbox controller is now added to a form using moodleform::add_checkbox_controller.
MODIFY lib/formslib.php   Rev. 1.129.2.8    (+78 -5 lines)
MODIFY lib/form/submitlink.php   Rev. 1.1.2.1    (+18 -0 lines)
MODIFY grade/export/grade_export_form.php   Rev. 1.27.2.5    (+3 -3 lines)
MODIFY lib/form/advcheckbox.php   Rev. 1.9.2.2    (+0 -7 lines)
MODIFY lib/pear/HTML/QuickForm/element.php   Rev. 1.1.12.1    (+2 -2 lines)
Nicolas Connault committed 4 files to 'Moodle CVS' - 04/Dec/07 07:35 PM
MDL-12389 Removed the selectallornone element in favour of a more generic submitlink element. The checkbox controller is now added to a form using moodleform::add_checkbox_controller.
MODIFY lib/form/submitlink.php   Rev. 1.2    (+18 -0 lines)
MODIFY lib/formslib.php   Rev. 1.138    (+78 -5 lines)
MODIFY lib/form/advcheckbox.php   Rev. 1.11    (+0 -7 lines)
MODIFY grade/export/grade_export_form.php   Rev. 1.31    (+3 -3 lines)
martignoni committed 1 file to 'Lang CVS' - 05/Dec/07 04:18 AM
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
MODIFY fr_utf8/form.php   Rev. 1.21    (+2 -1 lines)