Moodle

Tim,
In the preceding 1.6 and 1.7 if the options->feedback is on , the feedback (if any) is displayed but the answer text or choice is not colored or anything.
The $option->correct_responses control the coloring (if any) of the answer

if (!empty($chosenanswer) && $options->correct_responses) {

In 1.8 and 1.9 when the $options->feedback is on , the feedback (if any) is displayed as the check image and the coloring of the answer if the response != ''.
in multichoice the code is
if (($options->feedback && $chosen) || $options->correct_responses) { $a->feedbackimg = question_get_feedback_image($answer->fraction > 0 ? 1 : 0, $chosen && $options->feedback); }
in multianswer
if ($options->feedback && $response != '') {
This was changed for multianswer when you worked on MDL-9208

In multianswer, this is more significant because only the total grade is shown and the feedback is not shown until you put the mouse near the answer.
I think it should be set for 1.7 (and 1.6 UQAM!! and the others).
I understand that this means a good testing before putting in STABLE old versions.
But I have done more complex things in calculated question type.

I can't remember why I did not port my changes back to previous stable versions that Moodle 1.8. I think the reason was that I was mostly correcting some bugs that were introduced during the accessibility changes in Moodle 1.8, therefore, not all my changes were relevant to older branches.

There is the whole question of whether you should implement new features on the stable branches. It is a trade-off between making things better, and not changing existing behaviour that people are used to without warning.

I will change it first on multianswer because it is very useful for this question type, for 1.7 and 1.6 mostly because UQAM is on 1.6
I can change it because this the way this is described in the docs and because of the forum question.

I will first test all combinations (feedback, answers, general feedback etc.) for all standard question types.
report the results and suggest code corrections.
Some of them were set correctly from 1.8 others not.
I will see down to 1.6 as usual...
Will modify the version settings when the tests will be completed.

Tim,
Should the options feedback, answers, general feedback etc. be independent from each others even if this seems special i.e. correct answers without feedback?
This is not the actual way although the check buttons on the quiz settings suggests that they are independent settings.

They are not completely independent, there is necessarily some dependency between some of them. However, there should not be unnecessary dependencies.

The docs are

Students may review (see) their own Responses, the Scores for their responses, the Feedback from the teacher (if any) or the correct Answers or a General feedback. For each of these items you can choose whether the student should be able to see them immediately after the attempt, later but while the quiz is still open or after the quiz is closed.
and
Currently, the "Answers" shown to students work differently depending on the question type in a particular quiz. If the question type used is 'matching' then students get to see which of their responses are in fact correct answers. If the question type used is 'short answer' then students see their responses plus all correct answers to all questions.

Responses imply nothing else

Scores for their responses imply Responses

Feedback imply Scores and Responses

General feedback imply Feedback , Scores and Responses

Answers imply Scores and Responses but not necessarily the Feedbacks.
If the question type used is
'short answer' then students see their response plus all correct answers to each question.
'numerical' (which use 'short answer' interface ) then students see their response , because of the tolerance the Correct
Response should be shown(with the tolerance) even when the student response is good. Actually the correct response is not
shown if the score is 100%.
'calculated ' (which uses 'numerical' so 'short answer' interface ) should display the correct and the Tolerance.
'match' and 'multichoice' then students get to see which of their responses are in fact correct answers and the other correct responses . This is the actual display.

The 'cloze' display as to follow these rules which is not the case actually asfor example there is no individual score.

Do you agree with these rules?
On the forum some are asking that the partial answers ( not 100%) be shown for 'short answer' and similar types.

I think that the new question engine effectively resolved this.