[#MDL-12453] All group members are backed up, not just "backupable" ones

Issue Details (XML | Word | Printable)

Key:	MDL-12453
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Eloy Lafuente (stronk7)
Reporter:	Nick Freear
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13847

All group members are backed up, not just "backupable" ones

Created: 06/Dec/07 02:21 AM Updated: 15/Apr/08 04:45 PM

Return to search

Component/s:

Backup

Affects Version/s:

1.8.4, 1.9

Fix Version/s:

1.8.5, 1.9.1

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-2674~~ backup always backsup/restores groups regardless of user settings

Participants:	Eloy Lafuente (stronk7), Nick Freear and Petr Skoda
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	10/Mar/08
Affected Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

... pontentially leading to orphans. (From Skype discussion with Eloy.)
backup/backuplib.php - backup_groups_members_info function does a simple get_records('groups_members' ...)
Compare with, SQL in backup_user_info.

TODO: link ~~MDL-2674~~.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 10/Mar/08 02:34 AM

Done. I had this in my 19_STABLE branch (uncommitted) . Ciao

[ Permalink | « Hide ]

Petr Skoda added a comment - 15/Apr/08 04:44 PM

patch reviewed, closing, thanks

All content on this web site is made available under the GNU General Public License, unless otherwise stated.