Issue Details (XML | Word | Printable)

Key: MDL-12453
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Nick Freear
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13847

All group members are backed up, not just "backupable" ones

Created: 06/Dec/07 02:21 AM   Updated: 15/Apr/08 04:45 PM
Return to search
Component/s: Backup
Affects Version/s: 1.8.4, 1.9
Fix Version/s: 1.8.5, 1.9.1

Issue Links:
Relates
 

Participants: Eloy Lafuente (stronk7), Nick Freear and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 10/Mar/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
... pontentially leading to orphans. (From Skype discussion with Eloy.)
backup/backuplib.php - backup_groups_members_info function does a simple get_records('groups_members' ...)
Compare with, SQL in backup_user_info.

TODO: link MDL-2674.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear made changes - 06/Dec/07 02:22 AM
Field Original Value New Value
Link This issue has a non-specific relationship to MDL-2674 [ MDL-2674 ]
Petr Skoda made changes - 09/Mar/08 09:42 PM
Parent MDL-13847 [ 25343 ]
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Petr Skoda made changes - 09/Mar/08 09:42 PM
Assignee Martin Dougiamas [ dougiamas ] Petr Skoda [ skodak ]
Eloy Lafuente (stronk7) made changes - 10/Mar/08 01:16 AM
Assignee Petr Skoda [ skodak ] Eloy Lafuente (stronk7) [ stronk7 ]
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Mar/08 02:26 AM
Ensure only target groups_members are added to backup. MDL-12453
MODIFY backup/backuplib.php   Rev. 1.179.2.20    (+8 -3 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 10/Mar/08 02:28 AM
Ensure only target groups_members are added to backup. MDL-12453 ; merged from 19_STABLE
MODIFY backup/backuplib.php   Rev. 1.200    (+8 -3 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 10/Mar/08 02:33 AM
Ensure only target groups_members are added to backup. MDL-12453 ; backported from HEAD
MODIFY backup/backuplib.php   Rev. 1.135.2.10    (+9 -4 lines)
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 10/Mar/08 02:34 AM
Done. I had this in my 19_STABLE branch (uncommitted) . Ciao

Eloy Lafuente (stronk7) made changes - 10/Mar/08 02:34 AM
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.9.1 [ 10240 ]
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.8.5 [ 10252 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) made changes - 10/Mar/08 02:37 AM
Affects Version/s 1.8.4 [ 10242 ]
Petr Skoda made changes - 15/Apr/08 04:44 PM
Affects Version/s 2.0 [ 10122 ]
Fix Version/s 2.0 [ 10122 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 15/Apr/08 04:44 PM
patch reviewed, closing, thanks

Petr Skoda made changes - 15/Apr/08 04:44 PM
Status Resolved [ 5 ] Closed [ 6 ]
Petr Skoda made changes - 15/Apr/08 04:45 PM
QA Assignee skodak

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators