Details
Bug
Description
When a new assignment is created with a maximum grade of "no grade", it does not appear in the gradebook. However, when you change this item to have a value for maximum grade it does appear as a gradebook item, and it continues to be a gradebook item if you re-assign it to no grade.
The correct behavior is to have it be a gradebook item even if "no grade" is set upon creation. It will simply play no role in a computation. Otherwise it will (and has) caused teachers much confusion when the believe that some of their assignments have been lost in the gradebook.
It is not uncommon to have an assignment listed as no-grade to be a place holder until the teacher adjusts that assignment the number of points desired. So the behavior suggested is important. But in any case, the current behavior is inconsistent regardless of ones view of whether assignments with not grade should be listed.
Attachments
Issue Links
| This issue is blocked by: | ||||
| MDL-18770 | Non-graded Assignment and Quizzes appear in the gradebook and have Max Grade assigned |
|
|
|
| This issue has a non-specific relationship to: | ||||
| MDL-18353 | If you create a graded activity and later changed it to a non-graded activity (no grade), this activity still appears as an item in the gradebook |
|
|
|
| MDL-12637 | New gradebook tweaks - meta |
|
|
|
This issue is because of lines 120 to 123 of lib/gradelib.php.
In my view and for the reasons described above, these lines should be removed.
if ($k == 'gradetype' and $v == GRADE_TYPE_NONE) { // no grade item needed! return GRADE_UPDATE_OK; }
To summarize:
1. It is confusing when activities don't appear in the gradebook (in the field, teachers report missing items)
2. No grade might be temporary
3. There is inconsistency in changing back and forth between max grades
4. There is no adverse effect on computations of keeping the grade item in
5. The teacher can always hide the grade item from students if s/he wishes