Moodle

Advanced search in full report of recent activity displays users from all separated groups

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.2
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Steps to reproduce:
============
1. put a course into separated groups mode
2. create two groups BOYS and GIRLS
3. add users Boy1 and Boy2 into BOYS, add Girl1 and Girl2 into GIRLS
4. log in as Boy1
5. go to Full report of recent activity and select Advanced search
6. check the field Participants

What I expected:
===========
As the mode is set to separated groups for both course and module, I should see only users from my group, i.e. Boy1 and Boy2

What happened:
===========
I can see all users in the course - even the members of GIRLS

Activity

Hide
David Mudrak added a comment -

I am starting to work on this as a part of my Bugathon run

Show
David Mudrak added a comment - I am starting to work on this as a part of my Bugathon run
Hide
David Mudrak added a comment -

both issues have problem with SEPARATEGROUPS mode

Show
David Mudrak added a comment - both issues have problem with SEPARATEGROUPS mode
Hide
David Mudrak added a comment -

See the attached MDL-12505.patch.txt for a quite restrictive solution. In theory, we should check if there is an activity where the two users can meet each other. But as Advanced search of recent activity is not key feature for a student, we can leave it now. Anyway, if we wanted really proper solution, we would need to almost copy user/index.php :-/

Show
David Mudrak added a comment - See the attached MDL-12505.patch.txt for a quite restrictive solution. In theory, we should check if there is an activity where the two users can meet each other. But as Advanced search of recent activity is not key feature for a student, we can leave it now. Anyway, if we wanted really proper solution, we would need to almost copy user/index.php :-/
Hide
Dan Poltawski added a comment -

Assigning this issue to Petr as I think hes most familiar with the 1.9 groups

Its quite easy to hit this by just hitting Full report of recent activity on the recent activity block.. Also, the linked MDL-11911 seems mostly fully of 1.8 issues resolved in 1.9, but they are quite serious flaws in seperate groups mode.

Show
Dan Poltawski added a comment - Assigning this issue to Petr as I think hes most familiar with the 1.9 groups Its quite easy to hit this by just hitting Full report of recent activity on the recent activity block.. Also, the linked MDL-11911 seems mostly fully of 1.8 issues resolved in 1.9, but they are quite serious flaws in seperate groups mode.
Hide
Petr Škoda (skodak) added a comment -

I have rewritten the advanced search code a bit, it should be fixed now
thanks for the report!

Show
Petr Škoda (skodak) added a comment - I have rewritten the advanced search code a bit, it should be fixed now thanks for the report!
Hide
Eloy Lafuente (stronk7) added a comment -

Helen, could you, plz, try to reproduce the problem and check if it's fixed, closing if ok? TIA!

Show
Eloy Lafuente (stronk7) added a comment - Helen, could you, plz, try to reproduce the problem and check if it's fixed, closing if ok? TIA!
Hide
Helen Foster added a comment -

Reopening, as although users can only see other users in their group on the participants page, they can still select all participants or users in a different group in the recent activity advanced search.

Show
Helen Foster added a comment - Reopening, as although users can only see other users in their group on the participants page, they can still select all participants or users in a different group in the recent activity advanced search.
Hide
Petr Škoda (skodak) added a comment -

should be finally fixed now

Show
Petr Škoda (skodak) added a comment - should be finally fixed now

People

Dates

  • Created:
    Updated:
    Resolved: