[#MDL-12505] Advanced search in full report of recent activity displays users from all separated groups

Moodle

MDL-14113

Advanced search in full report of recent activity displays users from all separated groups

Created: 08/Dec/07 06:49 PM Updated: 06/Jul/08 04:58 AM

Component/s:

Forum

Affects Version/s:

1.9

Fix Version/s:

1.9.2

File Attachments:

MDL-12505.patch.txt (2 kb)

Participants:	Dan Poltawski, David Mudrak, Eloy Lafuente (stronk7), Helen Foster and Petr Škoda
Security Level:	None
QA Assignee:	Helen Foster

Description

« Hide

Steps to reproduce:
============
1. put a course into separated groups mode
2. create two groups BOYS and GIRLS
3. add users Boy1 and Boy2 into BOYS, add Girl1 and Girl2 into GIRLS
4. log in as Boy1
5. go to Full report of recent activity and select Advanced search
6. check the field Participants

What I expected:
===========
As the mode is set to separated groups for both course and module, I should see only users from my group, i.e. Boy1 and Boy2

What happened:
===========
I can see all users in the course - even the members of GIRLS

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

David Mudrak - 08/Dec/07 06:50 PM

I am starting to work on this as a part of my Bugathon run

[ Permlink | « Hide ]

David Mudrak - 08/Dec/07 06:51 PM

both issues have problem with SEPARATEGROUPS mode

[ Permlink | « Hide ]

David Mudrak - 10/Dec/07 07:28 AM

See the attached ~~MDL-12505~~.patch.txt for a quite restrictive solution. In theory, we should check if there is an activity where the two users can meet each other. But as Advanced search of recent activity is not key feature for a student, we can leave it now. Anyway, if we wanted really proper solution, we would need to almost copy user/index.php :-/

[ Permlink | « Hide ]

Dan Poltawski - 30/Dec/07 07:42 PM

Assigning this issue to Petr as I think hes most familiar with the 1.9 groups ;-)

Its quite easy to hit this by just hitting Full report of recent activity on the recent activity block.. Also, the linked ~~MDL-11911~~ seems mostly fully of 1.8 issues resolved in 1.9, but they are quite serious flaws in seperate groups mode. :(

[ Permlink | « Hide ]

Petr Škoda - 14/Apr/08 04:06 PM

I have rewritten the advanced search code a bit, it should be fixed now
thanks for the report!

[ Permlink | « Hide ]

Eloy Lafuente (stronk7) - 16/Apr/08 07:36 AM

Helen, could you, plz, try to reproduce the problem and check if it's fixed, closing if ok? TIA!

[ Permlink | « Hide ]

Helen Foster - 22/Apr/08 10:11 PM

Reopening, as although users can only see other users in their group on the participants page, they can still select all participants or users in a different group in the recent activity advanced search.

[ Permlink | « Hide ]

Petr Škoda - 06/Jul/08 04:58 AM

should be finally fixed now :-)