[#MDL-12505] Advanced search in full report of recent activity displays users from all separated groups

Issue Details (XML | Word | Printable)

Key:	MDL-12505
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	David Mudrak
Votes:	0
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14113

Advanced search in full report of recent activity displays users from all separated groups

Created: 08/Dec/07 06:49 PM Updated: 06/Jul/08 04:58 AM

Return to search

Component/s:

Forum

Affects Version/s:

1.9

Fix Version/s:

1.9.2

File Attachments:

MDL-12505.patch.txt (2 kB)

Participants:	Dan Poltawski, David Mudrak, Eloy Lafuente (stronk7), Helen Foster and Petr Skoda
Security Level:	None
QA Assignee:	Helen Foster
Resolved date:	06/Jul/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Steps to reproduce:
============
1. put a course into separated groups mode
2. create two groups BOYS and GIRLS
3. add users Boy1 and Boy2 into BOYS, add Girl1 and Girl2 into GIRLS
4. log in as Boy1
5. go to Full report of recent activity and select Advanced search
6. check the field Participants

What I expected:
===========
As the mode is set to separated groups for both course and module, I should see only users from my group, i.e. Boy1 and Boy2

What happened:
===========
I can see all users in the course - even the members of GIRLS

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

David Mudrak added a comment - 08/Dec/07 06:50 PM

I am starting to work on this as a part of my Bugathon run

David Mudrak made changes - 08/Dec/07 06:51 PM

Field	Original Value	New Value
Link		This issue has a non-specific relationship to MDL-11911 [ MDL-11911 ]

[ Permalink | « Hide ]

David Mudrak added a comment - 08/Dec/07 06:51 PM

both issues have problem with SEPARATEGROUPS mode

[ Permalink | « Hide ]

David Mudrak added a comment - 10/Dec/07 07:28 AM

See the attached ~~MDL-12505~~.patch.txt for a quite restrictive solution. In theory, we should check if there is an activity where the two users can meet each other. But as Advanced search of recent activity is not key feature for a student, we can leave it now. Anyway, if we wanted really proper solution, we would need to almost copy user/index.php :-/

David Mudrak made changes - 10/Dec/07 07:28 AM

Attachment

MDL-12505.patch.txt [ 12599 ]

[ Permalink | « Hide ]

Dan Poltawski added a comment - 30/Dec/07 07:42 PM

Assigning this issue to Petr as I think hes most familiar with the 1.9 groups

Its quite easy to hit this by just hitting Full report of recent activity on the recent activity block.. Also, the linked MDL-11911 seems mostly fully of 1.8 issues resolved in 1.9, but they are quite serious flaws in seperate groups mode.

Dan Poltawski made changes - 30/Dec/07 07:42 PM

Assignee

Martin Dougiamas [ dougiamas ]

Petr Skoda [ skodak ]

Petr Skoda made changes - 31/Mar/08 03:45 PM

Parent		~~MDL-14113~~ [ 25649 ]
Issue Type	Bug [ 1 ]	Sub-task [ 5 ]
Security	Minor security issue [ 10001 ]

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 14/Apr/08 04:04 PM

~~MDL-12505~~ general advanced search cleanup + added capability test to recent activity

MODIFY

mod/forum/lib.php

Rev. 1.609.2.48

(+107 -119 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 14/Apr/08 04:05 PM

~~MDL-12505~~ general advanced search cleanup + added capability test to recent activity; merged from MOODLE_19_STABLE

MODIFY

mod/forum/lib.php

Rev. 1.658

(+108 -120 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 14/Apr/08 04:06 PM

I have rewritten the advanced search code a bit, it should be fixed now
thanks for the report!

Petr Skoda made changes - 14/Apr/08 04:06 PM

Fix Version/s		1.9.1 [ 10240 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 16/Apr/08 07:36 AM

Helen, could you, plz, try to reproduce the problem and check if it's fixed, closing if ok? TIA!

Eloy Lafuente (stronk7) made changes - 16/Apr/08 07:36 AM

QA Assignee

tsala

[ Permalink | « Hide ]

Helen Foster added a comment - 22/Apr/08 10:11 PM

Reopening, as although users can only see other users in their group on the participants page, they can still select all participants or users in a different group in the recent activity advanced search.

Helen Foster made changes - 22/Apr/08 10:11 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Martin Dougiamas made changes - 15/May/08 03:02 PM

Fix Version/s		1.9.2 [ 10280 ]
Fix Version/s	1.9.1 [ 10240 ]

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 06/Jul/08 04:57 AM

~~MDL-12505~~ do not leak separate groups info in advanced search user selection and other fixes

MODIFY	course/recent_form.php		Rev. 1.1.2.2		(+8 -1 lines)
MODIFY	course/recent.php		Rev. 1.34.2.3		(+13 -12 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 06/Jul/08 04:57 AM

~~MDL-12505~~ do not leak separate groups info in advanced search user selection and other fixes; merged from MOODLE_19_STABLE

MODIFY	course/recent.php		Rev. 1.40		(+13 -12 lines)
MODIFY	course/recent_form.php		Rev. 1.3		(+8 -1 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 06/Jul/08 04:58 AM

should be finally fixed now

Petr Skoda made changes - 06/Jul/08 04:58 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.