[#MDL-12570] add option to disable lang autodetect from browsers

Issue Details (XML | Word | Printable)

Key:	MDL-12570
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Robert Brenstein
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

add option to disable lang autodetect from browsers

Created: 14/Dec/07 12:59 AM Updated: 16/Dec/07 12:05 AM

Return to search

Component/s:

Languages

Affects Version/s:

1.9

Fix Version/s:

1.9, 2.0

Issue Links:

Duplicate

This issue duplicates:

~~MDL-11243~~ Admin settable default language for front page

Participants:	Koen Roggemans, Petr Skoda and Robert Brenstein
Security Level:	None
Resolved date:	15/Dec/07
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

A Moodle site is configured with "Force users to login" on. Default language is set to German. English and American are also available in the language popup menu. When one comes to the site for the first time from a given computer, the login page displays in English instead of German. The same if user logs out . Regardless of the user or session language in effect, the login page shows always in English. One has to use the popup menu to switch to German.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Robert Brenstein added a comment - 14/Dec/07 01:01 AM

I should add that this works fine in Moodle 1.6 and 1.8 on the same server and client computers, so it must be a glitch in 1.9 (beta 3).

[ Permalink | « Hide ]

Robert Brenstein added a comment - 14/Dec/07 01:04 AM

Just tested with "Force users to login" off. The same problem - the home page shows always in English upon the first visit or log out.

[ Permalink | « Hide ]

Koen Roggemans added a comment - 14/Dec/07 04:24 PM

Moodle detects the browser language setting. Regardless if that is good or bad, can that explain the behaviour you notice?

[ Permalink | « Hide ]

Robert Brenstein added a comment - 14/Dec/07 06:48 PM

Yes, I just tested that this seems indeed the case. So, the bug is with the mode of implementation. Instead of this being a stealth feature, the site default language setup should have a new option, detect browser language, so Moodle's behavior is predictable.

I believe the correct implementation would be to have a checkbox "detect browser language" next to the default language popup. If the checkbox is marked, Moodle should try to assert the browser language, and if it fails, use the language selected as default. If the checkbox is not marked, Moodle should use the language set in the popup.

[ Permalink | « Hide ]

Petr Skoda added a comment - 15/Dec/07 08:54 PM

new option in cvs, see admin tree/Language settings
thanks for the report

All content on this web site is made available under the GNU General Public License, unless otherwise stated.