Issue Details (XML | Word | Printable)

Key: MDL-12570
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Robert Brenstein
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

add option to disable lang autodetect from browsers

Created: 14/Dec/07 12:59 AM   Updated: 16/Dec/07 12:05 AM
Return to search
Component/s: Languages
Affects Version/s: 1.9
Fix Version/s: 1.9, 2.0

Issue Links:
Duplicate
 

Participants: Koen Roggemans, Petr Skoda and Robert Brenstein
Security Level: None
Resolved date: 15/Dec/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
A Moodle site is configured with "Force users to login" on. Default language is set to German. English and American are also available in the language popup menu. When one comes to the site for the first time from a given computer, the login page displays in English instead of German. The same if user logs out . Regardless of the user or session language in effect, the login page shows always in English. One has to use the popup menu to switch to German.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Robert Brenstein added a comment - 14/Dec/07 01:01 AM
I should add that this works fine in Moodle 1.6 and 1.8 on the same server and client computers, so it must be a glitch in 1.9 (beta 3).

[ Permalink | « Hide ]
Robert Brenstein added a comment - 14/Dec/07 01:04 AM
Just tested with "Force users to login" off. The same problem - the home page shows always in English upon the first visit or log out.

[ Permalink | « Hide ]
Koen Roggemans added a comment - 14/Dec/07 04:24 PM
Moodle detects the browser language setting. Regardless if that is good or bad, can that explain the behaviour you notice?

[ Permalink | « Hide ]
Robert Brenstein added a comment - 14/Dec/07 06:48 PM
Yes, I just tested that this seems indeed the case. So, the bug is with the mode of implementation. Instead of this being a stealth feature, the site default language setup should have a new option, detect browser language, so Moodle's behavior is predictable.

I believe the correct implementation would be to have a checkbox "detect browser language" next to the default language popup. If the checkbox is marked, Moodle should try to assert the browser language, and if it fails, use the language selected as default. If the checkbox is not marked, Moodle should use the language set in the popup.


Petr Skoda made changes - 15/Dec/07 08:28 PM
Field Original Value New Value
Assignee Koen Roggemans [ koen ] Petr Skoda [ skodak ]
Petr Skoda committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 15/Dec/07 08:48 PM
MDL-12570 option to disable lang autodetect from browser
MODIFY lib/moodlelib.php   Rev. 1.960.2.16    (+3 -3 lines)
MODIFY admin/settings/language.php   Rev. 1.7.4.2    (+2 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.15    (+2 -0 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 15/Dec/07 08:49 PM
MDL-12570 option to disable lang autodetect from browser; merged from MOODLE_19_STABLE
MODIFY admin/settings/language.php   Rev. 1.9    (+2 -1 lines)
Petr Skoda made changes - 15/Dec/07 08:53 PM
Fix Version/s 2.0 [ 10122 ]
Summary site default language ignored on the login page add option to disable lang autodetect from browsers
Fix Version/s 1.9 [ 10190 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 15/Dec/07 08:54 PM
new option in cvs, see admin tree/Language settings
thanks for the report

Petr Skoda made changes - 15/Dec/07 08:54 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 2 files to 'Moodle CVS' - 15/Dec/07 10:28 PM
MDL-12570 option to disable lang autodetect from browser; merged from MOODLE_19_STABLE
MODIFY lang/en_utf8/admin.php   Rev. 1.169    (+2 -0 lines)
MODIFY lib/moodlelib.php   Rev. 1.976    (+3 -3 lines)
martignoni committed 1 file to 'Lang CVS' - 15/Dec/07 11:49 PM
MDL-12570 option to disable lang autodetect from browser
MODIFY fr_utf8/admin.php   Rev. 1.215    (+3 -1 lines)
Iñaki Arenaza made changes - 16/Dec/07 12:05 AM
Link This issue duplicates MDL-11243 [ MDL-11243 ]
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 16/Dec/07 05:06 AM
Translated new strings for admin lang autodetect - MDL-12570.
Brushed up a translated help file for course enrolment period.
MODIFY ja_utf8/admin.php   Rev. 1.222    (+3 -1 lines)
MODIFY ja_utf8/README   Rev. 1.594    (+1 -1 lines)
MODIFY ja_utf8/help/enrolperiod.html   Rev. 1.7    (+3 -3 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators