Moodle

Global search lang file in wrong location

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.3
  • Fix Version/s: 1.8.6
  • Component/s: Global search
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

In Moodle 1.8.3+ the global search language files are in /search/lang. The English one should be moved to /lang/en_utf8 and the other translations should be moved to their appropriate language packs. Lastly, the /search/lang directory should be removed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Valery Fremaux added a comment -

Mark, I am aware Nicolas Martignoni did it for the fr_utf8 file, I known also it's OK for the en_utf8, could we check fot the nl_utf8 ? Who is in charge of the Dutch langage pack ? Could we tell him about checking nl_utf8 file ?

Thanks.
I will be OK for deleting this subtree.

Show
Valery Fremaux added a comment - Mark, I am aware Nicolas Martignoni did it for the fr_utf8 file, I known also it's OK for the en_utf8, could we check fot the nl_utf8 ? Who is in charge of the Dutch langage pack ? Could we tell him about checking nl_utf8 file ? Thanks. I will be OK for deleting this subtree.
Hide
Permalink
Mark Nielsen added a comment -

I think Koen Roggemans maintains the nl_utf8 language pack. Looks like the search.php lang file already in there: http://cvs.moodle.org/lang/nl_utf8/

Show
Mark Nielsen added a comment - I think Koen Roggemans maintains the nl_utf8 language pack. Looks like the search.php lang file already in there: http://cvs.moodle.org/lang/nl_utf8/
Hide
Permalink
Mark Nielsen added a comment -

Also, this line in the lang file causes a PHP error:

$string['versiontoolow'] = 'Sorry, global search requires PHP 5.0.0 or later (currently using version '.$phpversion.')';

Have to pass the php version to the get_string method and then change the above to:

$string['versiontoolow'] = 'Sorry, global search requires PHP 5.0.0 or later (currently using version $a)';

Show
Mark Nielsen added a comment - Also, this line in the lang file causes a PHP error: $string['versiontoolow'] = 'Sorry, global search requires PHP 5.0.0 or later (currently using version '.$phpversion.')'; Have to pass the php version to the get_string method and then change the above to: $string['versiontoolow'] = 'Sorry, global search requires PHP 5.0.0 or later (currently using version $a)';
Hide
Permalink
Valery Fremaux added a comment -

Fixed by deleting all lang files and pruning the 18_STABLE branch.

Could you tell me it seems OK so I close the issue ?
I will fix other branches in the meanwhile.

Show
Valery Fremaux added a comment - Fixed by deleting all lang files and pruning the 18_STABLE branch. Could you tell me it seems OK so I close the issue ? I will fix other branches in the meanwhile.
Hide
Permalink
Mark Nielsen added a comment -

I don't see the search.php file in lang/en_utf8 for MOODLE_18_STABLE. The search/lang directory has been removed.

I do see the search.php lang file in MOODLE_19_STABLE though. Looks like Yu added it (See MDL-12234)

Show
Mark Nielsen added a comment - I don't see the search.php file in lang/en_utf8 for MOODLE_18_STABLE. The search/lang directory has been removed. I do see the search.php lang file in MOODLE_19_STABLE though. Looks like Yu added it (See MDL-12234)
Hide
Permalink
Valery Fremaux added a comment -

Do u think we could close this one ?

Show
Valery Fremaux added a comment - Do u think we could close this one ?
Hide
Permalink
Petr Škoda (skodak) added a comment -

I guess this was already fixed, right?
please reopen if needed, thanks!

Show
Petr Škoda (skodak) added a comment - I guess this was already fixed, right? please reopen if needed, thanks!
Hide
Permalink
Valery Fremaux added a comment -

Closing for the moment.

Show
Valery Fremaux added a comment - Closing for the moment.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.