Issue Details (XML | Word | Printable)

Key: MDL-12595
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Mathieu Petit-Clair
Reporter: Dan Poltawski
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13404

Make it possible to use numeric tags

Created: 16/Dec/07 09:45 AM   Updated: 14/Oct/09 02:22 PM
Return to search
Component/s: Tags
Affects Version/s: 1.9
Fix Version/s: 1.9

Issue Links:
Duplicate
 

Participants: Dan Poltawski, Martin Dougiamas, Mathieu Petit-Clair and Rossiani Wijaya
Security Level: None
Resolved date: 22/Feb/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Numeric tags cause havoc because the tags code tries to guess what is a tag and an id. This means if a user enters tags: apple, pear, 2 then 2 will be converted to the tag with that id rather than the number.


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Poltawski added a comment - 16/Dec/07 09:47 AM
And the problems with MDL-12316 as floats..

I dont think its desirable to guess the id/tag like this. Also we have a problem of performance as dbq has to be done for each of these tags like that.


Mathieu Petit-Clair added a comment - 07/Feb/08 11:44 AM
My current plan is to remove all external use of numeric IDs (read: database primary key), except for a specific path, as per Martin's suggestion. This path will only accept the key. The rest will work like del.icio.us : urlencoded utf8 tags, which makes it possible to use numbers or any character. This does dramatically decrease the number of queries, as the ID is read only once and we won't have to figure out if we're dealing with a tag or with an id.

As about every function in /tag/lib.php accepts either, there is significant work (and tests...) to be done before I can commit this. Don't know if it will make it into 1.9... but as there won't be any database change, I guess it should..


Mathieu Petit-Clair added a comment - 22/Feb/08 07:36 PM
This is now possible.. as is using any unicode character (except the "," as it's the separator).

Martin Dougiamas added a comment - 04/Mar/08 01:01 PM
Fixing the version information for this bug.

Rossiani Wijaya added a comment - 14/Oct/09 02:22 PM
Tested and work.

Resolved

Closing