Moodle

Time up navigation and warning message are incorrect

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8.3
  • Fix Version/s: 1.8.4, 1.9
  • Component/s: Language, Lesson
  • Labels:
    None
  • Environment:
    any en_utf8
  • Database:
    Any
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

The message displayed when a lesson activity has timed out is incorrect.

Message reads:

Attention: You ran out of time for this lesson. Your last answer does not count because it was answered after the time was up. Please push the continue button to finish the lesson.

There is no "Continue" button on that page (although there is a continue link on the page before this message is displayed).

If the "Return to Lesson" button is clicked the user is returned to the course page and not not the lesson.

Furthermore, the lesson appears to be ended once the time is up - this is at odds with the description of what happens in the "Timed" help file..

"Due to the inconsistent nature of JavaScript, the timer does not evict a student from the lesson when the time is up, however a question answered after the time limit is not counted"

Issue Links

This issue has been marked as being related by:
MDL-6645 Having only a HEAD version for language packs causes major problems and inconsistencies Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ray Lawrence added a comment -

Koen,

I've re-assigned this to Mark. I tagged with languages as there may be interface/help file issues

Show
Ray Lawrence added a comment - Koen, I've re-assigned this to Mark. I tagged with languages as there may be interface/help file issues
Hide
Permalink
Koen Roggemans added a comment -

Thanks Ray.
I added Helen as watcher too so she can check if any English language/documentation issues arise.

Show
Koen Roggemans added a comment - Thanks Ray. I added Helen as watcher too so she can check if any English language/documentation issues arise.
Hide
Permalink
Ray Lawrence added a comment -

Ok, adding Helen as watcher on 3487 too.

Show
Ray Lawrence added a comment - Ok, adding Helen as watcher on 3487 too.
Hide
Permalink
Mark Nielsen added a comment -

> Attention: You ran out of time for this lesson. Your last answer does not count because it was answered after the time was up. Please push the continue button to finish the lesson.

This message has been fixed. Does an immediate redirect now as well.

> If the "Return to Lesson" button is clicked the user is returned to the course page and not not the lesson.

Is your course named "Lesson"? There is a button at the bottom on the End of Lesson page that returns you to your course ("Return to COURSE_NAME").

>Furthermore, the lesson appears to be ended once the time is up - this is at odds with the description of what happens in the "Timed" help file..

The help file is saying that the JavaScript will not perform an automatic redirect when time is up. The lesson is however ended whenever the user navigates to a new page after the time is up.

Show
Mark Nielsen added a comment - > Attention: You ran out of time for this lesson. Your last answer does not count because it was answered after the time was up. Please push the continue button to finish the lesson. This message has been fixed. Does an immediate redirect now as well. > If the "Return to Lesson" button is clicked the user is returned to the course page and not not the lesson. Is your course named "Lesson"? There is a button at the bottom on the End of Lesson page that returns you to your course ("Return to COURSE_NAME"). >Furthermore, the lesson appears to be ended once the time is up - this is at odds with the description of what happens in the "Timed" help file.. The help file is saying that the JavaScript will not perform an automatic redirect when time is up. The lesson is however ended whenever the user navigates to a new page after the time is up.
Hide
Permalink
Nicolas Martignoni added a comment -

Suggesting the non-deletion of the 2 strings, as this is our policy for obsolete strings. See MDL-6645.

Show
Nicolas Martignoni added a comment - Suggesting the non-deletion of the 2 strings, as this is our policy for obsolete strings. See MDL-6645.
Hide
Permalink
Ray Lawrence added a comment - - edited

Thanks.

"Lesson", yes it's called that. I changed the short name to test but not the Full name. Doh.

I get a little concerned with terminology like this in help files as most users don't know (or care) about things like JavaScript.

Is this clearer do you think?

"This puts a time limit on the lesson and students are shown a counter. The time elapsed is recorded in the database each time a question is submitted. A student may continue to answer questions when the time is up, however, these questions not counted in the grade for the attempt."

Original:

"This puts a time limit on the lesson. Students are shown a JavaScript counter and the time is recorded in the database. Due to the inconsistent nature of JavaScript, the timer does not evict a student from the lesson when the time is up, however a question answered after the time limit is not counted. The time in the database is checked each time a student submits a question."

Show
Ray Lawrence added a comment - - edited Thanks. "Lesson", yes it's called that. I changed the short name to test but not the Full name. Doh. I get a little concerned with terminology like this in help files as most users don't know (or care) about things like JavaScript. Is this clearer do you think? "This puts a time limit on the lesson and students are shown a counter. The time elapsed is recorded in the database each time a question is submitted. A student may continue to answer questions when the time is up, however, these questions not counted in the grade for the attempt." Original: "This puts a time limit on the lesson. Students are shown a JavaScript counter and the time is recorded in the database. Due to the inconsistent nature of JavaScript, the timer does not evict a student from the lesson when the time is up, however a question answered after the time limit is not counted. The time in the database is checked each time a student submits a question."
Hide
Permalink
Ray Lawrence added a comment -

Nicolas,

What's been deleted?

Show
Ray Lawrence added a comment - Nicolas, What's been deleted?

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.