Issue Details (XML | Word | Printable)

Key: MDL-12698
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Some refinements to componentlib (defines and method to download .md5 files)

Created: 22/Dec/07 04:57 AM   Updated: 31/Dec/07 10:21 AM
Return to search
Component/s: Lib
Affects Version/s: 1.9
Fix Version/s: 1.9, 2.0

Issue Links:
Relates
 

Database: Any
Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
Resolved date: 31/Dec/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Perform some improvements to the componentlib library:

1) Rename some currently used defines that are very much "general" (ERROR, INSTALLED...) to some more "componentlib alternatives (COMPONENTLIB_ERROR...) to avoid collisions with other parts of Moodle.

2) Componentlib behaviour uses to download TWO files, the zip file itself and another one containing the md5 of the zip file. Currently only the zip file is downloaded using the standard download_file_content() function. Make that the md5 download to use that function too.

3) Obviously, update all the uses of the above 1 & 2 in core (environmental stuff and lang files).

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 31/Dec/07 07:26 AM
except the short define names should be fixed in cvs, I had to add a new string into installer to explain the need for curl (not backwards compatible with 1.6-1.8)

please reopen in case of any problems, thanks!


Eloy Lafuente (stronk7) added a comment - 31/Dec/07 10:21 AM
Now constants have been renamed too, to COMPONENT_XXXX to make them more specific.

I've tested environment, langs and install / upgrade and seems to work ok.

Ciao