Moodle

Some refinements to componentlib (defines and method to download .md5 files)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9, 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Perform some improvements to the componentlib library:

1) Rename some currently used defines that are very much "general" (ERROR, INSTALLED...) to some more "componentlib alternatives (COMPONENTLIB_ERROR...) to avoid collisions with other parts of Moodle.

2) Componentlib behaviour uses to download TWO files, the zip file itself and another one containing the md5 of the zip file. Currently only the zip file is downloaded using the standard download_file_content() function. Make that the md5 download to use that function too.

3) Obviously, update all the uses of the above 1 & 2 in core (environmental stuff and lang files).

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

except the short define names should be fixed in cvs, I had to add a new string into installer to explain the need for curl (not backwards compatible with 1.6-1.8)

please reopen in case of any problems, thanks!

Show
Petr Škoda (skodak) added a comment - except the short define names should be fixed in cvs, I had to add a new string into installer to explain the need for curl (not backwards compatible with 1.6-1.8) please reopen in case of any problems, thanks!
Hide
Eloy Lafuente (stronk7) added a comment -

Now constants have been renamed too, to COMPONENT_XXXX to make them more specific.

I've tested environment, langs and install / upgrade and seems to work ok.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Now constants have been renamed too, to COMPONENT_XXXX to make them more specific. I've tested environment, langs and install / upgrade and seems to work ok. Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: