Issue Details (XML | Word | Printable)

Key: MDL-12698
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Some refinements to componentlib (defines and method to download .md5 files)

Created: 22/Dec/07 04:57 AM   Updated: 31/Dec/07 10:21 AM
Return to search
Component/s: Lib
Affects Version/s: 1.9
Fix Version/s: 1.9, 2.0

Issue Links:
Relates
 

Database: Any
Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
Resolved date: 31/Dec/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Perform some improvements to the componentlib library:

1) Rename some currently used defines that are very much "general" (ERROR, INSTALLED...) to some more "componentlib alternatives (COMPONENTLIB_ERROR...) to avoid collisions with other parts of Moodle.

2) Componentlib behaviour uses to download TWO files, the zip file itself and another one containing the md5 of the zip file. Currently only the zip file is downloaded using the standard download_file_content() function. Make that the md5 download to use that function too.

3) Obviously, update all the uses of the above 1 & 2 in core (environmental stuff and lang files).

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 8 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/Dec/07 07:18 AM
MDL-12698, MDL-12569 - componentlib & langimport improvements and fixes
MODIFY lib/languages.md5   Rev. 1.1.18.1    (+1 -1 lines)
MODIFY lib/componentlib.class.php   Rev. 1.7.2.4    (+31 -34 lines)
MODIFY install.php   Rev. 1.80.2.6    (+2 -2 lines)
MODIFY admin/langimport.php   Rev. 1.36.2.3    (+169 -164 lines)
MODIFY install/stringnames.txt   Rev. 1.3.2.2    (+1 -0 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.23    (+4 -2 lines)
MODIFY admin/environment.php   Rev. 1.19.2.1    (+2 -2 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.26.2.5    (+2 -1 lines)
Petr Skoda committed 8 files to 'Moodle CVS' - 31/Dec/07 07:19 AM
MDL-12698, MDL-12569 - componentlib & langimport improvements and fixes; merged from MOODLE_19_STABLE
MODIFY lang/en_utf8/error.php   Rev. 1.31    (+2 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.177    (+4 -2 lines)
MODIFY lib/languages.md5   Rev. 1.2    (+1 -1 lines)
MODIFY lib/componentlib.class.php   Rev. 1.11    (+31 -34 lines)
MODIFY install.php   Rev. 1.86    (+2 -2 lines)
MODIFY admin/environment.php   Rev. 1.20    (+2 -2 lines)
MODIFY install/stringnames.txt   Rev. 1.5    (+1 -0 lines)
MODIFY admin/langimport.php   Rev. 1.39    (+169 -164 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/Dec/07 07:35 AM
MDL-12698, MDL-12569 - fixed inline docs
MODIFY admin/langimport.php   Rev. 1.36.2.4    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 31/Dec/07 07:36 AM
MDL-12698, MDL-12569 - fixed inline docs; merged from MOODLE_19_STABLE
MODIFY admin/langimport.php   Rev. 1.40    (+2 -2 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 31/Dec/07 07:57 AM
Translated new strings for admin and error - componentlib & langimport improvements and fixes MDL-12698, MDL-12569.
MODIFY ja_utf8/admin.php   Rev. 1.232    (+3 -1 lines)
MODIFY ja_utf8/error.php   Rev. 1.35    (+1 -0 lines)
Eloy Lafuente (stronk7) committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/Dec/07 10:03 AM
Change some constants to avoid name collisions. MDL-12698
MODIFY admin/langimport.php   Rev. 1.36.2.5    (+9 -9 lines)
MODIFY install.php   Rev. 1.80.2.7    (+5 -5 lines)
MODIFY lib/adminlib.php   Rev. 1.153.2.25    (+3 -3 lines)
MODIFY lib/componentlib.class.php   Rev. 1.7.2.5    (+31 -31 lines)
Eloy Lafuente (stronk7) committed 4 files to 'Moodle CVS' - 31/Dec/07 10:07 AM
Change some constants to avoid name collisions. MDL-12698 ; Merged from MOODLE_19_STABLE
MODIFY admin/langimport.php   Rev. 1.41    (+9 -9 lines)
MODIFY lib/adminlib.php   Rev. 1.178    (+3 -3 lines)
MODIFY lib/componentlib.class.php   Rev. 1.12    (+31 -31 lines)
MODIFY install.php   Rev. 1.87    (+5 -5 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 31/Dec/07 10:09 AM
Missed this in my previous commit. MDL-12698
MODIFY admin/environment.php   Rev. 1.19.2.2    (+6 -6 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 31/Dec/07 10:10 AM
Missed this in my previous commit. MDL-12698 ; merged from 19_STABLE
MODIFY admin/environment.php   Rev. 1.21    (+6 -6 lines)
martignoni committed 2 files to 'Lang CVS' - 31/Dec/07 06:42 PM
MDL-12698, MDL-12569 - componentlib & langimport improvements and fixes
MODIFY fr_utf8/admin.php   Rev. 1.225    (+3 -1 lines)
MODIFY fr_utf8/error.php   Rev. 1.35    (+1 -0 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators