Moodle

Some Site Admnistration links are shown as folders. They cannot be opened.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9, 2.0
  • Component/s: Administration, Authentication, Blocks
  • Labels:
    None
  • Environment:
    linux, running on Cpanel hosting server.
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Some Site Administration lnks don't work as links. They turned out to be folders. Now I can also see an unusual spacing between the administration content. This happened after I updated an existing moodle 1.9 package to a later version.

Issue Links

This issue is duplicated by:
MDL-12708 The site administration links don't wok - they act as folders Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

What role did you have?
Does it work for administrator?

Show
Petr Škoda (skodak) added a comment - What role did you have? Does it work for administrator?
Hide
Permalink
Abhilash Jayan added a comment -

I have the role of an administrator. I did not check with other roles.
I had actually upgraded to the latest version of Moodle (1.9) from a little old 1.9.

Show
Abhilash Jayan added a comment - I have the role of an administrator. I did not check with other roles. I had actually upgraded to the latest version of Moodle (1.9) from a little old 1.9.
Hide
Permalink
Abhilash Jayan added a comment -

I tried loggong in fom Mozilla, the problem doesn't exist. I found the problem with IE7 with Vista

Show
Abhilash Jayan added a comment - I tried loggong in fom Mozilla, the problem doesn't exist. I found the problem with IE7 with Vista
Hide
Permalink
Abhilash Jayan added a comment - - edited

I just tried it now, but neither IE nor Firefox can I change the role from Administrator to Course Creator
This is the website, it tries to go to, but I get a "cannot display the website" error.
http://trio.hostagig.com/course/view.php?id=16&sesskey=LUBEQxTigg&switchrole=2

Show
Abhilash Jayan added a comment - - edited I just tried it now, but neither IE nor Firefox can I change the role from Administrator to Course Creator This is the website, it tries to go to, but I get a "cannot display the website" error. http://trio.hostagig.com/course/view.php?id=16&sesskey=LUBEQxTigg&switchrole=2
Hide
Permalink
Abhilash Jayan added a comment - - edited

I just figured one more thing. I installed the attendance block, and now I cannot open many links. It opens up but just shows me a blank page.
The ones that doesn't open is the one with
/admin/settings.php?section=something

Show
Abhilash Jayan added a comment - - edited I just figured one more thing. I installed the attendance block, and now I cannot open many links. It opens up but just shows me a blank page. The ones that doesn't open is the one with /admin/settings.php?section=something
Hide
Permalink
Petr Škoda (skodak) added a comment -

The attendance block problem should not be related. You can not just "change" roles, you have to create a new account first.
Could please try to install latest fresh 1.9dev?

Unfortunately I do not have neither Vista/XP nor IE7 and I am not planning to buy it anytime soon, I will have to pass this on to some other developer who may try to reproduce it after New Year.

Show
Petr Škoda (skodak) added a comment - The attendance block problem should not be related. You can not just "change" roles, you have to create a new account first. Could please try to install latest fresh 1.9dev? Unfortunately I do not have neither Vista/XP nor IE7 and I am not planning to buy it anytime soon, I will have to pass this on to some other developer who may try to reproduce it after New Year.
Hide
Permalink
Mauno Korpelainen added a comment -

Hi Petr,

the problem seems to be that <div class="depth2"> links are not visible in IE7. Items and folders of class dept1 are OK.

Show
Mauno Korpelainen added a comment - Hi Petr, the problem seems to be that <div class="depth2"> links are not visible in IE7. Items and folders of class dept1 are OK.
Hide
Permalink
Mauno Korpelainen added a comment -

This seems to happen also in IE6 (I tested it with Vista and Windows 2000 with the latest moodle 1.9 beta without any non standard activities.) It looks more like a CSS bug but I did not find anything "wrong" from your new code of blocks/admin_tree/block_admin_tree.php or standard theme css...

Show
Mauno Korpelainen added a comment - This seems to happen also in IE6 (I tested it with Vista and Windows 2000 with the latest moodle 1.9 beta without any non standard activities.) It looks more like a CSS bug but I did not find anything "wrong" from your new code of blocks/admin_tree/block_admin_tree.php or standard theme css...
Hide
Permalink
Dan Poltawski added a comment -

Just found a vista box to test this on, and confirming the problem.

Show
Dan Poltawski added a comment - Just found a vista box to test this on, and confirming the problem.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Could you please try to turn off javascript in IE7/Vista? If it works without it the problem is in JS, if not the problem is in CSS.

Show
Petr Škoda (skodak) added a comment - Could you please try to turn off javascript in IE7/Vista? If it works without it the problem is in JS, if not the problem is in CSS.
Hide
Permalink
Mauno Korpelainen added a comment - - edited

In my Vista IE7 turning off javascript gave listing of all divs but in Windows2000 with IE6 turning javascript (scripting) off did not help and div class depth2 was invisible. All tags inside div clas admintree are in source code but IE6 just does not show depth2 class links. Another interesting point is that admintree has "empty rows both in IE6 and IE7 (javascript enabled) between links http://korpelainen.net/adminblock2.jpg

The previous version of admintree works ok in this Vista IE7 and Windows2000 IE6 + my XP IE6/7 test sites so this problem popped up after admintree change.

Show
Mauno Korpelainen added a comment - - edited In my Vista IE7 turning off javascript gave listing of all divs but in Windows2000 with IE6 turning javascript (scripting) off did not help and div class depth2 was invisible. All tags inside div clas admintree are in source code but IE6 just does not show depth2 class links. Another interesting point is that admintree has "empty rows both in IE6 and IE7 (javascript enabled) between links http://korpelainen.net/adminblock2.jpg The previous version of admintree works ok in this Vista IE7 and Windows2000 IE6 + my XP IE6/7 test sites so this problem popped up after admintree change.
Hide
Permalink
Dan Poltawski added a comment -

All items display fine with JS off on IE7/vista for me.

Show
Dan Poltawski added a comment - All items display fine with JS off on IE7/vista for me.
Hide
Permalink
Dan Poltawski added a comment -

Have tried to turn on all the javascript debugging seems to give with no clues, so I did some alert() debugging and found getdiv was returning  

Changing the following gets the links to open as a proof of concept.. Some weird weird weird whitespace issue with IE..

$this->content->text .= 'function toggle(divid) {' . "\n";
$this->content->text .= ' if (getdiv(divid).innerHTML == "" || getdiv(divid).innerHTML ==" "){' . "\n";

Show
Dan Poltawski added a comment - Have tried to turn on all the javascript debugging seems to give with no clues, so I did some alert() debugging and found getdiv was returning   Changing the following gets the links to open as a proof of concept.. Some weird weird weird whitespace issue with IE.. $this->content->text .= 'function toggle(divid) {' . "\n"; $this->content->text .= ' if (getdiv(divid).innerHTML == "" || getdiv(divid).innerHTML ==" "){' . "\n";
Hide
Permalink
Petr Škoda (skodak) added a comment -

I am rewriting the switching code to alter css properties instead of the dom manipulation, I hope it will work everywhere - so far seems to work fine in everything else, expect patch later tonight

Show
Petr Škoda (skodak) added a comment - I am rewriting the switching code to alter css properties instead of the dom manipulation, I hope it will work everywhere - so far seems to work fine in everything else, expect patch later tonight
Hide
Permalink
Dan Poltawski added a comment -

Good luck, I brought my work laptop home especially

Show
Dan Poltawski added a comment - Good luck, I brought my work laptop home especially
Hide
Permalink
Petr Škoda (skodak) added a comment -

rewritten js in cvs, please test in all those broken browsers

Show
Petr Škoda (skodak) added a comment - rewritten js in cvs, please test in all those broken browsers
Hide
Permalink
Dan Poltawski added a comment -

Looks great to me on IE7 XP/Vista, IE6 XP, Firefox Win/Mac/Linux, Safari Mac/iPhone. :-D

Better go switch all those computers off now

Show
Dan Poltawski added a comment - Looks great to me on IE7 XP/Vista, IE6 XP, Firefox Win/Mac/Linux, Safari Mac/iPhone. :-D Better go switch all those computers off now
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks for report and testing!

Show
Petr Škoda (skodak) added a comment - thanks for report and testing!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.