Issue Details (XML | Word | Printable)

Key: MDL-12796
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

iplookup rewrite

Created: 02/Jan/08 06:37 AM   Updated: 05/Mar/09 04:16 AM
Return to search
Component/s: General
Affects Version/s: 1.9
Fix Version/s: 1.9

File Attachments: 1. Text File iplookup3.patch (199 kB)
Issue Links:
Dependency
 

Participants: Dan Poltawski, Fernando Granja, Martin Dougiamas and Petr Skoda
Security Level: None
Resolved date: 03/Jan/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
1/lookup:
  a/ NetGeo online request using download_file_content() by default
  b/ GeoLite City local binary data file optional - must be downlaoded/extracted/installed into moodledata/geoip

2/ visialization:
  a/ by default image from ipatlas + css marker
  b/ Google Maps with marker - admins must register sites to get Google Maps API key

3/ remove all old plugins

4/ add admin settings and info

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 02/Jan/08 06:37 AM
Field Original Value New Value
Description lookup:
1/ NetGeo by default
2/ GeoLite city local binery data file optional

visialization:
a/ by default image from ipatlas + css marker
b/ google maps API - admins must register sites to get Google Maps API key 		lookup:
1/ NetGeo by default
2/ GeoLite city local binery data file optional

visialization:
a/ by default image from ipatlas + css marker
b/ google maps API - admins must register sites to get Google Maps API key

remove all old plugins
Petr Skoda made changes - 02/Jan/08 06:38 AM
Link This issue will help resolve MDL-10194 [ MDL-10194 ]
Petr Skoda made changes - 02/Jan/08 06:38 AM
Link This issue will help resolve MDL-6246 [ MDL-6246 ]
Petr Skoda made changes - 02/Jan/08 06:42 AM
Description lookup:
1/ NetGeo by default
2/ GeoLite city local binery data file optional

visialization:
a/ by default image from ipatlas + css marker
b/ google maps API - admins must register sites to get Google Maps API key

remove all old plugins 		1/lookup:
  a/ NetGeo online request using download_file_content() by default
  b/ GeoLite City local binary data file optional - must be downlaoded/extracted/installed into moodledata/geoip

2/ visialization:
  a/ by default image from ipatlas + css marker
  b/ Google Maps with marker - admins must register sites to get Google Maps API key

3/ remove all old plugins

4/ add admin settings and info
[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 06:44 AM
sending fresh patch, needs testing

Petr Skoda made changes - 02/Jan/08 06:44 AM
Attachment iplookup.patch [ 12729 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 06:46 AM - edited
todo:
  • note the stolen images from ipatlas somewhere
  • review lang strings
  • test
  • add geoip library into docs as used component

[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 07:36 AM
sending new patch , please update from cvs first

fixed:

  • negative longitudes and latitudes from NetGeo - thanks Dan!

Petr Skoda made changes - 02/Jan/08 07:36 AM
Attachment iplookup2.patch [ 12730 ]
Petr Skoda made changes - 02/Jan/08 07:36 AM
Attachment iplookup.patch [ 12729 ]
[ Permalink | « Hide ]
Dan Poltawski added a comment - 02/Jan/08 07:46 AM - edited
The ipatlas image css marker isn't working for me at all ( also the ipatlas image seemed to be corrupted but I don't expect it plays well with diff).

[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 08:08 AM
the problem might be binary in patch file, you can just copy those two images from old ipatlas directory

[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 08:09 AM
moment, I will change it a bit to keep using old files from ipatlas subdirectory

[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 08:13 AM
fresh patch - should be without binary file problems

Petr Skoda made changes - 02/Jan/08 08:13 AM
Attachment iplookup3.patch [ 12731 ]
Petr Skoda made changes - 02/Jan/08 08:13 AM
Attachment iplookup2.patch [ 12730 ]
[ Permalink | « Hide ]
Dan Poltawski added a comment - 02/Jan/08 08:28 AM
Yep, that works fine

[ Permalink | « Hide ]
Dan Poltawski added a comment - 02/Jan/08 08:53 AM - edited
All looks good to me, some really trivial suggestions:

1/ Could you make google maps default to hybrid mode? I think that looks cooler

2/ When no city information is found I get two '-' in the title, which is a bit weird: e.g.

123.45.67.8 - Admin User - - Australia

3/ Change this "By default Moodle uses free online NetGeo (The Internet Geographic Database) server to lookup location of IP addresses, "
to start with: "By default Moodle uses the free online NetGeo"?

4/ Change this "You can either buy commercial version or use free version."
to "You can either buy a commercial version or use the free version."

(assuming there is only one free version, I can't find the page listing them )

5/ Is this string just short so it fits under the image?

"NetGeo server used, it is recommended to install local copy of MaxMind GeoLite database."

If not, we could say something longer e.g.:

"NetGeo is currently being server used for geographical information, it is
recommended to install local a copy of MaxMind GeoLite database for more
accurate results."


[ Permalink | « Hide ]
Martin Dougiamas added a comment - 02/Jan/08 03:47 PM
+2 for 1.9

and further edit on that text:

"The NetGeo server is currently being used to look up geographical information. For more accurate results we recommend installing a local copy of the MaxMind GeoLite database."


[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Jan/08 03:49 PM
oki, I managed to get a new marker for position and working on our own earth xplanet image

Petr Skoda committed 36 files to 'Moodle CVS' - 03/Jan/08 01:47 AM
MDL-12796 iplookup rewrite
ADD lib/geoip/geoip.inc   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/plotconf.inc   Rev. 1.3    (+0 -0 lines)
MODIFY admin/settings/location.php   Rev. 1.7    (+4 -8 lines)
DEL iplookup/ipatlas/Attic/plot.php   Rev. 1.4    (+0 -0 lines)
MODIFY course/lib.php   Rev. 1.547    (+3 -3 lines)
DEL iplookup/hostip/Attic/lib.php   Rev. 1.3    (+0 -0 lines)
MODIFY iplookup/README.txt   Rev. 1.2    (+19 -12 lines)
DEL iplookup/ipatlas/Attic/lib.php   Rev. 1.2    (+0 -0 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.32    (+4 -1 lines)
DEL iplookup/ipatlas/languages/Attic/messages.blank.inc   Rev. 1.2    (+0 -0 lines)
MODIFY iplookup/index.php   Rev. 1.3    (+168 -10 lines)
DEL iplookup/ipatlas/Attic/earth_620.jpg   Rev. 1.2    (+0 -0 lines)
ADD lib/geoip/README.htm   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/hr.gif   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/plot.inc   Rev. 1.3    (+0 -0 lines)
ADD lib/geoip/ChangeLog.htm   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/README.MOODLE.txt   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/MOODLECHANGES   Rev. 1.2    (+0 -0 lines)
ADD lib/geoip/geoipcity.inc   Rev. 1.1    (+0 -0 lines)
MODIFY iplookup/earth.jpeg   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/languages/Attic/messages.it.inc   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/ip-atlas_prefs.php   Rev. 1.4    (+0 -0 lines)
ADD lib/geoip/geoipregionvars.php   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/yellowdot.gif   Rev. 1.2    (+0 -0 lines)
MODIFY iplookup/marker.gif   Rev. 1.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/footer.inc   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/ip-atlas.css   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/COPYING   Rev. 1.2    (+0 -0 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.546    (+8 -0 lines)
DEL iplookup/ipatlas/Attic/plotimage.php   Rev. 1.2    (+0 -0 lines)
MODIFY theme/standard/styles_fonts.css   Rev. 1.152    (+8 -0 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.179    (+10 -0 lines)
DEL iplookup/ipatlas/Attic/translate.inc   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/reddot.gif   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/README   Rev. 1.2    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/countries.txt   Rev. 1.2    (+0 -0 lines)
Petr Skoda committed 36 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 03/Jan/08 01:49 AM
MDL-12796 iplookup rewrite; MFC
MODIFY lib/geoip/README.htm   Rev. 1.1.2.2    (+43 -0 lines)
MODIFY admin/settings/location.php   Rev. 1.4.2.3    (+4 -8 lines)
DEL iplookup/ipatlas/languages/Attic/messages.it.inc   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/footer.inc   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/translate.inc   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY iplookup/earth.jpeg   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.26.2.6    (+4 -1 lines)
DEL iplookup/hostip/Attic/lib.php   Rev. 1.2.4.1    (+0 -0 lines)
MODIFY course/lib.php   Rev. 1.538.2.9    (+3 -3 lines)
DEL iplookup/ipatlas/Attic/hr.gif   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/plot.php   Rev. 1.3.4.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/reddot.gif   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/ip-atlas.css   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY lib/geoip/geoipcity.inc   Rev. 1.1.2.2    (+205 -0 lines)
DEL iplookup/ipatlas/Attic/plot.inc   Rev. 1.2.4.1    (+0 -0 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.25    (+10 -0 lines)
DEL iplookup/ipatlas/Attic/ip-atlas_prefs.php   Rev. 1.3.4.1    (+0 -0 lines)
MODIFY theme/standard/styles_fonts.css   Rev. 1.140.2.12    (+8 -0 lines)
DEL iplookup/ipatlas/Attic/countries.txt   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY iplookup/index.php   Rev. 1.2.8.1    (+168 -10 lines)
DEL iplookup/ipatlas/Attic/README   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY iplookup/README.txt   Rev. 1.1.20.1    (+19 -12 lines)
DEL iplookup/ipatlas/Attic/plotconf.inc   Rev. 1.2.8.1    (+0 -0 lines)
MODIFY iplookup/marker.gif   Rev. 1.1.2.2    (+0 -0 lines)
MODIFY lib/geoip/ChangeLog.htm   Rev. 1.1.2.2    (+44 -0 lines)
DEL iplookup/ipatlas/Attic/lib.php   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY lib/geoip/geoip.inc   Rev. 1.1.2.2    (+498 -0 lines)
DEL iplookup/ipatlas/languages/Attic/messages.blank.inc   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY lib/geoip/geoipregionvars.php   Rev. 1.1.2.2    (+4119 -0 lines)
DEL iplookup/ipatlas/Attic/plotimage.php   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/yellowdot.gif   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/README.MOODLE.txt   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/COPYING   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/earth_620.jpg   Rev. 1.1.20.1    (+0 -0 lines)
DEL iplookup/ipatlas/Attic/MOODLECHANGES   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.516.2.29    (+8 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 03/Jan/08 01:58 AM
new iplookup is in cvs, thanks for review
please reopen in case of any problems

Petr Skoda made changes - 03/Jan/08 01:58 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
martignoni committed 2 files to 'Lang CVS' - 03/Jan/08 03:16 AM
MDL-12796 iplookup rewrite
MODIFY fr_utf8/error.php   Rev. 1.36    (+3 -0 lines)
MODIFY fr_utf8/admin.php   Rev. 1.229    (+7 -0 lines)
Dan Poltawski made changes - 03/Jan/08 03:18 AM
Link This issue will help resolve MDL-3766 [ MDL-3766 ]
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 03/Jan/08 03:57 AM
Translated new strings for iplookup MDL-12796.
MODIFY ja_utf8/error.php   Rev. 1.36    (+3 -0 lines)
MODIFY ja_utf8/admin.php   Rev. 1.234    (+7 -0 lines)
MODIFY ja_utf8/README   Rev. 1.610    (+1 -1 lines)
Petr Skoda made changes - 03/Jan/08 04:45 AM
Link This issue will help resolve MDL-7947 [ MDL-7947 ]
[ Permalink | « Hide ]
Fernando Granja added a comment - 05/Mar/09 01:55 AM
are there any instructions on how to fix the issue or implement the patch?

[ Permalink | « Hide ]
Petr Skoda added a comment - 05/Mar/09 02:08 AM
no, the only way is to upgrade to 1.9.x

[ Permalink | « Hide ]
Fernando Granja added a comment - 05/Mar/09 04:03 AM
Does anyone know where to get MaxMind GeoLite database documentation it install in moodle?

[ Permalink | « Hide ]
Petr Skoda added a comment - 05/Mar/09 04:16 AM
Please use moodle.org forums for general support questions.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators