Moodle

iplookup rewrite

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: General
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

1/lookup:
a/ NetGeo online request using download_file_content() by default
b/ GeoLite City local binary data file optional - must be downlaoded/extracted/installed into moodledata/geoip

2/ visialization:
a/ by default image from ipatlas + css marker
b/ Google Maps with marker - admins must register sites to get Google Maps API key

3/ remove all old plugins

4/ add admin settings and info

Issue Links

This issue will help resolve:
MDL-10194 A fix to iplookup/hostip for IE browsers Minor Closed
MDL-6246 replace ip lookup with something better Trivial Closed
MDL-7947 Use CURL extension functions instead of snoopy and fopen() if available Minor Closed
MDL-3766 ip locator Trivial Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending fresh patch, needs testing

Show
Petr Škoda (skodak) added a comment - sending fresh patch, needs testing
Hide
Permalink
Petr Škoda (skodak) added a comment - - edited

todo:

  • note the stolen images from ipatlas somewhere
  • review lang strings
  • test
  • add geoip library into docs as used component
Show
Petr Škoda (skodak) added a comment - - edited todo:
  • note the stolen images from ipatlas somewhere
  • review lang strings
  • test
  • add geoip library into docs as used component
Hide
Permalink
Petr Škoda (skodak) added a comment -

sending new patch , please update from cvs first

fixed:

  • negative longitudes and latitudes from NetGeo - thanks Dan!
Show
Petr Škoda (skodak) added a comment - sending new patch , please update from cvs first fixed:
  • negative longitudes and latitudes from NetGeo - thanks Dan!
Hide
Permalink
Dan Poltawski added a comment - - edited

The ipatlas image css marker isn't working for me at all ( also the ipatlas image seemed to be corrupted but I don't expect it plays well with diff).

Show
Dan Poltawski added a comment - - edited The ipatlas image css marker isn't working for me at all ( also the ipatlas image seemed to be corrupted but I don't expect it plays well with diff).
Hide
Permalink
Petr Škoda (skodak) added a comment -

the problem might be binary in patch file, you can just copy those two images from old ipatlas directory

Show
Petr Škoda (skodak) added a comment - the problem might be binary in patch file, you can just copy those two images from old ipatlas directory
Hide
Permalink
Petr Škoda (skodak) added a comment -

moment, I will change it a bit to keep using old files from ipatlas subdirectory

Show
Petr Škoda (skodak) added a comment - moment, I will change it a bit to keep using old files from ipatlas subdirectory
Hide
Permalink
Petr Škoda (skodak) added a comment -

fresh patch - should be without binary file problems

Show
Petr Škoda (skodak) added a comment - fresh patch - should be without binary file problems
Hide
Permalink
Dan Poltawski added a comment -

Yep, that works fine

Show
Dan Poltawski added a comment - Yep, that works fine
Hide
Permalink
Dan Poltawski added a comment - - edited

All looks good to me, some really trivial suggestions:

1/ Could you make google maps default to hybrid mode? I think that looks cooler

2/ When no city information is found I get two '-' in the title, which is a bit weird: e.g.

123.45.67.8 - Admin User - - Australia

3/ Change this "By default Moodle uses free online NetGeo (The Internet Geographic Database) server to lookup location of IP addresses, "
to start with: "By default Moodle uses the free online NetGeo"?

4/ Change this "You can either buy commercial version or use free version."
to "You can either buy a commercial version or use the free version."

(assuming there is only one free version, I can't find the page listing them )

5/ Is this string just short so it fits under the image?

"NetGeo server used, it is recommended to install local copy of MaxMind GeoLite database."

If not, we could say something longer e.g.:

"NetGeo is currently being server used for geographical information, it is
recommended to install local a copy of MaxMind GeoLite database for more
accurate results."

Show
Dan Poltawski added a comment - - edited All looks good to me, some really trivial suggestions: 1/ Could you make google maps default to hybrid mode? I think that looks cooler 2/ When no city information is found I get two '-' in the title, which is a bit weird: e.g. 123.45.67.8 - Admin User - - Australia 3/ Change this "By default Moodle uses free online NetGeo (The Internet Geographic Database) server to lookup location of IP addresses, " to start with: "By default Moodle uses the free online NetGeo"? 4/ Change this "You can either buy commercial version or use free version." to "You can either buy a commercial version or use the free version." (assuming there is only one free version, I can't find the page listing them ) 5/ Is this string just short so it fits under the image? "NetGeo server used, it is recommended to install local copy of MaxMind GeoLite database." If not, we could say something longer e.g.: "NetGeo is currently being server used for geographical information, it is recommended to install local a copy of MaxMind GeoLite database for more accurate results."
Hide
Permalink
Martin Dougiamas added a comment -

+2 for 1.9

and further edit on that text:

"The NetGeo server is currently being used to look up geographical information. For more accurate results we recommend installing a local copy of the MaxMind GeoLite database."

Show
Martin Dougiamas added a comment - +2 for 1.9 and further edit on that text: "The NetGeo server is currently being used to look up geographical information. For more accurate results we recommend installing a local copy of the MaxMind GeoLite database."
Hide
Permalink
Petr Škoda (skodak) added a comment -

oki, I managed to get a new marker for position and working on our own earth xplanet image

Show
Petr Škoda (skodak) added a comment - oki, I managed to get a new marker for position and working on our own earth xplanet image
Hide
Permalink
Petr Škoda (skodak) added a comment -

new iplookup is in cvs, thanks for review
please reopen in case of any problems

Show
Petr Škoda (skodak) added a comment - new iplookup is in cvs, thanks for review please reopen in case of any problems
Hide
Permalink
Fernando Granja added a comment -

are there any instructions on how to fix the issue or implement the patch?

Show
Fernando Granja added a comment - are there any instructions on how to fix the issue or implement the patch?
Hide
Permalink
Petr Škoda (skodak) added a comment -

no, the only way is to upgrade to 1.9.x

Show
Petr Škoda (skodak) added a comment - no, the only way is to upgrade to 1.9.x
Hide
Permalink
Fernando Granja added a comment -

Does anyone know where to get MaxMind GeoLite database documentation it install in moodle?

Show
Fernando Granja added a comment - Does anyone know where to get MaxMind GeoLite database documentation it install in moodle?
Hide
Permalink
Petr Škoda (skodak) added a comment -

Please use moodle.org forums for general support questions.

Show
Petr Škoda (skodak) added a comment - Please use moodle.org forums for general support questions.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.