[#MDL-12796] iplookup rewrite

Issue Details (XML | Word | Printable)

Key:	MDL-12796
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

iplookup rewrite

Created: 02/Jan/08 06:37 AM Updated: 05/Mar/09 04:16 AM

Return to search

Component/s:

General

Affects Version/s:

1.9

Fix Version/s:

1.9

File Attachments:

iplookup3.patch (199 kB)

Issue Links:

Dependency

This issue will help resolve:

~~MDL-10194~~ A fix to iplookup/hostip for IE browsers

~~MDL-6246~~ replace ip lookup with something better

~~MDL-7947~~ Use CURL extension functions instead of snoopy and fopen() if available

~~MDL-3766~~ ip locator

Participants:	Dan Poltawski, Fernando Granja, Martin Dougiamas and Petr Skoda
Security Level:	None
Resolved date:	03/Jan/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

1/lookup:
  a/ NetGeo online request using download_file_content() by default
  b/ GeoLite City local binary data file optional - must be downlaoded/extracted/installed into moodledata/geoip

2/ visialization:
  a/ by default image from ipatlas + css marker
  b/ Google Maps with marker - admins must register sites to get Google Maps API key

3/ remove all old plugins

4/ add admin settings and info

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 06:44 AM

sending fresh patch, needs testing

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 06:46 AM - edited

todo:

note the stolen images from ipatlas somewhere
review lang strings
test
add geoip library into docs as used component

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 07:36 AM

sending new patch , please update from cvs first

fixed:

negative longitudes and latitudes from NetGeo - thanks Dan!

[ Permalink | « Hide ]

Dan Poltawski added a comment - 02/Jan/08 07:46 AM - edited

The ipatlas image css marker isn't working for me at all ( also the ipatlas image seemed to be corrupted but I don't expect it plays well with diff).

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 08:08 AM

the problem might be binary in patch file, you can just copy those two images from old ipatlas directory

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 08:09 AM

moment, I will change it a bit to keep using old files from ipatlas subdirectory

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 08:13 AM

fresh patch - should be without binary file problems

[ Permalink | « Hide ]

Dan Poltawski added a comment - 02/Jan/08 08:28 AM

Yep, that works fine

[ Permalink | « Hide ]

Dan Poltawski added a comment - 02/Jan/08 08:53 AM - edited

All looks good to me, some really trivial suggestions:

1/ Could you make google maps default to hybrid mode? I think that looks cooler

2/ When no city information is found I get two '-' in the title, which is a bit weird: e.g.

123.45.67.8 - Admin User - - Australia

3/ Change this "By default Moodle uses free online NetGeo (The Internet Geographic Database) server to lookup location of IP addresses, "
to start with: "By default Moodle uses the free online NetGeo"?

4/ Change this "You can either buy commercial version or use free version."
to "You can either buy a commercial version or use the free version."

(assuming there is only one free version, I can't find the page listing them )

5/ Is this string just short so it fits under the image?

"NetGeo server used, it is recommended to install local copy of MaxMind GeoLite database."

If not, we could say something longer e.g.:

"NetGeo is currently being server used for geographical information, it is
recommended to install local a copy of MaxMind GeoLite database for more
accurate results."

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 02/Jan/08 03:47 PM

+2 for 1.9

and further edit on that text:

"The NetGeo server is currently being used to look up geographical information. For more accurate results we recommend installing a local copy of the MaxMind GeoLite database."

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Jan/08 03:49 PM

oki, I managed to get a new marker for position and working on our own earth xplanet image

[ Permalink | « Hide ]

Petr Skoda added a comment - 03/Jan/08 01:58 AM

new iplookup is in cvs, thanks for review
please reopen in case of any problems

[ Permalink | « Hide ]

Fernando Granja added a comment - 05/Mar/09 01:55 AM

are there any instructions on how to fix the issue or implement the patch?

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Mar/09 02:08 AM

no, the only way is to upgrade to 1.9.x

[ Permalink | « Hide ]

Fernando Granja added a comment - 05/Mar/09 04:03 AM

Does anyone know where to get MaxMind GeoLite database documentation it install in moodle?

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Mar/09 04:16 AM

Please use moodle.org forums for general support questions.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.