[#MDL-12824] Essay type of quiz questions needs to color mark which students have been graded and which have NOT

Moodle

Essay type of quiz questions needs to color mark which students have been graded and which have NOT

Created: 04/Jan/08 05:22 AM Updated: 10/Jun/08 01:46 PM

Component/s:

Quiz

Affects Version/s:

1.8

Fix Version/s:

1.9.2

File Attachments:

MDL_12824.diff.txt (2 kb)

Image Attachments:

1. collapse_issue.png (18 kb)	2. essay_quiz_after_patch.png (134 kb)	3. essay_quiz_before_patch.png (133 kb)
4. trac_diff.png (88 kb)

Issue Links:

Dependency

This issue will help resolve:

~~MDL-6316~~ Option to list only ungraded or graded manual grading questions

Duplicate

This issue is duplicated by:

~~MDL-13495~~ no distinction between graded & ungraded questions in manual grading report

Participants:	Jamie Pratt, Jerome Mouneyrac, Matt Oquist, Tim Hunt and Wen Hao Chuang
Security Level:	None
QA Assignee:	Jerome Mouneyrac

Description

« Hide

Somehow this behavior got changed in moodle 1.8 (I haven't tested 1.7 yet), in moodle 1.5.x it used to be after you grade the essay questions, when you see the "results" tab in the "Action" field, if you have graded a particular student, it will show in green color, but if you haven't graded the student, it will show in red color. Please see screenshot.

Here is how you repo:
1. Login as admin or teacher, enter a course and create a quiz with "essay" type of questions
2. Login as couple of students, and type something and then submit your answers
3. Login as admin or teacher again, then go to the Quizzes link and then click on that particular quiz
4. You will see under the "Reults" tab, you can't tell which student has been graded and which have NOT yet been graded...

I have also proposed a patch here (see diff file), hope this helps.

This issue become very important especially when you have a LARGE class (e.g. 1000+ students) where a instructor has to track which students has been graded and which has not...

All

Comments

Change History

Version Control

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Wen Hao Chuang - 04/Jan/08 05:24 AM

proposed patch

[ Permlink | « Hide ]

Wen Hao Chuang - 04/Jan/08 05:30 AM

by the way, Red and Green should not be the only grading status indicators, in particular with color blindness issues.

W3C Check Point 2.1 Ensure that all information conveyed with color is also available without color, for example from context or markup.

W3C Reccomendations http://www.w3.org/TR/WAI-WEBCONTENT-TECHS/#tech-color-convey

So in the proposed patch we also provided a fix for the collapse issue (see the screenshot "collape_issue")

[ Permlink | « Hide ]

Tim Hunt - 09/Jan/08 03:52 AM

The patch looks about right, but:

It is really bad to hard-code colours. Leave the HTML saying class="...", and then add appropriate rules the the standard theme stylesheet.

The changes around like 200 look bogus to me.

Please attach the patch as a unified diff so that I can apply it to my copy of the code. I can't do anything with an image.

Do you really need the call to get_question_states? can't the $grade = '-'; line just go in the if (!$this->is_graded(...? if so, it would be more efficient.

Also, you seem to set the $gradetext variable and never use it.

If you can submit a revised patch, I would be happy to apply it.

[ Permlink | « Hide ]

Wen Hao Chuang - 11/Jan/08 09:32 AM - edited

OK here is the original unified diff file, sorry I haven't got time to look into the comments that you had... sorry about this...

[ Permlink | « Hide ]

Wen Hao Chuang - 02/Feb/08 07:14 AM

I noticed that in 1.9 this is still the case, I will propose a better fix (instead of hard-coded with color codes) later..

[ Permlink | « Hide ]

Tim Hunt - 18/Feb/08 08:05 PM

Patch in the duplicate issue. Not sure I like the solution proposed there.

[ Permlink | « Hide ]

Matt Oquist - 26/Mar/08 10:47 AM

I submitted the patch in the duplicate issue. Here are the reasons I arrived at the solution my patch implements:

* no change to existing functionality WRT color distinctions (this is theme-dependent, and broken for the default theme)
* textual distinction minimizes accessibility concerns (color-blindness)
* symbolic text ("***") alleviates translation dependencies
* minimally invasive patch

All other suggestions are welcome; those were my considerations.

Also, I realize the quiz module is going to be totally rewritten for 2.0, so this solution (whatever it ends up being) is really only for <=1.9.

Cheers!

[ Permlink | « Hide ]

Tim Hunt - 04/Apr/08 11:33 PM

Assigning quiz report issues mentioned in http://docs.moodle.org/en/Development:Quiz_report_enhancements to Jamie.

[ Permlink | « Hide ]

Wen Hao Chuang - 11/Apr/08 05:45 AM

Jamie any update on this please? Thanks! :)

[ Permlink | « Hide ]

Wen Hao Chuang - 22/May/08 06:03 AM

Also add Martin to the watch list, comments or thoughts? Thanks!

[ Permlink | « Hide ]

Jamie Pratt - 07/Jun/08 08:15 PM

Resolved in HEAD and 1.9.

[ Permlink | « Hide ]

Jerome Mouneyrac - 10/Jun/08 01:46 PM

Graded attempt are highlighted in yellow in the "Manual Grading" tab.
Good.