Issue Details (XML | Word | Printable)

Key: MDL-12843
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Kenneth Newquist
Votes: 4
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Forum Digest Emails do not include proper CSS tag

Created: 06/Jan/08 05:51 AM   Updated: 09/Jul/08 06:43 PM
Return to search
Component/s: Forum
Affects Version/s: 1.8.2, 1.8.3
Fix Version/s: 1.8.6, 1.9.2

File Attachments: 1. Text File digest_email_css_patch.txt (0.6 kB)

Environment: Moodle 1.8.3 (2007021534)

Participants: Dongsheng Cai, Kenneth Newquist and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 02/Jul/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
The HTML for the format digests does not include the proper CSS to style the background color of the forum digest e-mail. The ID "email" needs to be included. Modify /htdocs/mod/forum/lib.php at line 598:

Original code:
$posthtml .= "</head>\n<body>\n";

Fixed code:
$posthtml .= "</head>\n<body id=\"email\">\n";



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Kenneth Newquist added a comment - 01/Jul/08 11:10 PM
This problem remains in Moodle 1.9.1 (Build: 20080515), but looking back through the code, I'm not sure what #email is being used for.

I see the CSS in the standard theme, nestled in the "Modules: Forum" section:

#email .unsubscribelink {
margin-top:20px;
border-width: 0px 1px 0px 0px;
border-style: solid;
text-align:center;
}

but a search of the Moodle code base doesn't turn up any references to id="email". Is the style no longer used, or was in inadvertently omitted at some point? I'm guessing on the later. I'm attaching a patch to tweak this under 1.9.1.

Ken


Dongsheng Cai added a comment - 02/Jul/08 03:36 PM
Thank your patc, Kenneth, please review, TIA.

Petr Skoda added a comment - 09/Jul/08 06:43 PM
some clients ignore external css styles for security reasons, but anyway it is good to add this id
thanks, closing