Moodle

Messaging popups bad XHTML

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9.1
  • Component/s: Accessibility
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Almost all of the messaging tabs are broken XHTML wise.

Attachments

  1. Text File
    message_weblib.php.patch
    02/May/08 11:19 AM
    2 kB
    Jerome Mouneyrac
  2. Text File
    message.patch
    02/May/08 12:00 PM
    3 kB
    Jerome Mouneyrac

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Jerome, could you take a look to this. It seems that the 3 tabs available in the messaging popup have minor XHTML problems.

Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Hi Jerome, could you take a look to this. It seems that the 3 tabs available in the messaging popup have minor XHTML problems. Thanks!
Hide
Permalink
Jerome Mouneyrac added a comment - - edited

Patches attached. xhtml should be valided now.

Show
Jerome Mouneyrac added a comment - - edited Patches attached. xhtml should be valided now.
Hide
Permalink
Martin Dougiamas added a comment -

Looks all OK, except for the inline style in there:

style="text-align:center"

You need to do that with a CSS class, inline CSS is a big no no.

Show
Martin Dougiamas added a comment - Looks all OK, except for the inline style in there: style="text-align:center" You need to do that with a CSS class, inline CSS is a big no no.
Hide
Permalink
Jerome Mouneyrac added a comment -

Patched updated. Commited in trunk and 1.9

Show
Jerome Mouneyrac added a comment - Patched updated. Commited in trunk and 1.9
Hide
Permalink
Helen Foster added a comment -

Jerome, thanks for fixing

Show
Helen Foster added a comment - Jerome, thanks for fixing

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.