Issue Details (XML | Word | Printable)

Key: MDL-12864
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Dan Poltawski
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Messaging popups bad XHTML

Created: 07/Jan/08 11:07 PM   Updated: 06/May/08 05:00 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.9
Fix Version/s: 1.9.1

File Attachments: 1. Text File message.patch (3 kB)
2. Text File message_weblib.php.patch (2 kB)


Participants: Dan Poltawski, Eloy Lafuente (stronk7), Helen Foster, Jerome Mouneyrac and Martin Dougiamas
Security Level: None
QA Assignee: Helen Foster
Resolved date: 02/May/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Almost all of the messaging tabs are broken XHTML wise.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 01/May/08 08:54 AM
Hi Jerome, could you take a look to this. It seems that the 3 tabs available in the messaging popup have minor XHTML problems.

Thanks!


Jerome Mouneyrac added a comment - 02/May/08 11:18 AM - edited
Patches attached. xhtml should be valided now.

Martin Dougiamas added a comment - 02/May/08 11:48 AM
Looks all OK, except for the inline style in there:

style="text-align:center"

You need to do that with a CSS class, inline CSS is a big no no.


Jerome Mouneyrac added a comment - 02/May/08 01:25 PM
Patched updated. Commited in trunk and 1.9

Helen Foster added a comment - 06/May/08 05:00 PM
Jerome, thanks for fixing