[#MDL-12864] Messaging popups bad XHTML

Issue Details (XML | Word | Printable)

Key:	MDL-12864
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Jerome Mouneyrac
Reporter:	Dan Poltawski
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Messaging popups bad XHTML

Created: 07/Jan/08 11:07 PM Updated: 06/May/08 05:00 PM

Return to search

Component/s:

Accessibility

Affects Version/s:

1.9

Fix Version/s:

1.9.1

File Attachments:

message.patch (3 kB)
2.

message_weblib.php.patch (2 kB)

Participants:	Dan Poltawski, Eloy Lafuente (stronk7), Helen Foster, Jerome Mouneyrac and Martin Dougiamas
Security Level:	None
QA Assignee:	Helen Foster
Resolved date:	02/May/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Almost all of the messaging tabs are broken XHTML wise.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 01/May/08 08:54 AM

Hi Jerome, could you take a look to this. It seems that the 3 tabs available in the messaging popup have minor XHTML problems.

Thanks!

Eloy Lafuente (stronk7) made changes - 01/May/08 08:54 AM

Field	Original Value	New Value
Assignee	Martin Dougiamas [ dougiamas ]	Jerome Mouneyrac [ jerome ]

Eloy Lafuente (stronk7) made changes - 01/May/08 08:55 AM

Fix Version/s

1.9.1 [ 10240 ]

[ Permalink | « Hide ]

Jerome Mouneyrac added a comment - 02/May/08 11:18 AM - edited

Patches attached. xhtml should be valided now.

Jerome Mouneyrac made changes - 02/May/08 11:18 AM

Attachment		weblib.php.19.patch [ 13835 ]
Attachment		message.patch [ 13834 ]

Jerome Mouneyrac made changes - 02/May/08 11:19 AM

Attachment

weblib.php.19.patch [ 13835 ]

Jerome Mouneyrac made changes - 02/May/08 11:19 AM

Attachment

message_weblib.php.patch [ 13836 ]

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 02/May/08 11:48 AM

Looks all OK, except for the inline style in there:

style="text-align:center"

You need to do that with a CSS class, inline CSS is a big no no.

Jerome Mouneyrac made changes - 02/May/08 12:00 PM

Attachment

message.patch [ 13834 ]

Jerome Mouneyrac made changes - 02/May/08 12:00 PM

Attachment

message.patch [ 13837 ]

Jerome Mouneyrac committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/May/08 01:09 PM

~~MDL-12864~~ fix bad XHTML in the messaging popup

MODIFY	message/settings.html	Rev. 1.9.4.1	(+2 -2 lines)
MODIFY	message/search.html	Rev. 1.13.4.2	(+2 -2 lines)
MODIFY	message/lib.php	Rev. 1.61.2.10	(+2 -2 lines)
MODIFY	message/index.php	Rev. 1.19.2.1	(+4 -4 lines)

Jerome Mouneyrac committed 4 files to 'Moodle CVS' - 02/May/08 01:15 PM

~~MDL-12864~~ fix bad XHTML for messaging tabs, merged from 19

MODIFY	message/search.html	Rev. 1.15	(+2 -2 lines)
MODIFY	message/index.php	Rev. 1.21	(+4 -4 lines)
MODIFY	message/lib.php	Rev. 1.71	(+2 -2 lines)
MODIFY	message/settings.html	Rev. 1.10	(+2 -2 lines)

Jerome Mouneyrac committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/May/08 01:17 PM

~~MDL-12864~~ fix bad XHTML in the messaging popup

MODIFY

lib/weblib.php

Rev. 1.970.2.84

(+5 -4 lines)

Jerome Mouneyrac committed 1 file to 'Moodle CVS' - 02/May/08 01:20 PM

~~MDL-12864~~ fix bad XHTML in the messaging popup, merged from 19

MODIFY

lib/weblib.php

Rev. 1.1065

(+5 -5 lines)

[ Permalink | « Hide ]

Jerome Mouneyrac added a comment - 02/May/08 01:25 PM

Patched updated. Commited in trunk and 1.9

Jerome Mouneyrac made changes - 02/May/08 01:25 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Helen Foster added a comment - 06/May/08 05:00 PM

Jerome, thanks for fixing

Helen Foster made changes - 06/May/08 05:00 PM

QA Assignee		tsala
Status	Resolved [ 5 ]	Closed [ 6 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.