Moodle

RSS feeds block title corrupted when URL included

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.8.3
  • Fix Version/s: None
  • Component/s: Blocks, RSS
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE

Description

Since upgrading to 1.8.3, many of our RSS feed blocks now have corrupted titles. The problem did not occur in 1.8.2.

An example screenshot is attached. This is a simple link to 'The Economist' news feed, where the 'title' field has been left blank when configuring the block. Judging by the source code, Moodle is inserting the URL of The Economist website into places where it doesn't belong, such as in the ALT text, and in the arguments of the JavaScript function elementToggleHide().

The code on line 262 of blocks/moodleblock.class.php is a starting point for the problem. The problem seems to be that $this->title already contains the hyperlink by the time it is used to form the ALT tag etc.; but I'm not clear as to where $this->title is defined, or what would be the consequences of changing it.

Hopefully someone with better understanding of this class can help?

Issue Links

This issue will be resolved by:
MDL-7493 Make sure standard themes are visible under "Windows High Contrast Black" mode Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

Hi, Could you give an RSS URL which demonstrates this?

Show
Dan Poltawski added a comment - Hi, Could you give an RSS URL which demonstrates this?
Hide
Permalink
Dan Poltawski added a comment -

Hi, I think you were caught by a bug introduced and later fixed by MDL-7493

If you update to the latest moodle 1.8 this should be fixed. I can't reproduce it on recent versions

Show
Dan Poltawski added a comment - Hi, I think you were caught by a bug introduced and later fixed by MDL-7493 If you update to the latest moodle 1.8 this should be fixed. I can't reproduce it on recent versions
Hide
Permalink
Steve Bond added a comment -

Thanks Dan, you're right. Fix is described here: http://cvs.moodle.org/moodle/blocks/moodleblock.class.php

I did search for existing issues but this was rather buried in 7493 so I missed it.

Show
Steve Bond added a comment - Thanks Dan, you're right. Fix is described here: http://cvs.moodle.org/moodle/blocks/moodleblock.class.php I did search for existing issues but this was rather buried in 7493 so I missed it.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.